You are viewing a plain text version of this content. The canonical link for it is here.
Posted to bugs@httpd.apache.org by bu...@apache.org on 2013/08/18 13:41:23 UTC
[Bug 55445] New: mod_socache_memcache ignores expiry, creating
eternal memcache entries
https://issues.apache.org/bugzilla/show_bug.cgi?id=55445
Bug ID: 55445
Summary: mod_socache_memcache ignores expiry, creating eternal
memcache entries
Product: Apache httpd-2
Version: 2.4.6
Hardware: PC
OS: Linux
Status: NEW
Severity: normal
Priority: P2
Component: mod_socache_(dbm|dc|memcache|shmcb)
Assignee: bugs@httpd.apache.org
Reporter: gil@magisto.com
(see also
http://apache-http-server.18135.x6.nabble.com/PATCH-mod-socache-memcache-don-t-ignore-expiry-td5007649.html)
socache_memcache ignores shared object expiry settings, creating keys which are
never cleared from the memcache daemon.
there is a one-line patch and further discussion at the above URL, reposted for
convenience:
--- modules/cache/mod_socache_memcache.c (revision 1510425)
+++ modules/cache/mod_socache_memcache.c (working copy)
@@ -205,9 +205,10 @@
return APR_EINVAL;
}
- /* In APR-util - unclear what 'timeout' is, as it was not implemented */
- rv = apr_memcache_set(ctx->mc, buf, (char*)ucaData, nData, 0, 0);
+ rv = apr_memcache_set(ctx->mc, buf, (char*)ucaData, nData,
+ apr_time_sec(expiry), 0);
+
if (rv != APR_SUCCESS) {
ap_log_error(APLOG_MARK, APLOG_CRIT, rv, s, APLOGNO(00790)
"scache_mc: error setting key '%s' "
I have tested this patch myself and it does indeed cause the correct values to
be sent to the server.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 55445] mod_socache_memcache ignores expiry, creating eternal
memcache entries
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55445
Matt Jamison <ma...@mattjamison.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Hardware|PC |All
Version|2.4.6 |2.4-HEAD
OS|Linux |All
Severity|normal |major
--- Comment #4 from Matt Jamison <ma...@mattjamison.com> ---
Strange, I'm going to tweak some things in the bug just to see if it'll get
someone's attention. Hopefully we can at least get a pointer on how to get
this committed...
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 55445] mod_socache_memcache ignores expiry, creating eternal
memcache entries
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55445
Matt Jamison <ma...@mattjamison.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |matt@mattjamison.com
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 55445] mod_socache_memcache ignores expiry, creating eternal
memcache entries
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55445
--- Comment #2 from Matt Jamison <ma...@mattjamison.com> ---
I realize this post is quite old, but I ran into this same bug today and it
looks from everything I see like this patch was never taken to correct it?
Perhaps I'm missing something, but this module is not as useable as it could be
without the patch provided, since cache entries cannot be expired?
Should this patch be merged or is there some other fix available?
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 55445] mod_socache_memcache ignores expiry, creating eternal
memcache entries
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55445
Eric Covener <co...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |FixedInTrunk
--- Comment #5 from Eric Covener <co...@gmail.com> ---
fixed in trunk http://svn.apache.org/r1649491
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 55445] mod_socache_memcache ignores expiry, creating eternal
memcache entries
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55445
Faidon Liambotis <pa...@debian.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |paravoid@debian.org
--- Comment #1 from Faidon Liambotis <pa...@debian.org> ---
That was me, thanks for forwarding the patch. I'm adding myself to Cc, in case
there are any questions.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 55445] mod_socache_memcache ignores expiry, creating eternal
memcache entries
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55445
--- Comment #3 from Gil Bahat <gi...@magisto.com> ---
someone just needs to commit the thing - I have no idea how things get done
here in the apache project... I just added the patch that someone else already
did for this little bug. FWIW I am also very keen on seeing this fixed myself,
but I sure as hell can't commit it.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org