You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Raphael Kubo da Costa <ra...@FreeBSD.org> on 2012/09/15 22:10:32 UTC
[PATCH v2] Remove NLS check for KWallet support and reorder private includes
Following Daniel's suggestions in previous thread, attached is another
iteration of the patch that removes the need for NLS to be enabled for
KWallet support to be built.
Besides removing the NLS check from kwallet.m4 as the previous patch
did, this one also reorders the includes in kwallet.cpp so that the
private Subversion includes come after the system/KDE ones. The same has
been done to the GNOME Keyring code, as well as another file.
In most of the cases, svn_private_config.h is already one of the last
files to be included, and I felt it was too dangerous to change the
cases where it was included before some feature checks or apr includes.
RE: [PATCH v2] Remove NLS check for KWallet support and reorder private includes
Posted by Gavin Baumanis <ga...@thespidernet.com>.
Hi Daniel / Raphael,
I will create the issue for you.
And reply here in this thread when it is done with the issue number.
-Gavin
> -----Original Message-----
> From: Daniel Shahaf [mailto:d.s@daniel.shahaf.name]
> Sent: Tuesday, 16 October 2012 11:40
> To: Raphael Kubo da Costa
> Cc: dev@subversion.apache.org
> Subject: Re: [PATCH v2] Remove NLS check for KWallet support and reorder
> private includes
>
> Raphael, could you please file an issue in our bug tracker so we don't
forget
> about this patch? Please set the 'patch' keyword and '1.8-consider'
> milestone. Thanks!
>
> Raphael Kubo da Costa wrote on Thu, Oct 11, 2012 at 11:29:46 +0300:
> > "Gavin Baumanis" <ga...@thespidernet.com> writes:
> >
> > > Ping.
> > > This message has received no comments.
> >
> > Ping again? :-)
> >
> > > Gavin.
> > >
> > > -----Original Message-----
> > > From: Raphael Kubo da Costa [mailto:rakuco@FreeBSD.org]
> > > Sent: Saturday, 15 September 2012 16:11
> > > To: dev@subversion.apache.org
> > > Subject: [PATCH v2] Remove NLS check for KWallet support and reorder
> > > private includes
> > >
> > > Following Daniel's suggestions in previous thread, attached is
> > > another iteration of the patch that removes the need for NLS to be
> > > enabled for KWallet support to be built.
> > >
> > > Besides removing the NLS check from kwallet.m4 as the previous patch
> > > did, this one also reorders the includes in kwallet.cpp so that the
> > > private Subversion includes come after the system/KDE ones. The same
> > > has been done to the GNOME Keyring code, as well as another file.
> > >
> > > In most of the cases, svn_private_config.h is already one of the
> > > last files to be included, and I felt it was too dangerous to change
> > > the cases where it was included before some feature checks or apr
> includes.
> >
Re: [PATCH v2] Remove NLS check for KWallet support and reorder
private includes
Posted by Daniel Shahaf <d....@daniel.shahaf.name>.
Raphael, could you please file an issue in our bug tracker so we don't
forget about this patch? Please set the 'patch' keyword and
'1.8-consider' milestone. Thanks!
Raphael Kubo da Costa wrote on Thu, Oct 11, 2012 at 11:29:46 +0300:
> "Gavin Baumanis" <ga...@thespidernet.com> writes:
>
> > Ping.
> > This message has received no comments.
>
> Ping again? :-)
>
> > Gavin.
> >
> > -----Original Message-----
> > From: Raphael Kubo da Costa [mailto:rakuco@FreeBSD.org]
> > Sent: Saturday, 15 September 2012 16:11
> > To: dev@subversion.apache.org
> > Subject: [PATCH v2] Remove NLS check for KWallet support and reorder private
> > includes
> >
> > Following Daniel's suggestions in previous thread, attached is another
> > iteration of the patch that removes the need for NLS to be enabled for
> > KWallet support to be built.
> >
> > Besides removing the NLS check from kwallet.m4 as the previous patch did,
> > this one also reorders the includes in kwallet.cpp so that the private
> > Subversion includes come after the system/KDE ones. The same has been done
> > to the GNOME Keyring code, as well as another file.
> >
> > In most of the cases, svn_private_config.h is already one of the last files
> > to be included, and I felt it was too dangerous to change the cases where it
> > was included before some feature checks or apr includes.
>
Re: [PATCH v2] Remove NLS check for KWallet support and reorder private includes
Posted by Raphael Kubo da Costa <ra...@FreeBSD.org>.
"Gavin Baumanis" <ga...@thespidernet.com> writes:
> Ping.
> This message has received no comments.
Ping again? :-)
> Gavin.
>
> -----Original Message-----
> From: Raphael Kubo da Costa [mailto:rakuco@FreeBSD.org]
> Sent: Saturday, 15 September 2012 16:11
> To: dev@subversion.apache.org
> Subject: [PATCH v2] Remove NLS check for KWallet support and reorder private
> includes
>
> Following Daniel's suggestions in previous thread, attached is another
> iteration of the patch that removes the need for NLS to be enabled for
> KWallet support to be built.
>
> Besides removing the NLS check from kwallet.m4 as the previous patch did,
> this one also reorders the includes in kwallet.cpp so that the private
> Subversion includes come after the system/KDE ones. The same has been done
> to the GNOME Keyring code, as well as another file.
>
> In most of the cases, svn_private_config.h is already one of the last files
> to be included, and I felt it was too dangerous to change the cases where it
> was included before some feature checks or apr includes.
RE: [PATCH v2] Remove NLS check for KWallet support and reorder private includes
Posted by Gavin Baumanis <ga...@thespidernet.com>.
Ping.
This message has received no comments.
Gavin.
-----Original Message-----
From: Raphael Kubo da Costa [mailto:rakuco@FreeBSD.org]
Sent: Saturday, 15 September 2012 16:11
To: dev@subversion.apache.org
Subject: [PATCH v2] Remove NLS check for KWallet support and reorder private
includes
Following Daniel's suggestions in previous thread, attached is another
iteration of the patch that removes the need for NLS to be enabled for
KWallet support to be built.
Besides removing the NLS check from kwallet.m4 as the previous patch did,
this one also reorders the includes in kwallet.cpp so that the private
Subversion includes come after the system/KDE ones. The same has been done
to the GNOME Keyring code, as well as another file.
In most of the cases, svn_private_config.h is already one of the last files
to be included, and I felt it was too dangerous to change the cases where it
was included before some feature checks or apr includes.