You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "gz (via GitHub)" <gi...@apache.org> on 2025/01/10 20:33:26 UTC
[I] External Error prefix is repeated multiple times [datafusion]
gz opened a new issue, #14080:
URL: https://github.com/apache/datafusion/issues/14080
### Describe the bug
I'm getting errors in the form of DataFusionError::External(External(External(External(External(External(xyz)))) when throwing them from https://docs.rs/datafusion/latest/datafusion/physical_plan/trait.ExecutionPlan.html#tymethod.execute
### To Reproduce
Implement a TableProvider that throws an error and call it
```
fn execute(
&self,
partition: usize,
_context: Arc<TaskContext>,
) -> datafusion::common::Result<SendableRecordBatchStream> {
return Err(DataFusionError::Execution(
format!("error"),
));
}
```
### Expected behavior
I'd expect the `External(External(External(External(External` flattened to just one `External`
### Additional context
- This seems to be a regression as it wasn't happening in e.g., 42
- Similar fixes have been done for other parts of the code https://github.com/apache/datafusion/pull/14000
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] External Error prefix is repeated multiple times [datafusion]
Posted by "getChan (via GitHub)" <gi...@apache.org>.
getChan commented on issue #14080:
URL: https://github.com/apache/datafusion/issues/14080#issuecomment-2621943510
Take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] External Error prefix is repeated multiple times [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #14080:
URL: https://github.com/apache/datafusion/issues/14080#issuecomment-2587923724
I agree this would be nice to fix.
We can potentially do the unwrapping in this From impl:
https://github.com/apache/datafusion/blob/63b94c8f9e128b938e81b7e867ce6256a94d67e6/datafusion/common/src/error.rs#L282-L286
But not sure if there are other places too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] External Error prefix is repeated multiple times [datafusion]
Posted by "getChan (via GitHub)" <gi...@apache.org>.
getChan commented on issue #14080:
URL: https://github.com/apache/datafusion/issues/14080#issuecomment-2626411859
@Omega359
Can you provide me with code that can reproduce a bug? I want to use it for testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] External Error prefix is repeated multiple times [datafusion]
Posted by "Omega359 (via GitHub)" <gi...@apache.org>.
Omega359 commented on issue #14080:
URL: https://github.com/apache/datafusion/issues/14080#issuecomment-2622008215
Note that when this is fixed the sqlite test files will need to be regenerated. See https://github.com/apache/datafusion/pull/14290 for a PR to do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] External Error prefix is repeated multiple times [datafusion]
Posted by "Omega359 (via GitHub)" <gi...@apache.org>.
Omega359 commented on issue #14080:
URL: https://github.com/apache/datafusion/issues/14080#issuecomment-2585365078
I was seeing this with the sqlite tests, thx for creating a ticket for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] External Error prefix is repeated multiple times [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #14080:
URL: https://github.com/apache/datafusion/issues/14080#issuecomment-2627015581
> [@Omega359](https://github.com/Omega359) [@gz](https://github.com/gz) Can you provide me with code that can reproduce a bug? I want to use it for testing.
I think the tests @Omega359 is referring to are the ones in
- https://github.com/apache/datafusion/tree/main/datafusion/sqllogictest#running-tests-sqlite
The challenge is updating the expected results
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] External Error prefix is repeated multiple times [datafusion]
Posted by "Omega359 (via GitHub)" <gi...@apache.org>.
Omega359 commented on issue #14080:
URL: https://github.com/apache/datafusion/issues/14080#issuecomment-2627285157
https://github.com/apache/datafusion-testing/blob/5b424aefd7f6bf198220c37f59d39dbb25b47695/data/sqlite/random/groupby/slt_good_12.slt#L19568 is an example.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] External Error prefix is repeated multiple times [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb closed issue #14080: External Error prefix is repeated multiple times
URL: https://github.com/apache/datafusion/issues/14080
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org