You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Mark Hobson <ma...@gmail.com> on 2007/06/15 12:28:54 UTC
Re: svn commit: r547483 - in /maven/plugins/trunk/maven-dependency-plugin: ./ src/test/java/org/apache/maven/plugin/dependency/ src/test/java/org/apache/maven/plugin/dependency/testUtils/ src/test/java/org/apache/maven/plugin/dependency/utils/filters
On 15/06/07, brianf@apache.org <br...@apache.org> wrote:
> Author: brianf
> Date: Thu Jun 14 18:50:14 2007
> New Revision: 547483
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=547483
> Log:
> MDEP-59: updated dependencies to get the new unarchiver for rar. Had to move around the tests to avoid new heap size issues.
>
> Added:
> maven/plugins/trunk/maven-dependency-plugin/src/test/java/org/apache/maven/plugin/dependency/TestUnpackDependenciesMojo2.java
> Modified:
> maven/plugins/trunk/maven-dependency-plugin/pom.xml
> maven/plugins/trunk/maven-dependency-plugin/src/test/java/org/apache/maven/plugin/dependency/TestUnpackDependenciesMojo.java
> maven/plugins/trunk/maven-dependency-plugin/src/test/java/org/apache/maven/plugin/dependency/testUtils/ArtifactStubFactory.java
> maven/plugins/trunk/maven-dependency-plugin/src/test/java/org/apache/maven/plugin/dependency/utils/filters/TestTypeFilter.java
>
> Modified: maven/plugins/trunk/maven-dependency-plugin/pom.xml
> URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-dependency-plugin/pom.xml?view=diff&rev=547483&r1=547482&r2=547483
> ==============================================================================
> --- maven/plugins/trunk/maven-dependency-plugin/pom.xml (original)
> +++ maven/plugins/trunk/maven-dependency-plugin/pom.xml Thu Jun 14 18:50:14 2007
> @@ -138,13 +138,18 @@
> <groupId>org.apache.maven.shared</groupId>
> <artifactId>maven-plugin-testing-harness</artifactId>
> <scope>test</scope>
> - <version>1.0-beta-1</version>
> + <version>1.1-SNAPSHOT</version>
> </dependency>
> <dependency>
> <groupId>org.codehaus.plexus</groupId>
> <artifactId>plexus-archiver</artifactId>
> - <version>1.0-alpha-8</version>
> + <version>1.0-alpha-9-SNAPSHOT</version>
[snip]
Should we not add the codehaus snapshot repo to the poms somewhere? A
fresh checkout doesn't build since it can't find plexus snapshots.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r547483 - in /maven/plugins/trunk/maven-dependency-plugin: ./ src/test/java/org/apache/maven/plugin/dependency/ src/test/java/org/apache/maven/plugin/dependency/testUtils/ src/test/java/org/apache/maven/plugin/dependency/utils/filters
Posted by Jason van Zyl <ja...@maven.org>.
On 15 Jun 07, at 6:42 AM 15 Jun 07, Brett Porter wrote:
>
> On 15/06/2007, at 11:23 PM, Jason van Zyl wrote:
>
>>
>> On 15 Jun 07, at 4:30 AM 15 Jun 07, Kenney Westerhof wrote:
>>
>>> Yup, I did the same change locally to test something.
>>>
>>> Normally we don't want to depend on plexus snapshots since it
>>> imposes a restriction
>>> on the ability to release.
>>>
>>> I think we should add the repo in the pom where we need a plexus
>>> snapshot, and remove it
>>> as soon as the dependency is released. Putting it in a parent or
>>> root pom will
>>> promote use of snapshots.
>>>
>>
>> We should have a set standard settings.xml chunk that we use so
>> that the repositories are not entered into the POM so that when
>> you go to make releases you don't have to diddle the POM. In
>> addition we should have a standard snapshot repository as it is so
>> common to pull in snapshots and just results in lots of busy work
>> add/removing/adding/removing.
>
> This is totally unnecessary. Consistently defining snapshot plugin
> repositories works just fine if you define it to only be used for
> snapshots (like we do in the maven parent). If you have no
> snapshots, it won't be used.
>
I don't think we actually know that. For example if someone else does
define a snapshot dependency and then this one is pulled in
transitively and used. We do not know what affect this has. But the
sheer. I'll go find my notes from the email and post them in the arch
docs because it is a problem.
> The two reasons this perception comes about:
> - adding plugin repositories in this way is dangerous due to the
> unpredictability of versions. We're addressing that differently.
> - there was a bug where getting metadata didn't work unless you
> have releases set to true. I think that also impacted plugin
> repositories.
>
> I'm all for using settings to define plugin repositories when you
> control the environment. But when random people are grabbing our
> project and building it I want mvn install to work out of the box.
>
It will work out of the box, and it has to work out of the box. But
that's not incongruous with no plugin repository definitions (those
should go away anyway, and I think we've decided they are useless),
no snapshot repository definitions necessary. It should work and it
should be easy.
> - Brett
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
Thanks,
Jason
----------------------------------------------------------
Jason van Zyl
Founder and PMC Chair, Apache Maven
jason at sonatype dot com
----------------------------------------------------------
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r547483 - in /maven/plugins/trunk/maven-dependency-plugin: ./ src/test/java/org/apache/maven/plugin/dependency/ src/test/java/org/apache/maven/plugin/dependency/testUtils/ src/test/java/org/apache/maven/plugin/dependency/utils/filters
Posted by Brett Porter <br...@apache.org>.
On 15/06/2007, at 11:23 PM, Jason van Zyl wrote:
>
> On 15 Jun 07, at 4:30 AM 15 Jun 07, Kenney Westerhof wrote:
>
>> Yup, I did the same change locally to test something.
>>
>> Normally we don't want to depend on plexus snapshots since it
>> imposes a restriction
>> on the ability to release.
>>
>> I think we should add the repo in the pom where we need a plexus
>> snapshot, and remove it
>> as soon as the dependency is released. Putting it in a parent or
>> root pom will
>> promote use of snapshots.
>>
>
> We should have a set standard settings.xml chunk that we use so
> that the repositories are not entered into the POM so that when you
> go to make releases you don't have to diddle the POM. In addition
> we should have a standard snapshot repository as it is so common to
> pull in snapshots and just results in lots of busy work add/
> removing/adding/removing.
This is totally unnecessary. Consistently defining snapshot plugin
repositories works just fine if you define it to only be used for
snapshots (like we do in the maven parent). If you have no snapshots,
it won't be used.
The two reasons this perception comes about:
- adding plugin repositories in this way is dangerous due to the
unpredictability of versions. We're addressing that differently.
- there was a bug where getting metadata didn't work unless you have
releases set to true. I think that also impacted plugin repositories.
I'm all for using settings to define plugin repositories when you
control the environment. But when random people are grabbing our
project and building it I want mvn install to work out of the box.
- Brett
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r547483 - in /maven/plugins/trunk/maven-dependency-plugin: ./ src/test/java/org/apache/maven/plugin/dependency/ src/test/java/org/apache/maven/plugin/dependency/testUtils/ src/test/java/org/apache/maven/plugin/dependency/utils/filters
Posted by Jason van Zyl <ja...@maven.org>.
On 15 Jun 07, at 4:30 AM 15 Jun 07, Kenney Westerhof wrote:
> Yup, I did the same change locally to test something.
>
> Normally we don't want to depend on plexus snapshots since it
> imposes a restriction
> on the ability to release.
>
> I think we should add the repo in the pom where we need a plexus
> snapshot, and remove it
> as soon as the dependency is released. Putting it in a parent or
> root pom will
> promote use of snapshots.
>
We should have a set standard settings.xml chunk that we use so that
the repositories are not entered into the POM so that when you go to
make releases you don't have to diddle the POM. In addition we should
have a standard snapshot repository as it is so common to pull in
snapshots and just results in lots of busy work add/removing/adding/
removing.
> my 2 cents,
>
> Kenney
>
> Mark Hobson wrote:
>> On 15/06/07, brianf@apache.org <br...@apache.org> wrote:
>>> Author: brianf
>>> Date: Thu Jun 14 18:50:14 2007
>>> New Revision: 547483
>>>
>>> URL: http://svn.apache.org/viewvc?view=rev&rev=547483
>>> Log:
>>> MDEP-59: updated dependencies to get the new unarchiver for rar.
>>> Had to move around the tests to avoid new heap size issues.
>>>
>>> Added:
>>> maven/plugins/trunk/maven-dependency-plugin/src/test/java/org/
>>> apache/maven/plugin/dependency/TestUnpackDependenciesMojo2.java
>>> Modified:
>>> maven/plugins/trunk/maven-dependency-plugin/pom.xml
>>> maven/plugins/trunk/maven-dependency-plugin/src/test/java/org/
>>> apache/maven/plugin/dependency/TestUnpackDependenciesMojo.java
>>> maven/plugins/trunk/maven-dependency-plugin/src/test/java/org/
>>> apache/maven/plugin/dependency/testUtils/ArtifactStubFactory.java
>>> maven/plugins/trunk/maven-dependency-plugin/src/test/java/org/
>>> apache/maven/plugin/dependency/utils/filters/TestTypeFilter.java
>>>
>>> Modified: maven/plugins/trunk/maven-dependency-plugin/pom.xml
>>> URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-
>>> dependency-plugin/pom.xml?view=diff&rev=547483&r1=547482&r2=547483
>>> ====================================================================
>>> ==========
>>> --- maven/plugins/trunk/maven-dependency-plugin/pom.xml (original)
>>> +++ maven/plugins/trunk/maven-dependency-plugin/pom.xml Thu Jun
>>> 14 18:50:14 2007
>>> @@ -138,13 +138,18 @@
>>> <groupId>org.apache.maven.shared</groupId>
>>> <artifactId>maven-plugin-testing-harness</
>>> artifactId>
>>> <scope>test</scope>
>>> - <version>1.0-beta-1</version>
>>> + <version>1.1-SNAPSHOT</version>
>>> </dependency>
>>> <dependency>
>>> <groupId>org.codehaus.plexus</groupId>
>>> <artifactId>plexus-archiver</artifactId>
>>> - <version>1.0-alpha-8</version>
>>> + <version>1.0-alpha-9-SNAPSHOT</version>
>> [snip]
>> Should we not add the codehaus snapshot repo to the poms
>> somewhere? A
>> fresh checkout doesn't build since it can't find plexus snapshots.
>> Mark
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
Thanks,
Jason
----------------------------------------------------------
Jason van Zyl
Founder and PMC Chair, Apache Maven
jason at sonatype dot com
----------------------------------------------------------
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r547483 - in /maven/plugins/trunk/maven-dependency-plugin: ./ src/test/java/org/apache/maven/plugin/dependency/ src/test/java/org/apache/maven/plugin/dependency/testUtils/ src/test/java/org/apache/maven/plugin/dependency/utils/filters
Posted by Mark Hobson <ma...@gmail.com>.
On 15/06/07, Brian E. Fox <br...@reply.infinity.nu> wrote:
> Yes, we should add it temporarily. I normally wouldn't use a snapshot but the new archiver has a feature needed by mdep and they asked me to test it before they do a release. It should be very short term.
Okay, cool.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
RE: svn commit: r547483 - in /maven/plugins/trunk/maven-dependency-plugin: ./ src/test/java/org/apache/maven/plugin/dependency/ src/test/java/org/apache/maven/plugin/dependency/testUtils/ src/test/java/org/apache/maven/plugin/dependency/utils/filters
Posted by "Brian E. Fox" <br...@reply.infinity.nu>.
Yes, we should add it temporarily. I normally wouldn't use a snapshot but the new archiver has a feature needed by mdep and they asked me to test it before they do a release. It should be very short term.
-----Original Message-----
From: Kenney Westerhof [mailto:kenney@apache.org]
Sent: Friday, June 15, 2007 7:30 AM
To: Maven Developers List
Subject: Re: svn commit: r547483 - in /maven/plugins/trunk/maven-dependency-plugin: ./ src/test/java/org/apache/maven/plugin/dependency/ src/test/java/org/apache/maven/plugin/dependency/testUtils/ src/test/java/org/apache/maven/plugin/dependency/utils/filters
Yup, I did the same change locally to test something.
Normally we don't want to depend on plexus snapshots since it imposes a restriction
on the ability to release.
I think we should add the repo in the pom where we need a plexus snapshot, and remove it
as soon as the dependency is released. Putting it in a parent or root pom will
promote use of snapshots.
my 2 cents,
Kenney
Mark Hobson wrote:
> On 15/06/07, brianf@apache.org <br...@apache.org> wrote:
>> Author: brianf
>> Date: Thu Jun 14 18:50:14 2007
>> New Revision: 547483
>>
>> URL: http://svn.apache.org/viewvc?view=rev&rev=547483
>> Log:
>> MDEP-59: updated dependencies to get the new unarchiver for rar. Had
>> to move around the tests to avoid new heap size issues.
>>
>> Added:
>>
>> maven/plugins/trunk/maven-dependency-plugin/src/test/java/org/apache/maven/plugin/dependency/TestUnpackDependenciesMojo2.java
>>
>> Modified:
>> maven/plugins/trunk/maven-dependency-plugin/pom.xml
>>
>> maven/plugins/trunk/maven-dependency-plugin/src/test/java/org/apache/maven/plugin/dependency/TestUnpackDependenciesMojo.java
>>
>>
>> maven/plugins/trunk/maven-dependency-plugin/src/test/java/org/apache/maven/plugin/dependency/testUtils/ArtifactStubFactory.java
>>
>>
>> maven/plugins/trunk/maven-dependency-plugin/src/test/java/org/apache/maven/plugin/dependency/utils/filters/TestTypeFilter.java
>>
>>
>> Modified: maven/plugins/trunk/maven-dependency-plugin/pom.xml
>> URL:
>> http://svn.apache.org/viewvc/maven/plugins/trunk/maven-dependency-plugin/pom.xml?view=diff&rev=547483&r1=547482&r2=547483
>>
>> ==============================================================================
>>
>> --- maven/plugins/trunk/maven-dependency-plugin/pom.xml (original)
>> +++ maven/plugins/trunk/maven-dependency-plugin/pom.xml Thu Jun 14
>> 18:50:14 2007
>> @@ -138,13 +138,18 @@
>> <groupId>org.apache.maven.shared</groupId>
>>
>> <artifactId>maven-plugin-testing-harness</artifactId>
>> <scope>test</scope>
>> - <version>1.0-beta-1</version>
>> + <version>1.1-SNAPSHOT</version>
>> </dependency>
>> <dependency>
>> <groupId>org.codehaus.plexus</groupId>
>> <artifactId>plexus-archiver</artifactId>
>> - <version>1.0-alpha-8</version>
>> + <version>1.0-alpha-9-SNAPSHOT</version>
> [snip]
>
> Should we not add the codehaus snapshot repo to the poms somewhere? A
> fresh checkout doesn't build since it can't find plexus snapshots.
>
> Mark
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r547483 - in /maven/plugins/trunk/maven-dependency-plugin:
./ src/test/java/org/apache/maven/plugin/dependency/ src/test/java/org/apache/maven/plugin/dependency/testUtils/
src/test/java/org/apache/maven/plugin/dependency/utils/filters
Posted by Kenney Westerhof <ke...@apache.org>.
Yup, I did the same change locally to test something.
Normally we don't want to depend on plexus snapshots since it imposes a restriction
on the ability to release.
I think we should add the repo in the pom where we need a plexus snapshot, and remove it
as soon as the dependency is released. Putting it in a parent or root pom will
promote use of snapshots.
my 2 cents,
Kenney
Mark Hobson wrote:
> On 15/06/07, brianf@apache.org <br...@apache.org> wrote:
>> Author: brianf
>> Date: Thu Jun 14 18:50:14 2007
>> New Revision: 547483
>>
>> URL: http://svn.apache.org/viewvc?view=rev&rev=547483
>> Log:
>> MDEP-59: updated dependencies to get the new unarchiver for rar. Had
>> to move around the tests to avoid new heap size issues.
>>
>> Added:
>>
>> maven/plugins/trunk/maven-dependency-plugin/src/test/java/org/apache/maven/plugin/dependency/TestUnpackDependenciesMojo2.java
>>
>> Modified:
>> maven/plugins/trunk/maven-dependency-plugin/pom.xml
>>
>> maven/plugins/trunk/maven-dependency-plugin/src/test/java/org/apache/maven/plugin/dependency/TestUnpackDependenciesMojo.java
>>
>>
>> maven/plugins/trunk/maven-dependency-plugin/src/test/java/org/apache/maven/plugin/dependency/testUtils/ArtifactStubFactory.java
>>
>>
>> maven/plugins/trunk/maven-dependency-plugin/src/test/java/org/apache/maven/plugin/dependency/utils/filters/TestTypeFilter.java
>>
>>
>> Modified: maven/plugins/trunk/maven-dependency-plugin/pom.xml
>> URL:
>> http://svn.apache.org/viewvc/maven/plugins/trunk/maven-dependency-plugin/pom.xml?view=diff&rev=547483&r1=547482&r2=547483
>>
>> ==============================================================================
>>
>> --- maven/plugins/trunk/maven-dependency-plugin/pom.xml (original)
>> +++ maven/plugins/trunk/maven-dependency-plugin/pom.xml Thu Jun 14
>> 18:50:14 2007
>> @@ -138,13 +138,18 @@
>> <groupId>org.apache.maven.shared</groupId>
>>
>> <artifactId>maven-plugin-testing-harness</artifactId>
>> <scope>test</scope>
>> - <version>1.0-beta-1</version>
>> + <version>1.1-SNAPSHOT</version>
>> </dependency>
>> <dependency>
>> <groupId>org.codehaus.plexus</groupId>
>> <artifactId>plexus-archiver</artifactId>
>> - <version>1.0-alpha-8</version>
>> + <version>1.0-alpha-9-SNAPSHOT</version>
> [snip]
>
> Should we not add the codehaus snapshot repo to the poms somewhere? A
> fresh checkout doesn't build since it can't find plexus snapshots.
>
> Mark
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org