[GitHub] [phoenix] gjacoby126 commented on a change in pull request #1060: PHOENIX-6298 : Use timestamp of PENDING_DISABLE_COUNT to calculate elapse time for PENDING_DISABLE state

[GitBox <gi...@apache.org>]

gjacoby126 commented on a change in pull request #1060:
URL: https://github.com/apache/phoenix/pull/1060#discussion_r552224371



##########
File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/index/PartialIndexRebuilderIT.java
##########
@@ -1060,4 +1063,70 @@ public void postBatchMutate(ObserverContext<RegionCoprocessorEnvironment> c, Min
             throw new DoNotRetryIOException("Simulating write failure on " + c.getEnvironment().getRegionInfo().getTable().getNameAsString());
         }
     }
+
+    @Test
+    public void testPendingDisableWithDisableCountTs() throws Throwable {
+        final String schemaName = generateUniqueName();
+        final String tableName = generateUniqueName();
+        final String indexName = generateUniqueName();
+        final String fullTableName = SchemaUtil.getTableName(schemaName, tableName);
+        final String fullIndexName = SchemaUtil.getTableName(schemaName, indexName);
+        final MyClock clock = new MyClock(1000);
+        EnvironmentEdgeManager.injectEdge(clock);

Review comment:
       We've seen problems in the past with HBase 2.x and injecting an Environment Edge before creating a table. (It can hang forever) Probably want to move the edge injection until after the create table / create index statement unless you know the HBase 2.x edge bug has been fixed. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org