You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/08/10 12:07:59 UTC

[GitHub] [kafka] daehokimm commented on a diff in pull request #11442: KAFKA-7883 add schema.namespace support to SetSchemaMetadata SMT in Kafka Connect

daehokimm commented on code in PR #11442:
URL: https://github.com/apache/kafka/pull/11442#discussion_r942369982


##########
connect/transforms/src/main/java/org/apache/kafka/connect/transforms/SetSchemaMetadata.java:
##########
@@ -71,7 +78,7 @@ public R apply(R record) {
                 schema.type(),
                 schema.isOptional(),
                 schema.defaultValue(),
-                schemaName != null ? schemaName : schema.name(),
+                buildSchemaName(schemaNamespace, schemaName != null ? schemaName : schema.name()),

Review Comment:
   I agree to @pjmagee 's opinion. 
   
   if I want to replace just namespace of multiple schemas, this is not suitable to configure.
   this transform is not consider to this situation?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org