You are viewing a plain text version of this content. The canonical link for it is here.
Posted to fop-dev@xmlgraphics.apache.org by bu...@apache.org on 2006/10/02 17:37:39 UTC
DO NOT REPLY [Bug 40655] New: - [PATCH] Failure in PNGRenderer when output file name is missing an extension
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=40655>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=40655
Summary: [PATCH] Failure in PNGRenderer when output file name is
missing an extension
Product: Fop
Version: 1.0dev
Platform: All
OS/Version: All
Status: NEW
Severity: normal
Priority: P2
Component: general
AssignedTo: fop-dev@xmlgraphics.apache.org
ReportedBy: mjh@cs.rit.edu
Overview Description:
If the user has set an output file on a user agent, but the file doesn't include
an extension, a StringIndexOutOfBoundsException is thrown when the PNGRenderer
attempts to deduce the "file prefix" to be used for the various pages, causing
the rendering attempt to fail unexpectedly.
The attached patch will allow a file name missing an extension to be used in its
entirety as the prefix for pages being rendered.
Steps to Reproduce:
1) Create a FOPFactory object.
FopFactory fopFactory = FopFactory.newInstance();
2) Create an FOUserAgent object.
org.apache.fop.apps.FOUserAgent agent = fopFactory.newFOUserAgent();
3) Set the "output file" for the agent, making sure that the file name does not
include an extension.
agent.setOutputFile( new java.io.File( "/var/tmp/ProjectSummaryReport" ) );
4) Create a Fop object, using the configured agent, and targeting PNG as the
output format.
Fop fop = fopFactory.newFop( org.apache.fop.apps.MimeConstants.MIME_PNG, out );
5) Use the Fop object to try to render an FO document.
Actual Results:
A StringIndexOutOfBoundsException is thrown when the PNGRenderer attempts to
deduce the "file prefix" to be used for the various pages, causing the rendering
attempt to fail unexpectedly.
Expected Results:
Either the renderer should accept the file name (e.g., "ProjectSummaryReport")
as the full prefix, or else it should throw an exception (probably IOException,
given the context) to indicate that an inappropriate output file has been
specified.
Build Date & Platform:
Subversion repository version 451762, on Mac OS X 10.4.7. (29Sep06)
Additional Builds and Platforms:
Issue also occurs under Solaris and Windows, and should presumably arise
anywhere this is attempted.
Additional information:
This isn't likely to be an issue under many circumstances, since users will
frequently specify the file name using an extension (e.g.,
"/Volumes/Stuff/ProjectReport.png"), but if the user is accustomed to working on
an OS that doesn't place as high a premium on file extensions (e.g., OS X) and
is using an existing file as the basis for the output being generated by the
renderer, this problem could come up.
During discussion on the mailing list, Andreas Delmelle suggested that the
renderer should probably not accept alternate extensions (i.e., other than
".png"). This changes is also included in the attached patch.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
DO NOT REPLY [Bug 40655] - [PATCH] Failure in PNGRenderer when output file name is missing an extension
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=40655>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=40655
------- Additional Comments From mjh@cs.rit.edu 2006-10-02 08:38 -------
Created an attachment (id=18951)
--> (http://issues.apache.org/bugzilla/attachment.cgi?id=18951&action=view)
Patch for PNGRenderer, adding handling of files without extensions
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
DO NOT REPLY [Bug 40655] - [PATCH] Failure in PNGRenderer when output file name is missing an extension
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=40655>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=40655
spepping@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
------- Additional Comments From spepping@apache.org 2006-10-09 03:34 -------
Patch applied in revision 454331. Thanks.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.