[GitHub] [maven-javadoc-plugin] hazendaz commented on a diff in pull request #164: MJAVADOC-731 update parent, get rid of legacy

[GitBox <gi...@apache.org>]

hazendaz commented on code in PR #164:
URL: https://github.com/apache/maven-javadoc-plugin/pull/164#discussion_r989703123


##########
pom.xml:
##########
@@ -171,38 +171,42 @@ under the License.
       <groupId>org.apache.maven</groupId>
       <artifactId>maven-core</artifactId>
       <version>${mavenVersion}</version>
+      <scope>provided</scope>
     </dependency>
     <dependency>
       <groupId>org.apache.maven</groupId>
       <artifactId>maven-model</artifactId>
       <version>${mavenVersion}</version>
+      <scope>provided</scope>
     </dependency>
     <dependency>
       <groupId>org.apache.maven</groupId>
       <artifactId>maven-settings</artifactId>
       <version>${mavenVersion}</version>
+      <scope>provided</scope>
     </dependency>
     <dependency>
       <groupId>org.apache.maven</groupId>
       <artifactId>maven-plugin-api</artifactId>
       <version>${mavenVersion}</version>
+      <scope>provided</scope>
     </dependency>
     <dependency>
       <groupId>org.apache.maven</groupId>
       <artifactId>maven-artifact</artifactId>
       <version>${mavenVersion}</version>
+      <scope>provided</scope>
     </dependency>
     <dependency>
       <groupId>org.apache.maven.plugin-tools</groupId>
       <artifactId>maven-plugin-annotations</artifactId>
       <scope>provided</scope>
     </dependency>
     <dependency>
-      <groupId>org.codehaus.plexus</groupId>
-      <artifactId>plexus-component-annotations</artifactId>
-      <scope>provided</scope>
+      <groupId>javax.inject</groupId>
+      <artifactId>javax.inject</artifactId>
+      <version>1</version>

Review Comment:
   @kwin It did get other versions, the GAV changed...
   
   Latest in 1.x is
   
   ```
   <dependency>
     <groupId>jakarta.inject</groupId>
     <artifactId>jakarta.inject-api</artifactId>
     <version>1.0.5</version>
   </dependency>
   ```
   
   The original has problems with fact it has no meta data.  I forget specific issue that caused in the past.  Would be better to use the officially supported one though regardless.  Note this is still javax internals.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org