You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/04/15 06:36:51 UTC
[GitHub] [incubator-shardingsphere] tuohai666 opened a new pull request #5194: #3556, affect rows is always zero when using sharding-proxy postgresq…
tuohai666 opened a new pull request #5194: #3556, affect rows is always zero when using sharding-proxy postgresq…
URL: https://github.com/apache/incubator-shardingsphere/pull/5194
…l mode
Fixes #3556.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #5194: #3556, affect rows is always zero when using sharding-proxy postgresq…
Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #5194: #3556, affect rows is always zero when using sharding-proxy postgresq…
URL: https://github.com/apache/incubator-shardingsphere/pull/5194
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #5194: #3556, affect rows is always zero when using sharding-proxy postgresq…
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #5194: #3556, affect rows is always zero when using sharding-proxy postgresq…
URL: https://github.com/apache/incubator-shardingsphere/pull/5194#issuecomment-613881325
## Pull Request Test Coverage Report for [Build 11066](https://coveralls.io/builds/30085721)
* **0** of **19** **(0.0%)** changed or added relevant lines in **2** files are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage decreased (**-0.03%**) to **57.524%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [shardingsphere-database-protocol/shardingsphere-database-protocol-postgresql/src/main/java/org/apache/shardingsphere/database/protocol/postgresql/packet/generic/PostgreSQLCommandCompletePacket.java](https://coveralls.io/builds/30085721/source?filename=shardingsphere-database-protocol%2Fshardingsphere-database-protocol-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fdatabase%2Fprotocol%2Fpostgresql%2Fpacket%2Fgeneric%2FPostgreSQLCommandCompletePacket.java#L37) | 0 | 9 | 0.0%
| [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/communication/jdbc/execute/JDBCExecuteEngine.java](https://coveralls.io/builds/30085721/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fcommunication%2Fjdbc%2Fexecute%2FJDBCExecuteEngine.java#L80) | 0 | 10 | 0.0%
<!-- | **Total:** | **0** | **19** | **0.0%** | -->
| Totals | [](https://coveralls.io/builds/30085721) |
| :-- | --: |
| Change from base [Build 11064](https://coveralls.io/builds/30084156): | -0.03% |
| Covered Lines: | 11839 |
| Relevant Lines: | 20581 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] codecov-io commented on issue #5194: #3556, affect rows is always zero when using sharding-proxy postgresq…
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #5194: #3556, affect rows is always zero when using sharding-proxy postgresq…
URL: https://github.com/apache/incubator-shardingsphere/pull/5194#issuecomment-613879939
# [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5194?src=pr&el=h1) Report
> Merging [#5194](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5194?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/e985dba453776305640158ad7139127912f0e34b&el=desc) will **decrease** coverage by `0.08%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5194 +/- ##
============================================
- Coverage 54.18% 54.09% -0.09%
Complexity 406 406
============================================
Files 1158 1158
Lines 20555 20581 +26
Branches 3705 3705
============================================
- Hits 11137 11134 -3
- Misses 8727 8755 +28
- Partials 691 692 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../communication/jdbc/execute/JDBCExecuteEngine.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5194/diff?src=pr&el=tree#diff-c2hhcmRpbmctcHJveHkvc2hhcmRpbmctcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmdwcm94eS9iYWNrZW5kL2NvbW11bmljYXRpb24vamRiYy9leGVjdXRlL0pEQkNFeGVjdXRlRW5naW5lLmphdmE=) | `22.22% <0.00%> (-9.36%)` | `0.00 <0.00> (ø)` | |
| [...gproxy/backend/response/update/UpdateResponse.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5194/diff?src=pr&el=tree#diff-c2hhcmRpbmctcHJveHkvc2hhcmRpbmctcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmdwcm94eS9iYWNrZW5kL3Jlc3BvbnNlL3VwZGF0ZS9VcGRhdGVSZXNwb25zZS5qYXZh) | `40.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...d/query/binary/bind/PostgreSQLComBindExecutor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5194/diff?src=pr&el=tree#diff-c2hhcmRpbmctcHJveHkvc2hhcmRpbmctcHJveHktZnJvbnRlbmQvc2hhcmRpbmctcHJveHktZnJvbnRlbmQtcG9zdGdyZXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmdwcm94eS9mcm9udGVuZC9wb3N0Z3Jlc3FsL2NvbW1hbmQvcXVlcnkvYmluYXJ5L2JpbmQvUG9zdGdyZVNRTENvbUJpbmRFeGVjdXRvci5qYXZh) | `25.58% <ø> (-2.33%)` | `0.00 <0.00> (-1.00)` | |
| [...command/query/text/PostgreSQLComQueryExecutor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5194/diff?src=pr&el=tree#diff-c2hhcmRpbmctcHJveHkvc2hhcmRpbmctcHJveHktZnJvbnRlbmQvc2hhcmRpbmctcHJveHktZnJvbnRlbmQtcG9zdGdyZXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmdwcm94eS9mcm9udGVuZC9wb3N0Z3Jlc3FsL2NvbW1hbmQvcXVlcnkvdGV4dC9Qb3N0Z3JlU1FMQ29tUXVlcnlFeGVjdXRvci5qYXZh) | `22.58% <ø> (-3.23%)` | `0.00 <0.00> (-1.00)` | |
| [...acket/generic/PostgreSQLCommandCompletePacket.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5194/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZGF0YWJhc2UtcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGF0YWJhc2UtcHJvdG9jb2wtcG9zdGdyZXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGF0YWJhc2UvcHJvdG9jb2wvcG9zdGdyZXNxbC9wYWNrZXQvZ2VuZXJpYy9Qb3N0Z3JlU1FMQ29tbWFuZENvbXBsZXRlUGFja2V0LmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...e/factorybean/KeyGenerateAlgorithmFactoryBean.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5194/diff?src=pr&el=tree#diff-c2hhcmRpbmctc3ByaW5nL3NoYXJkaW5nLWpkYmMtc3ByaW5nL3NoYXJkaW5nLWpkYmMtc3ByaW5nLW5hbWVzcGFjZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmdqZGJjL3NwcmluZy9uYW1lc3BhY2UvZmFjdG9yeWJlYW4vS2V5R2VuZXJhdGVBbGdvcml0aG1GYWN0b3J5QmVhbi5qYXZh) | `90.90% <0.00%> (-9.10%)` | `1.00% <0.00%> (ø%)` | |
| [...phere/shardingjdbc/executor/StatementExecutor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5194/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9leGVjdXRvci9TdGF0ZW1lbnRFeGVjdXRvci5qYXZh) | `80.85% <0.00%> (-6.11%)` | `0.00% <0.00%> (ø%)` | |
| [...ardingjdbc/executor/PreparedStatementExecutor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5194/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9leGVjdXRvci9QcmVwYXJlZFN0YXRlbWVudEV4ZWN1dG9yLmphdmE=) | `76.19% <0.00%> (-3.18%)` | `0.00% <0.00%> (ø%)` | |
| ... and [17 more](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5194?src=pr&el=footer). Last update [e985dba...9c47764](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services