You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "Mikhail Petrov (Jira)" <ji...@apache.org> on 2022/04/14 14:09:00 UTC

[jira] [Updated] (IGNITE-16852) Ignite compatibility framework can exclude unnecessary jars from test java process classpath

     [ https://issues.apache.org/jira/browse/IGNITE-16852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mikhail Petrov updated IGNITE-16852:
------------------------------------
    Description: 
Ignite compatibility framework can exclude unnecessary jars from test java process classpath. 

Compatibility framework excludes from calsspath classes which versions were explicitly specified. See IgniteCompatibilityAbstractTest#getProcessProxyJvmArgs.

The exclusion mechanism is based on the specified dependency names
See IgniteCompatibilityAbstractTest#getExcluded
Dependency#sourcePathTemplate
Dependency#artifactPathTemplate

Since we use the following condition to filter dependency from classpath
{code:java}
  if (excluded.stream().noneMatch(path::contains))
{code}

Assume that we have two dependencies with names 
`spring` and `spring-data-commons`. `spring` dependency version is specified explicitly and must be excluded. But since we check if dependency jar path CONTAINS Dependency#artifactPathTemplate result both `spring` and `spring-data-commons` jars is excluded from classpath.

It can be fixed by attaching '/' to Dependency#artifactPathTemplate result. 



  was:
Ignite compatibility framework can exclude unnecessary jars from test java process classpath. 

Compatibility framework excludes from calsspath classes which versions were explicitly specified. See IgniteCompatibilityAbstractTest#getProcessProxyJvmArgs.

The exclusion mechanism is based on the specified dependency names
See IgniteCompatibilityAbstractTest#getExcluded
Dependency#sourcePathTemplate
Dependency#artifactPathTemplate

Since we use the following condition to filter dependency from classpath
{code:java}
  if (excluded.stream().noneMatch(path::contains))
{code}

It possible that if we have two dependencies with names 
spring and spring-data-commons. Spring dependency version is specified explicitly and must be excluded. But since we check if dependency jar path CONTAINS Dependency#artifactPathTemplate result both spring and spring-data-commons jars is excluded from classpath.

It can be fixed by attaching '/' to Dependency#artifactPathTemplate result. 




> Ignite compatibility framework can exclude unnecessary jars from test java process classpath
> --------------------------------------------------------------------------------------------
>
>                 Key: IGNITE-16852
>                 URL: https://issues.apache.org/jira/browse/IGNITE-16852
>             Project: Ignite
>          Issue Type: Bug
>            Reporter: Mikhail Petrov
>            Priority: Major
>
> Ignite compatibility framework can exclude unnecessary jars from test java process classpath. 
> Compatibility framework excludes from calsspath classes which versions were explicitly specified. See IgniteCompatibilityAbstractTest#getProcessProxyJvmArgs.
> The exclusion mechanism is based on the specified dependency names
> See IgniteCompatibilityAbstractTest#getExcluded
> Dependency#sourcePathTemplate
> Dependency#artifactPathTemplate
> Since we use the following condition to filter dependency from classpath
> {code:java}
>   if (excluded.stream().noneMatch(path::contains))
> {code}
> Assume that we have two dependencies with names 
> `spring` and `spring-data-commons`. `spring` dependency version is specified explicitly and must be excluded. But since we check if dependency jar path CONTAINS Dependency#artifactPathTemplate result both `spring` and `spring-data-commons` jars is excluded from classpath.
> It can be fixed by attaching '/' to Dependency#artifactPathTemplate result. 



--
This message was sent by Atlassian Jira
(v8.20.1#820001)