[jira] [Commented] (COUCHDB-2830) os daemons eunit test setup crashes

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/COUCHDB-2830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14936155#comment-14936155 ] 

ASF GitHub Bot commented on COUCHDB-2830:
-----------------------------------------

GitHub user nickva opened a pull request:

    https://github.com/apache/couchdb-couch/pull/108

    Fix couchdb_os_daemons tests dependency.

    couchdb_os_daemons_tests.erl was failing in
    setup if run on its own:
    
    ```
    ... apps=couch tests=os_daemons_test_
    ```
    
    with an exception:
    
    ```
    **exit:{{{badmatch,undefined},
      [{couch_log,notice,2,[{file,"src/couch_log.erl"},{line,44}]},
       {config,handle_call,3,[{file,"src/config.erl"},{line,211}]},
    ```
    
    because it depends on couch_log. So add couch_log as a dependency
    in setup.
    
    After fix it should run 5 tests:
    
    ```
    [done in 5.626 s]
    =======================================================
      Failed: 0.  Skipped: 0.  Passed: 5.
    ```
    
    COUCHDB-2830

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/nickva/couchdb-couch 2830-os-daemons-test-deps

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/couchdb-couch/pull/108.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #108
    
----
commit 2ee5e28d0208188a9f99b513793b31a0e28f8139
Author: Nick Vatamaniuc <va...@gmail.com>
Date:   2015-09-30T00:06:09Z

    Fix couchdb_os_daemons tests dependency.
    
    couchdb_os_daemons_tests.erl was failing in
    setup if run on its own:
    
    ```
    ... apps=couch tests=os_daemons_test_
    ```
    
    with an exception:
    
    ```
    **exit:{{{badmatch,undefined},
      [{couch_log,notice,2,[{file,"src/couch_log.erl"},{line,44}]},
       {config,handle_call,3,[{file,"src/config.erl"},{line,211}]},
    ```
    
    because it depends on couch_log. So add couch_log as a dependency
    in setup.
    
    COUCHDB-2830

----


> os daemons eunit test setup crashes
> -----------------------------------
>
>                 Key: COUCHDB-2830
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-2830
>             Project: CouchDB
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: Database Core
>            Reporter: Nick Vatamaniuc
>
> This is the exception I see from the setup code:
> {code}
> undefined
>   *** context setup failed ***
> **in function gen_server:call/2 (gen_server.erl, line 182)
> in call from couchdb_os_daemons_tests:setup/1 (test/couchdb_os_daemons_tests.erl, line 43)
> **exit:{{{badmatch,undefined},
>   [{couch_log,notice,2,[{file,"src/couch_log.erl"},{line,44}]},
>    {config,handle_call,3,[{file,"src/config.erl"},{line,211}]},
>    {gen_server,try_handle_call,4,[{file,"gen_server.erl"},{line,607}]},
>    {gen_server,handle_msg,5,[{file,"gen_server.erl"},{line,639}]},
>    {proc_lib,init_p_do_apply,3,[{file,"proc_lib.erl"},{line,237}]}]},
>  {gen_server,call,
>              [config,
>               {set,"os_daemons","os_daemon_looper.escript",
>                    "/Users/<username>/asf/couchdb/src/couch/test/fixtures/os_daemon_looper.escript",
>                    false,nil}]}}
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)