You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by "jvz (via GitHub)" <gi...@apache.org> on 2025/07/30 21:27:49 UTC
[PR] Support `FailoverAppender::requiresLocation` [logging-log4j2]
jvz opened a new pull request, #3861:
URL: https://github.com/apache/logging-log4j2/pull/3861
This is a port of https://github.com/apache/logging-log4j2/pull/3259 to the 3.x line. This addresses #3257.
A direct cherry-pick was insufficient here due to how the `LocationAware` interface and related extensions were combined into their relevant interfaces and classes in the great flattening of interfaces in 3.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support `FailoverAppender::requiresLocation` [logging-log4j2]
Posted by "jvz (via GitHub)" <gi...@apache.org>.
jvz commented on code in PR #3861:
URL: https://github.com/apache/logging-log4j2/pull/3861#discussion_r2246057435
##########
src/changelog/.3.x.x/3257_fix_FailoverAppender_requiresLocation.xml:
##########
Review Comment:
Do we need any sort of tracking of ported bug fixes from 2.x to 3.x? I'm ok with removing the file, though; just wanted to make sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support `FailoverAppender::requiresLocation` [logging-log4j2]
Posted by "jvz (via GitHub)" <gi...@apache.org>.
jvz merged PR #3861:
URL: https://github.com/apache/logging-log4j2/pull/3861
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support `FailoverAppender::requiresLocation` [logging-log4j2]
Posted by "vy (via GitHub)" <gi...@apache.org>.
vy commented on code in PR #3861:
URL: https://github.com/apache/logging-log4j2/pull/3861#discussion_r2244441321
##########
src/changelog/.3.x.x/3257_fix_FailoverAppender_requiresLocation.xml:
##########
Review Comment:
This changelog entry is not needed, please remove.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support `FailoverAppender::requiresLocation` [logging-log4j2]
Posted by "ppkarwasz (via GitHub)" <gi...@apache.org>.
ppkarwasz commented on code in PR #3861:
URL: https://github.com/apache/logging-log4j2/pull/3861#discussion_r2247191848
##########
src/changelog/.3.x.x/3257_fix_FailoverAppender_requiresLocation.xml:
##########
Review Comment:
We will certainly need to track ported issues, when `3.0.0` is out. In the beta phase I agree with Volkan: users should assume that the latest beta contains the changes from the latest `2.x` release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org