You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "harshithasudhakar (via GitHub)" <gi...@apache.org> on 2023/05/07 18:36:41 UTC
[GitHub] [eventmesh] harshithasudhakar opened a new pull request, #3884: [ISSUE #3472]Do some code optimization[HttpProtocolAdaptor]
harshithasudhakar opened a new pull request, #3884:
URL: https://github.com/apache/eventmesh/pull/3884
Fixes #3472
### Modifications
Imported `java.util.Objects`
Used `Objects.requireNonNull()` at line 95
### Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [eventmesh] codecov[bot] commented on pull request #3884: [ISSUE #3472]Do some code optimization[HttpProtocolAdaptor]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3884:
URL: https://github.com/apache/eventmesh/pull/3884#issuecomment-1539603577
## [Codecov](https://app.codecov.io/gh/apache/eventmesh/pull/3884?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3884](https://app.codecov.io/gh/apache/eventmesh/pull/3884?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a9a03b4) into [master](https://app.codecov.io/gh/apache/eventmesh/commit/e1e9acab09291b2eb10f1a88ee28dd0103bf26a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e1e9aca) will **decrease** coverage by `0.01%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head a9a03b4 differs from pull request most recent head 107ee20. Consider uploading reports for the commit 107ee20 to get more accurate results
```diff
@@ Coverage Diff @@
## master #3884 +/- ##
============================================
- Coverage 13.93% 13.92% -0.01%
- Complexity 1291 1292 +1
============================================
Files 570 570
Lines 28847 28840 -7
Branches 2811 2799 -12
============================================
- Hits 4019 4017 -2
+ Misses 24455 24452 -3
+ Partials 373 371 -2
```
| [Impacted Files](https://app.codecov.io/gh/apache/eventmesh/pull/3884?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...col/http/resolver/HttpRequestProtocolResolver.java](https://app.codecov.io/gh/apache/eventmesh/pull/3884?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXByb3RvY29sLXBsdWdpbi9ldmVudG1lc2gtcHJvdG9jb2wtaHR0cC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL3Byb3RvY29sL2h0dHAvcmVzb2x2ZXIvSHR0cFJlcXVlc3RQcm90b2NvbFJlc29sdmVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
... and [8 files with indirect coverage changes](https://app.codecov.io/gh/apache/eventmesh/pull/3884/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] Alonexc commented on a diff in pull request #3884: [ISSUE #3472]Do some code optimization[HttpProtocolAdaptor]
Posted by "Alonexc (via GitHub)" <gi...@apache.org>.
Alonexc commented on code in PR #3884:
URL: https://github.com/apache/eventmesh/pull/3884#discussion_r1186959305
##########
eventmesh-protocol-plugin/eventmesh-protocol-http/src/main/java/org/apache/eventmesh/protocol/http/resolver/HttpRequestProtocolResolver.java:
##########
@@ -31,6 +31,7 @@
import java.util.Locale;
import java.util.Map;
import java.util.UUID;
+import java.util.Objects;
Review Comment:
This import should be placed here:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] mroccyen merged pull request #3884: [ISSUE #3472]Do some code optimization[HttpProtocolAdaptor]
Posted by "mroccyen (via GitHub)" <gi...@apache.org>.
mroccyen merged PR #3884:
URL: https://github.com/apache/eventmesh/pull/3884
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org