You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "hyz1994121 (via GitHub)" <gi...@apache.org> on 2023/03/08 03:38:44 UTC
[GitHub] [shardingsphere] hyz1994121 opened a new issue, #24498: FOR shardingsphere5.3 dynamic config suggestion
hyz1994121 opened a new issue, #24498:
URL: https://github.com/apache/shardingsphere/issues/24498
In my project i try upgrade shardingsphere from 5.1.1 to 5.3
i use shardingshpere jdbc by spring-namespace
after read this, https://community.sphere-ex.com/t/topic/1284
## Feature Request
**For English only**, other languages will not be accepted.
Please pay attention on issues you submitted, because we maybe need more details.
If no response anymore and we cannot make decision by current information, we will **close it**.
Please answer these questions before submitting your issue. Thanks!
### Is your feature request related to a problem?
### Describe the feature you would like.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] liming0 commented on issue #24498: FOR shardingsphere5.3 dynamic config suggestion
Posted by "liming0 (via GitHub)" <gi...@apache.org>.
liming0 commented on issue #24498:
URL: https://github.com/apache/shardingsphere/issues/24498#issuecomment-1534001108
> Hi @liming0, you can submit a new issue to describe your modify, and then we could discuss in this issue.
[Sharding-jdbc supports nacos configuration](https://github.com/apache/shardingsphere/issues/25445)
@strongduanmu
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] 794086163 commented on issue #24498: FOR shardingsphere5.3 dynamic config suggestion
Posted by "794086163 (via GitHub)" <gi...@apache.org>.
794086163 commented on issue #24498:
URL: https://github.com/apache/shardingsphere/issues/24498#issuecomment-1491464820
> 置
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] liming0 commented on issue #24498: FOR shardingsphere5.3 dynamic config suggestion
Posted by "liming0 (via GitHub)" <gi...@apache.org>.
liming0 commented on issue #24498:
URL: https://github.com/apache/shardingsphere/issues/24498#issuecomment-1524850281
> > I also encountered this issue when using nacos. sharding.yaml cannot reference the values of the configuration files in nacos
>
> sharding现在感觉越做越脱离用户了感觉，搞的新东西完全摒弃原有的，并不兼容，低版本的bug也不修复fix，到高版本直接跨越式的升级，搞的我们在低版本和高版本之间还得手动在应用中重写来修复bug，有点蛋疼
Yes, the main issue is that there is still no smooth transition plan, but fortunately, SPI was provided. I implemented the configuration loading of NACOS myself and also replaced the values referenced by Spring's ${}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] zhaojinchao95 commented on issue #24498: FOR shardingsphere5.3 dynamic config suggestion
Posted by "zhaojinchao95 (via GitHub)" <gi...@apache.org>.
zhaojinchao95 commented on issue #24498:
URL: https://github.com/apache/shardingsphere/issues/24498#issuecomment-1459921762
@hyz1994121 You can look this : https://github.com/apache/shardingsphere/issues/23388
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] hyz1994121 commented on issue #24498: FOR shardingsphere5.3 dynamic config suggestion
Posted by "hyz1994121 (via GitHub)" <gi...@apache.org>.
hyz1994121 commented on issue #24498:
URL: https://github.com/apache/shardingsphere/issues/24498#issuecomment-1460115080
by the way, i found in 5.3.0 , i must use HikariDataSource for sharding.yaml, i wonder know if i can use the alibaba.druid for my DataSource. Becuase the druid provid some monitor for the db connection
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on issue #24498: FOR shardingsphere5.3 dynamic config suggestion
Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu commented on issue #24498:
URL: https://github.com/apache/shardingsphere/issues/24498#issuecomment-1524877504
@liming0 Can you contribute your implement to upstream to help more users?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] FOR shardingsphere5.3 dynamic config suggestion [shardingsphere]
Posted by "linghengqian (via GitHub)" <gi...@apache.org>.
linghengqian closed issue #24498: FOR shardingsphere5.3 dynamic config suggestion
URL: https://github.com/apache/shardingsphere/issues/24498
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] liming0 commented on issue #24498: FOR shardingsphere5.3 dynamic config suggestion
Posted by "liming0 (via GitHub)" <gi...@apache.org>.
liming0 commented on issue #24498:
URL: https://github.com/apache/shardingsphere/issues/24498#issuecomment-1490051099
I also encountered this issue when using nacos. sharding.yaml cannot reference the values of the configuration files in nacos
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on issue #24498: FOR shardingsphere5.3 dynamic config suggestion
Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu commented on issue #24498:
URL: https://github.com/apache/shardingsphere/issues/24498#issuecomment-1526849768
Hi @liming0, you can submit a new issue to describe your modify, and then we could discuss in this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on issue #24498: FOR shardingsphere5.3 dynamic config suggestion
Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu commented on issue #24498:
URL: https://github.com/apache/shardingsphere/issues/24498#issuecomment-1524885312
The Nacos implementation comes from some community contributors, so it is not perfect now, and we hope that more developers will improve it so that it has a chance to become more stable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] hyz1994121 commented on issue #24498: FOR shardingsphere5.3 dynamic config suggestion
Posted by "hyz1994121 (via GitHub)" <gi...@apache.org>.
hyz1994121 commented on issue #24498:
URL: https://github.com/apache/shardingsphere/issues/24498#issuecomment-1459875269
is anyone can help me?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] liming0 commented on issue #24498: FOR shardingsphere5.3 dynamic config suggestion
Posted by "liming0 (via GitHub)" <gi...@apache.org>.
liming0 commented on issue #24498:
URL: https://github.com/apache/shardingsphere/issues/24498#issuecomment-1525237849
> @liming0 Can you contribute your implement to upstream to help more users?
Yes, I have removed the part about spring from my code. How can I contribute the code next
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] hyz1994121 commented on issue #24498: FOR shardingsphere5.3 dynamic config suggestion
Posted by "hyz1994121 (via GitHub)" <gi...@apache.org>.
hyz1994121 commented on issue #24498:
URL: https://github.com/apache/shardingsphere/issues/24498#issuecomment-1491487286
> I also encountered this issue when using nacos. sharding.yaml cannot reference the values of the configuration files in nacos
sharding现在感觉越做越脱离用户了感觉，搞的新东西完全摒弃原有的，并不兼容，低版本的bug也不修复fix，到高版本直接跨越式的升级，搞的我们在低版本和高版本之间还得手动在应用中重写来修复bug，有点蛋疼
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] FOR shardingsphere5.3 dynamic config suggestion [shardingsphere]
Posted by "linghengqian (via GitHub)" <gi...@apache.org>.
linghengqian commented on issue #24498:
URL: https://github.com/apache/shardingsphere/issues/24498#issuecomment-1932153338
- Now at https://shardingsphere.apache.org/document/current/en/user-manual/shardingsphere-jdbc/yaml-config/jdbc-driver/known-implementation/ , there are at least 4 SPI implementation to dynamically define YAML attribute values.
- Refer to
- #29909
- #29907
- #29995
- https://github.com/apache/shardingsphere-plugin?tab=readme-ov-file#jdbc-driver-config-plugin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org