You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Joakim Örtbrant (JIRA)" <ji...@apache.org> on 2008/11/11 18:13:44 UTC
[jira] Created: (WICKET-1928) Enter key submits form in
AjaxEditableMultiLineLabel on Safari
Enter key submits form in AjaxEditableMultiLineLabel on Safari
--------------------------------------------------------------
Key: WICKET-1928
URL: https://issues.apache.org/jira/browse/WICKET-1928
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 1.4-M3
Environment: Mac OSX
Reporter: Joakim Örtbrant
Pressing the Enter key when editing a AjaxEditableMultiLineLabel submits the form on Safari instead of inserting a new line
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1928) Enter key submits form in
AjaxEditableMultiLineLabel on Safari
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12903864#action_12903864 ]
Hudson commented on WICKET-1928:
--------------------------------
Integrated in Apache Wicket 1.4.x #129 (See [https://hudson.apache.org/hudson/job/Apache%20Wicket%201.4.x/129/])
> Enter key submits form in AjaxEditableMultiLineLabel on Safari
> --------------------------------------------------------------
>
> Key: WICKET-1928
> URL: https://issues.apache.org/jira/browse/WICKET-1928
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4-M3
> Environment: Mac OSX
> Reporter: Joakim Örtbrant
> Assignee: Igor Vaynberg
> Fix For: 1.4.11, 1.5-M2
>
>
> Pressing the Enter key when editing a AjaxEditableMultiLineLabel submits the form on Safari instead of inserting a new line
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1928) Enter key submits form in
AjaxEditableMultiLineLabel on Safari
Posted by "Joakim Örtbrant (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12646604#action_12646604 ]
Joakim Örtbrant commented on WICKET-1928:
-----------------------------------------
Replicating the Safari behaviour from AjaxEditableLabel solved this for me:
replace
tag.put("onkeypress", keypress);
with
tag.put("onkeypress", "if (Wicket.Browser.isSafari()) { return; }; " + keypress);
tag.put("onkeydown", "if (!Wicket.Browser.isSafari()) { return; }; " + keypress);
in the onComponentTag implementation when adding the EditorAjaxBehavior.
> Enter key submits form in AjaxEditableMultiLineLabel on Safari
> --------------------------------------------------------------
>
> Key: WICKET-1928
> URL: https://issues.apache.org/jira/browse/WICKET-1928
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4-M3
> Environment: Mac OSX
> Reporter: Joakim Örtbrant
>
> Pressing the Enter key when editing a AjaxEditableMultiLineLabel submits the form on Safari instead of inserting a new line
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WICKET-1928) Enter key submits form in
AjaxEditableMultiLineLabel on Safari
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg reassigned WICKET-1928:
-------------------------------------
Assignee: Matej Knopp
> Enter key submits form in AjaxEditableMultiLineLabel on Safari
> --------------------------------------------------------------
>
> Key: WICKET-1928
> URL: https://issues.apache.org/jira/browse/WICKET-1928
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4-M3
> Environment: Mac OSX
> Reporter: Joakim Örtbrant
> Assignee: Matej Knopp
>
> Pressing the Enter key when editing a AjaxEditableMultiLineLabel submits the form on Safari instead of inserting a new line
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1928) Enter key submits form in
AjaxEditableMultiLineLabel on Safari
Posted by "Martin Simons (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12850057#action_12850057 ]
Martin Simons commented on WICKET-1928:
---------------------------------------
Same thing happens in Chrome, also on OS X. This issue breaks browser-compatibility with WebKit-based browsers so a fast fix would be highly appreciated.
> Enter key submits form in AjaxEditableMultiLineLabel on Safari
> --------------------------------------------------------------
>
> Key: WICKET-1928
> URL: https://issues.apache.org/jira/browse/WICKET-1928
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4-M3
> Environment: Mac OSX
> Reporter: Joakim Örtbrant
> Assignee: Matej Knopp
>
> Pressing the Enter key when editing a AjaxEditableMultiLineLabel submits the form on Safari instead of inserting a new line
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-1928) Enter key submits form in
AjaxEditableMultiLineLabel on Safari
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg resolved WICKET-1928.
-----------------------------------
Assignee: Igor Vaynberg (was: Matej Knopp)
Fix Version/s: 1.4.11
1.5-M2
Resolution: Fixed
sorry this got lost in the shuffle
> Enter key submits form in AjaxEditableMultiLineLabel on Safari
> --------------------------------------------------------------
>
> Key: WICKET-1928
> URL: https://issues.apache.org/jira/browse/WICKET-1928
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4-M3
> Environment: Mac OSX
> Reporter: Joakim Örtbrant
> Assignee: Igor Vaynberg
> Fix For: 1.4.11, 1.5-M2
>
>
> Pressing the Enter key when editing a AjaxEditableMultiLineLabel submits the form on Safari instead of inserting a new line
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.