You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "Young-Flash (via GitHub)" <gi...@apache.org> on 2023/08/29 12:28:09 UTC
[GitHub] [incubator-opendal] Young-Flash opened a new pull request, #2971: update oay-webdav-ci
Young-Flash opened a new pull request, #2971:
URL: https://github.com/apache/incubator-opendal/pull/2971
part of https://github.com/apache/incubator-opendal/pull/2957
tracked in https://github.com/apache/incubator-opendal/issues/2586
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on a diff in pull request #2971: ci(oay): Polish oay webdav test
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #2971:
URL: https://github.com/apache/incubator-opendal/pull/2971#discussion_r1308910446
##########
.github/workflows/oay_test_webdav.yml:
##########
@@ -52,19 +52,17 @@ jobs:
- name: Build and Start WebDAV service
run: |
cargo build --package oay --bin webdav --release
- nohup cargo run --package oay --bin webdav --release &
+ cargo run --package oay --bin webdav --release &
- name: Run litmus tests
run: |
cd litmus-0.13
- TESTS="http basic copymove" HTDOCS=htdocs TESTROOT=. ./litmus http://localhost:3000 >> litmus.log
-
- - name: Check litmus test results
- run: |
- cat litmus-0.13/litmus.log
- if grep -q "FATAL" litmus-0.13/litmus.log; then
- echo "Tests failed"
- exit 1
- else
- echo "All tests passed"
- fi
+ TESTS="http basic copymove" HTDOCS=htdocs TESTROOT=. ./litmus http://localhost:3000 | while IFS= read -r line;
+ do
+ echo "$line"
+ if echo "$line" | grep -q "FATAL"; then
+ echo "Tests failed"
+ exit 1
+ fi
+ done
+ echo "All tests passed"
Review Comment:
But the previous command will print log to console already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Young-Flash commented on a diff in pull request #2971: ci(oay): Polish oay webdav test
Posted by "Young-Flash (via GitHub)" <gi...@apache.org>.
Young-Flash commented on code in PR #2971:
URL: https://github.com/apache/incubator-opendal/pull/2971#discussion_r1309006585
##########
.github/workflows/oay_test_webdav.yml:
##########
@@ -52,19 +52,17 @@ jobs:
- name: Build and Start WebDAV service
run: |
cargo build --package oay --bin webdav --release
- nohup cargo run --package oay --bin webdav --release &
+ cargo run --package oay --bin webdav --release &
- name: Run litmus tests
run: |
cd litmus-0.13
- TESTS="http basic copymove" HTDOCS=htdocs TESTROOT=. ./litmus http://localhost:3000 >> litmus.log
-
- - name: Check litmus test results
- run: |
- cat litmus-0.13/litmus.log
- if grep -q "FATAL" litmus-0.13/litmus.log; then
- echo "Tests failed"
- exit 1
- else
- echo "All tests passed"
- fi
+ TESTS="http basic copymove" HTDOCS=htdocs TESTROOT=. ./litmus http://localhost:3000 | while IFS= read -r line;
+ do
+ echo "$line"
+ if echo "$line" | grep -q "FATAL"; then
+ echo "Tests failed"
+ exit 1
+ fi
+ done
+ echo "All tests passed"
Review Comment:
If there are failed tests, litmus still exit with `0`, which will pass the CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on a diff in pull request #2971: update oay-webdav-ci
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #2971:
URL: https://github.com/apache/incubator-opendal/pull/2971#discussion_r1308879072
##########
.github/workflows/oay_test_webdav.yml:
##########
@@ -52,19 +52,17 @@ jobs:
- name: Build and Start WebDAV service
run: |
cargo build --package oay --bin webdav --release
- nohup cargo run --package oay --bin webdav --release &
+ cargo run --package oay --bin webdav --release &
- name: Run litmus tests
run: |
cd litmus-0.13
- TESTS="http basic copymove" HTDOCS=htdocs TESTROOT=. ./litmus http://localhost:3000 >> litmus.log
-
- - name: Check litmus test results
- run: |
- cat litmus-0.13/litmus.log
- if grep -q "FATAL" litmus-0.13/litmus.log; then
- echo "Tests failed"
- exit 1
- else
- echo "All tests passed"
- fi
+ TESTS="http basic copymove" HTDOCS=htdocs TESTROOT=. ./litmus http://localhost:3000 | while IFS= read -r line;
+ do
+ echo "$line"
+ if echo "$line" | grep -q "FATAL"; then
+ echo "Tests failed"
+ exit 1
+ fi
+ done
+ echo "All tests passed"
Review Comment:
Why we need all those? How about just:
```shell
TESTS="http basic copymove" HTDOCS=htdocs TESTROOT=. ./litmus http://localhost:3000
```
##########
.github/workflows/oay_test_webdav.yml:
##########
@@ -34,7 +34,7 @@ concurrency:
cancel-in-progress: true
jobs:
- oay-webdav-test:
+ oay-webdav-backend-fs:
Review Comment:
`backend-fs` is enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Young-Flash commented on a diff in pull request #2971: ci(oay): Polish oay webdav test
Posted by "Young-Flash (via GitHub)" <gi...@apache.org>.
Young-Flash commented on code in PR #2971:
URL: https://github.com/apache/incubator-opendal/pull/2971#discussion_r1308916978
##########
.github/workflows/oay_test_webdav.yml:
##########
@@ -52,19 +52,17 @@ jobs:
- name: Build and Start WebDAV service
run: |
cargo build --package oay --bin webdav --release
- nohup cargo run --package oay --bin webdav --release &
+ cargo run --package oay --bin webdav --release &
- name: Run litmus tests
run: |
cd litmus-0.13
- TESTS="http basic copymove" HTDOCS=htdocs TESTROOT=. ./litmus http://localhost:3000 >> litmus.log
-
- - name: Check litmus test results
- run: |
- cat litmus-0.13/litmus.log
- if grep -q "FATAL" litmus-0.13/litmus.log; then
- echo "Tests failed"
- exit 1
- else
- echo "All tests passed"
- fi
+ TESTS="http basic copymove" HTDOCS=htdocs TESTROOT=. ./litmus http://localhost:3000 | while IFS= read -r line;
+ do
+ echo "$line"
+ if echo "$line" | grep -q "FATAL"; then
+ echo "Tests failed"
+ exit 1
+ fi
+ done
+ echo "All tests passed"
Review Comment:
see [there](https://github.com/apache/incubator-opendal/actions/runs/6012232503/job/16307186246?pr=2971#step:6:1), it just print once
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Young-Flash commented on a diff in pull request #2971: ci(oay): Polish oay webdav test
Posted by "Young-Flash (via GitHub)" <gi...@apache.org>.
Young-Flash commented on code in PR #2971:
URL: https://github.com/apache/incubator-opendal/pull/2971#discussion_r1308893797
##########
.github/workflows/oay_test_webdav.yml:
##########
@@ -52,19 +52,17 @@ jobs:
- name: Build and Start WebDAV service
run: |
cargo build --package oay --bin webdav --release
- nohup cargo run --package oay --bin webdav --release &
+ cargo run --package oay --bin webdav --release &
- name: Run litmus tests
run: |
cd litmus-0.13
- TESTS="http basic copymove" HTDOCS=htdocs TESTROOT=. ./litmus http://localhost:3000 >> litmus.log
-
- - name: Check litmus test results
- run: |
- cat litmus-0.13/litmus.log
- if grep -q "FATAL" litmus-0.13/litmus.log; then
- echo "Tests failed"
- exit 1
- else
- echo "All tests passed"
- fi
+ TESTS="http basic copymove" HTDOCS=htdocs TESTROOT=. ./litmus http://localhost:3000 | while IFS= read -r line;
+ do
+ echo "$line"
+ if echo "$line" | grep -q "FATAL"; then
+ echo "Tests failed"
+ exit 1
+ fi
+ done
+ echo "All tests passed"
Review Comment:
print the log to console, can help debug when test failed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Young-Flash commented on pull request #2971: ci(oay): Polish oay webdav test
Posted by "Young-Flash (via GitHub)" <gi...@apache.org>.
Young-Flash commented on PR #2971:
URL: https://github.com/apache/incubator-opendal/pull/2971#issuecomment-1701208669
- I'd like to make `Run litmus tests` and `Check litmus test results` together, so contributor will got the result directly when CI fail, without going to check the previous step, which may be fold in github action.
- `FATAL` and `FAIL` may appear in `litmus.log`, I add `grep -E "FATAL|FAIL"`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on a diff in pull request #2971: ci(oay): Polish oay webdav test
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #2971:
URL: https://github.com/apache/incubator-opendal/pull/2971#discussion_r1309946082
##########
.github/workflows/oay_test_webdav.yml:
##########
@@ -52,19 +52,17 @@ jobs:
- name: Build and Start WebDAV service
run: |
cargo build --package oay --bin webdav --release
- nohup cargo run --package oay --bin webdav --release &
+ cargo run --package oay --bin webdav --release &
- name: Run litmus tests
run: |
cd litmus-0.13
- TESTS="http basic copymove" HTDOCS=htdocs TESTROOT=. ./litmus http://localhost:3000 >> litmus.log
-
- - name: Check litmus test results
- run: |
- cat litmus-0.13/litmus.log
- if grep -q "FATAL" litmus-0.13/litmus.log; then
- echo "Tests failed"
- exit 1
- else
- echo "All tests passed"
- fi
+ TESTS="http basic copymove" HTDOCS=htdocs TESTROOT=. ./litmus http://localhost:3000 | while IFS= read -r line;
+ do
+ echo "$line"
+ if echo "$line" | grep -q "FATAL"; then
+ echo "Tests failed"
+ exit 1
+ fi
+ done
+ echo "All tests passed"
Review Comment:
Thank you for the explanation!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo merged pull request #2971: ci(oay): Polish oay webdav test
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo merged PR #2971:
URL: https://github.com/apache/incubator-opendal/pull/2971
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org