[GitHub] [druid] himanshug edited a comment on issue #9638: refactor internal type system

[GitBox <gi...@apache.org>]

himanshug edited a comment on issue #9638: refactor internal type system
URL: https://github.com/apache/druid/pull/9638#issuecomment-611723383
 
 
   > a lot of postaggs produce double typed arrays in their results, and in anticipation of what I think might be a good idea to do next which is merge ValueType and ExprType, I went ahead and added array types to the new and improved ValueType enumeration. ... This is perhaps controversial and worth discussion, but it also doesn't seem to introduce any ill effects as far as I can tell.
   
   that looks ok at first glance but leads to a question. as an aggregation extension writer, if  my aggregator intermediate data type is `double array` then should I override the `getType()` method to return `ValueType.DOUBLE_ARRAY` which would  be not OK I guess and  would lead to problems. so we do end up doing this then javadoc on `AggregatorFactory` and  `PostAggregator` should explain when it is and isn't ok to return `array` type in `getType()` instead  of `ValueType.COMPLEX`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org