You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@poi.apache.org by fa...@apache.org on 2022/07/20 10:56:17 UTC
svn commit: r1902873 - in /poi/trunk: poi-examples/src/main/java/org/apache/poi/examples/xslf/ poi-ooxml/src/test/java/org/apache/poi/xslf/usermodel/
Author: fanningpj
Date: Wed Jul 20 10:56:16 2022
New Revision: 1902873
URL: http://svn.apache.org/viewvc?rev=1902873&view=rev
Log:
use try-with-resources
Modified:
poi/trunk/poi-examples/src/main/java/org/apache/poi/examples/xslf/AddVideoToPptx.java.txt
poi/trunk/poi-examples/src/main/java/org/apache/poi/examples/xslf/LinkVideoToPptx.java
poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xslf/usermodel/TestXSLFExamples.java
Modified: poi/trunk/poi-examples/src/main/java/org/apache/poi/examples/xslf/AddVideoToPptx.java.txt
URL: http://svn.apache.org/viewvc/poi/trunk/poi-examples/src/main/java/org/apache/poi/examples/xslf/AddVideoToPptx.java.txt?rev=1902873&r1=1902872&r2=1902873&view=diff
==============================================================================
--- poi/trunk/poi-examples/src/main/java/org/apache/poi/examples/xslf/AddVideoToPptx.java.txt (original)
+++ poi/trunk/poi-examples/src/main/java/org/apache/poi/examples/xslf/AddVideoToPptx.java.txt Wed Jul 20 10:56:16 2022
@@ -165,16 +165,14 @@ public class AddVideoToPptx {
// see http://msdn.microsoft.com/en-us/library/dd950140(v=office.12).aspx
ext.setUri("{DAA4B4D4-6D71-4841-9C94-3DE7FCFB9230}");
String p14Ns = "http://schemas.microsoft.com/office/powerpoint/2010/main";
- XmlCursor cur = ext.newCursor();
- try {
+
+ try (XmlCursor cur = ext.newCursor()) {
cur.toEndToken();
cur.beginElement(new QName(p14Ns, "media", "p14"));
cur.insertNamespace("p14", p14Ns);
cur.insertAttributeWithValue(new QName(STRelationshipId.type.getName().getNamespaceURI(), "embed"), prsEmbed1.getId());
cur.beginElement(new QName(p14Ns, "trim", "p14"));
cur.insertAttributeWithValue("st", df_time.format(seconds*1000.0));
- } finally {
- cur.dispose();
}
}
Modified: poi/trunk/poi-examples/src/main/java/org/apache/poi/examples/xslf/LinkVideoToPptx.java
URL: http://svn.apache.org/viewvc/poi/trunk/poi-examples/src/main/java/org/apache/poi/examples/xslf/LinkVideoToPptx.java?rev=1902873&r1=1902872&r2=1902873&view=diff
==============================================================================
--- poi/trunk/poi-examples/src/main/java/org/apache/poi/examples/xslf/LinkVideoToPptx.java (original)
+++ poi/trunk/poi-examples/src/main/java/org/apache/poi/examples/xslf/LinkVideoToPptx.java Wed Jul 20 10:56:16 2022
@@ -84,14 +84,11 @@ public final class LinkVideoToPptx {
ext.setUri("{DAA4B4D4-6D71-4841-9C94-3DE7FCFB9230}");
String p14Ns = "http://schemas.microsoft.com/office/powerpoint/2010/main";
- XmlCursor cur = ext.newCursor();
- try {
+ try (XmlCursor cur = ext.newCursor()) {
cur.toEndToken();
cur.beginElement(new QName(p14Ns, "media", "p14"));
cur.insertNamespace("p14", p14Ns);
cur.insertAttributeWithValue(new QName(CORE_PROPERTIES_ECMA376_NS, "link"), prsEmbed1.getId());
- } finally {
- cur.dispose();
}
CTSlide xslide = slide1.getXmlObject();
Modified: poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xslf/usermodel/TestXSLFExamples.java
URL: http://svn.apache.org/viewvc/poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xslf/usermodel/TestXSLFExamples.java?rev=1902873&r1=1902872&r2=1902873&view=diff
==============================================================================
--- poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xslf/usermodel/TestXSLFExamples.java (original)
+++ poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xslf/usermodel/TestXSLFExamples.java Wed Jul 20 10:56:16 2022
@@ -55,7 +55,7 @@ import org.openxmlformats.schemas.presen
*/
class TestXSLFExamples {
@Test
- void LinkVideoToPptx() throws IOException, URISyntaxException {
+ void linkVideoToPptx() throws IOException, URISyntaxException {
String videoFileName = "file_example_MP4_640_3MG.mp4";
File previewJpg = POIDataSamples.getDocumentInstance().getFile("abstract1.jpg");
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org