You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2016/11/14 22:19:29 UTC

[kudu-CR](branch-1.1.x) [doc] fixed misprint in share ptr pros item icon 

Hello Will Berkeley, Kudu Jenkins,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/5073

to review the following change.

Change subject: [doc] fixed misprint in share_ptr pros item icon
......................................................................

[doc] fixed misprint in share_ptr pros item icon

Change-Id: I179a4525408b78fc34bb35534dc5809e63d2fc50
Reviewed-on: http://gerrit.cloudera.org:8080/5065
Reviewed-by: Will Berkeley <wd...@gmail.com>
Tested-by: Kudu Jenkins
---
M docs/contributing.adoc
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/73/5073/1
-- 
To view, visit http://gerrit.cloudera.org:8080/5073
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I179a4525408b78fc34bb35534dc5809e63d2fc50
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.1.x
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>

[kudu-CR](branch-1.1.x) [doc] fixed misprint in share ptr pros item icon

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.

Change subject: [doc] fixed misprint in share_ptr pros item icon
......................................................................


[doc] fixed misprint in share_ptr pros item icon

Change-Id: I179a4525408b78fc34bb35534dc5809e63d2fc50
Reviewed-on: http://gerrit.cloudera.org:8080/5065
Reviewed-by: Will Berkeley <wd...@gmail.com>
Tested-by: Kudu Jenkins
Reviewed-on: http://gerrit.cloudera.org:8080/5073
Tested-by: Todd Lipcon <to...@apache.org>
---
M docs/contributing.adoc
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Will Berkeley: Looks good to me, approved
  Todd Lipcon: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/5073
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I179a4525408b78fc34bb35534dc5809e63d2fc50
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: branch-1.1.x
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>

[kudu-CR](branch-1.1.x) [doc] fixed misprint in share ptr pros item icon

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.

Change subject: [doc] fixed misprint in share_ptr pros item icon
......................................................................


Patch Set 1: Verified+1

-- 
To view, visit http://gerrit.cloudera.org:8080/5073
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I179a4525408b78fc34bb35534dc5809e63d2fc50
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.1.x
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: No

[kudu-CR](branch-1.1.x) [doc] fixed misprint in share ptr pros item icon

Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change.

Change subject: [doc] fixed misprint in share_ptr pros item icon
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/5073
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I179a4525408b78fc34bb35534dc5809e63d2fc50
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.1.x
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: No