[GitHub] [geode] bschuchardt commented on a change in pull request #4994: GEODE-8020: buffer corruption in SSL communications

[GitBox <gi...@apache.org>]

bschuchardt commented on a change in pull request #4994:
URL: https://github.com/apache/geode/pull/4994#discussion_r415364809



##########
File path: geode-core/src/main/java/org/apache/geode/internal/tcp/Connection.java
##########
@@ -1662,8 +1662,8 @@ private void readMessages() {
         } catch (IOException e) {
           // "Socket closed" check needed for Solaris jdk 1.4.2_08
           if (!isSocketClosed() && !"Socket closed".equalsIgnoreCase(e.getMessage())) {
-            if (logger.isDebugEnabled() && !isIgnorableIOException(e)) {
-              logger.debug("{} io exception for {}", p2pReaderName(), this, e);
+            if (logger.isInfoEnabled() && !isIgnorableIOException(e)) {

Review comment:
       yes!  I only saw the SSLException that explained the message-loss when debug-level logging was enabled.  With this log level change I had to augment isIgnorableException to filter out some exceptions being caught here when the socket was closed.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org