You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@isis.apache.org by GitBox <gi...@apache.org> on 2022/02/25 08:32:39 UTC
[GitHub] [isis-app-simpleapp] a-st opened a new pull request #6: Issue: Compilation failure after adding Lombok NonNull annotation to JDO Entity fields
a-st opened a new pull request #6:
URL: https://github.com/apache/isis-app-simpleapp/pull/6
Based on the Apache Isis 2 SimpleApp JDO project (<https://github.com/apache/isis-app-simpleapp/tree/jdo>) I tried to slightly modify the `SimpleObject` class to mark some fields (`name` and `notes`) as not nullable using the Lombok annotation `@NonNull`. This unexpectedly results in a compilation failure:
```
Error: Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) on project simpleapp-jdo-module-simple: Compilation failure: Compilation failure:
Error: /home/runner/work/isis-app-simpleapp/isis-app-simpleapp/module-simple/target/generated-sources/annotations/domainapp/modules/simple/dom/so/QSimpleObject.java:[35,51] cannot find symbol
Error: symbol: class java
Error: location: class domainapp.modules.simple.dom.so.QSimpleObject
Error: /home/runner/work/isis-app-simpleapp/isis-app-simpleapp/module-simple/target/generated-sources/annotations/domainapp/modules/simple/dom/so/QSimpleObject.java:[36,51] cannot find symbol
Error: symbol: class java
Error: location: class domainapp.modules.simple.dom.so.QSimpleObject
Error: -> [Help 1]
```
Related GitHub Action: <https://github.com/a-st/isis-app-simpleapp/runs/5330590432>
Related SO Post: <https://stackoverflow.com/q/71262961/6438521>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@isis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [isis-app-simpleapp] a-st commented on pull request #6: Issue: Compilation failure after adding Lombok NonNull annotation to JDO Entity fields
Posted by GitBox <gi...@apache.org>.
a-st commented on pull request #6:
URL: https://github.com/apache/isis-app-simpleapp/pull/6#issuecomment-1050677448
I'm going to discuss this issue with _DataNucleus_ and/or _Lombok_. Anyways, thanks for the highly appreciated help 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@isis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [isis-app-simpleapp] a-st commented on pull request #6: Issue: Compilation failure after adding Lombok NonNull annotation to JDO Entity fields
Posted by GitBox <gi...@apache.org>.
a-st commented on pull request #6:
URL: https://github.com/apache/isis-app-simpleapp/pull/6#issuecomment-1050658999
> Also, remember we have support for both JPA and JDO, so evaluate both and decided which fits your needs best.
Thank you very much for the hint. 👍
We are currently evaluating a migration of a legacy Apache Isis 1.17.0 application (which uses JDO) to Apache Isis >= 2.0.0-M6 and really don't want to bother with switching from JDO to JPA at the same time of migrating to a new Apache Isis major release 😉
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@isis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [isis-app-simpleapp] andi-huber commented on pull request #6: Issue: Compilation failure after adding Lombok NonNull annotation to JDO Entity fields
Posted by GitBox <gi...@apache.org>.
andi-huber commented on pull request #6:
URL: https://github.com/apache/isis-app-simpleapp/pull/6#issuecomment-1050678806
> I'm going to discuss this issue with _DataNucleus_ and/or _Lombok_. Anyways, thanks for the highly appreciated help 👍
Also much appreciated. Thx!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@isis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [isis-app-simpleapp] a-st commented on pull request #6: Issue: Compilation failure after adding Lombok NonNull annotation to JDO Entity fields
Posted by GitBox <gi...@apache.org>.
a-st commented on pull request #6:
URL: https://github.com/apache/isis-app-simpleapp/pull/6#issuecomment-1050651778
> The error you are seeing is typical, if the _DataNucleus_ annotation processing step did not run (and did not create `QSimpleObject`).
According to the GitHub Action output the _DataNucleus_ annotation processing step did run:
```
2022-02-25T08:06:04.2400190Z Downloaded from central: https://repo.maven.apache.org/maven2/com/thoughtworks/qdox/qdox/2.0-M9/qdox-2.0-M9.jar (317 kB at 2.9 MB/s)
2022-02-25T08:06:04.3519525Z [INFO] Changes detected - recompiling the module!
2022-02-25T08:06:04.3554548Z [INFO] Compiling 7 source files to /home/runner/work/isis-app-simpleapp/isis-app-simpleapp/module-simple/target/classes
2022-02-25T08:06:05.7347244Z DataNucleus : JDOQLTypedQuery Q class generation : domainapp.modules.simple.dom.so.SimpleObject -> domainapp.modules.simple.dom.so.QSimpleObject
2022-02-25T08:06:06.4706348Z [INFO] -------------------------------------------------------------
2022-02-25T08:06:06.4707267Z [ERROR] COMPILATION ERROR :
2022-02-25T08:06:06.4709686Z [INFO] -------------------------------------------------------------
2022-02-25T08:06:06.4710700Z [ERROR] /home/runner/work/isis-app-simpleapp/isis-app-simpleapp/module-simple/target/generated-sources/annotations/domainapp/modules/simple/dom/so/QSimpleObject.java:[35,51] cannot find symbol
2022-02-25T08:06:06.4711436Z symbol: class java
2022-02-25T08:06:06.4711956Z location: class domainapp.modules.simple.dom.so.QSimpleObject
2022-02-25T08:06:06.4713823Z [ERROR] /home/runner/work/isis-app-simpleapp/isis-app-simpleapp/module-simple/target/generated-sources/annotations/domainapp/modules/simple/dom/so/QSimpleObject.java:[36,51] cannot find symbol
2022-02-25T08:06:06.4714522Z symbol: class java
2022-02-25T08:06:06.4715206Z location: class domainapp.modules.simple.dom.so.QSimpleObject
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@isis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [isis-app-simpleapp] a-st edited a comment on pull request #6: Issue: Compilation failure after adding Lombok NonNull annotation to JDO Entity fields
Posted by GitBox <gi...@apache.org>.
a-st edited a comment on pull request #6:
URL: https://github.com/apache/isis-app-simpleapp/pull/6#issuecomment-1050687656
The issue seems to be fixed with **DataNucleus 6.x**. After specifying
```xml
<dependency>
<groupId>org.datanucleus</groupId>
<artifactId>datanucleus-jdo-query</artifactId>
<version>6.0.0-m1</version>
</dependency>
```
the issue is gone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@isis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [isis-app-simpleapp] a-st commented on pull request #6: Issue: Compilation failure after adding Lombok NonNull annotation to JDO Entity fields
Posted by GitBox <gi...@apache.org>.
a-st commented on pull request #6:
URL: https://github.com/apache/isis-app-simpleapp/pull/6#issuecomment-1050687656
The issue seems to be fixed with **DataNucleus 6.x**
```xml
<dependency>
<groupId>org.datanucleus</groupId>
<artifactId>datanucleus-jdo-query</artifactId>
<version>6.0.0-m1</version>
</dependency>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@isis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [isis-app-simpleapp] andi-huber commented on pull request #6: Issue: Compilation failure after adding Lombok NonNull annotation to JDO Entity fields
Posted by GitBox <gi...@apache.org>.
andi-huber commented on pull request #6:
URL: https://github.com/apache/isis-app-simpleapp/pull/6#issuecomment-1050659867
Hmm ok, so maybe an issue with _DataNucleus_ in connection with _Lombok_.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@isis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [isis-app-simpleapp] a-st commented on pull request #6: Issue: Compilation failure after adding Lombok NonNull annotation to JDO Entity fields
Posted by GitBox <gi...@apache.org>.
a-st commented on pull request #6:
URL: https://github.com/apache/isis-app-simpleapp/pull/6#issuecomment-1050663257
> Hmm ok, so maybe an issue with _DataNucleus_ in connection with _Lombok_.
That's what I suspect as well. E.g. using `@javax.annotation.Nonnull` instead of `@lombok.NonNull` resolves the compilation failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@isis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [isis-app-simpleapp] danhaywood commented on pull request #6: Issue: Compilation failure after adding Lombok NonNull annotation to JDO Entity fields
Posted by GitBox <gi...@apache.org>.
danhaywood commented on pull request #6:
URL: https://github.com/apache/isis-app-simpleapp/pull/6#issuecomment-1050649763
Also, remember we have support for both JPA and JDO, so evaluate both and
decided which fits your needs best.
On Fri, 25 Feb 2022 at 08:36, Andi Huber ***@***.***> wrote:
> The error you are seeing is typical, if the *DataNucleus* annotation
> processing step did not run (and did not create QSimpleObject).
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/isis-app-simpleapp/pull/6#issuecomment-1050645676>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAH33SOVLMYTLFWHLZYW3WLU445P5ANCNFSM5PJUCHCA>
> .
> You are receiving this because you are subscribed to this thread.Message
> ID: ***@***.***>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@isis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [isis-app-simpleapp] andi-huber commented on pull request #6: Issue: Compilation failure after adding Lombok NonNull annotation to JDO Entity fields
Posted by GitBox <gi...@apache.org>.
andi-huber commented on pull request #6:
URL: https://github.com/apache/isis-app-simpleapp/pull/6#issuecomment-1050645676
The error you are seeing is typical, if the _DataNucleus_ annotation processing step did not run (and did not create `QSimpleObject`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@isis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [isis-app-simpleapp] a-st closed pull request #6: Issue: Compilation failure after adding Lombok NonNull annotation to JDO Entity fields
Posted by GitBox <gi...@apache.org>.
a-st closed pull request #6:
URL: https://github.com/apache/isis-app-simpleapp/pull/6
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@isis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org