You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by "xyuanlu (via GitHub)" <gi...@apache.org> on 2023/12/18 18:51:18 UTC
[PR] Merge feature branch - Application cluster manager [helix]
xyuanlu opened a new pull request, #2714:
URL: https://github.com/apache/helix/pull/2714
### Issues
- [X] My PR addresses the following Helix issues and references them in the PR description:
#2662
#2655
### Description
- [X] Here are some details about my PR, including screenshots of any UI changes:
Merge feature branch ApplicationClusterManager, including the following changes.
[Refactor stoppable check logic for enhanced zone analysis (](https://github.com/apache/helix/commit/23eba7d9fcc4c979bf02f0872412af92343a1e99)https://github.com/apache/helix/pull/2654[)](https://github.com/apache/helix/commit/23eba7d9fcc4c979bf02f0872412af92343a1e99)
@MarkGaox
MarkGaox authored and Xiaoyuan Lu committed 5 days ago
Implement the cross-zone-based stoppable check (#2680)
@MarkGaox
MarkGaox authored and Xiaoyuan Lu committed 5 days ago
HelixAdmin APIs and pipeline changes to support Helix Node Swap (#2661)
@zpinto
zpinto authored and Xiaoyuan Lu committed 5 days ago
Enhanced stoppable checks with node evacuation filtering and introduc…
@[MarkGaox](https://github.com/apache/helix/commits?author=MarkGaox)
MarkGaox authored and Xiaoyuan Lu committed 5 days ago
Change canCompleteSwap and completeSwapIfPossible to return json with…
@zpinto
zpinto authored and Xiaoyuan Lu committed 5 days ago
Expose Evacuate Finished API in Helix-Rest (#2694[)](https://github.com/apache/helix/commit/729a0c5e96c04cdd5e6fa6566fbad0248885c036)
@GrantPSpencer
GrantPSpencer authored and Xiaoyuan Lu committed 5 days ago
Fix WAGED to only use logicalId when computing baseline and centraliz…
@zpinto
zpinto authored and Xiaoyuan Lu committed 5 days ago
Make logic to determine state of replicas on SWAP_IN instance simpler…
@zpinto
zpinto authored and Xiaoyuan Lu committed 5 days ago
Prevent the spectator routing table from containing SWAP_IN instances.(…
@zpinto
zpinto authored and Xiaoyuan Lu committed 5 days ago
Commits on Dec 14, 2023
Build Topology with only required levels (FaultZone and EndNode[)](https://github.com/apache/helix/commit/ac851955e8dabe72d49b51da4f256d2d550e1687) (#2713[)](https://github.com/apache/helix/commit/12af3ebef9de719cec97d5cf92abe4fcbf4fb290)
### Tests
- [X] The following tests are written for this issue:
Please refer to original PRs
- The following is the result of the "mvn test" command on the appropriate module:
(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)
### Changes that Break Backward Compatibility (Optional)
- My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include:
(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)
### Documentation (Optional)
- In case of new functionality, my PR adds documentation in the following wiki page:
(Link the GitHub wiki you added)
### Commits
- My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
Re: [PR] Merge feature branch - Application cluster manager [helix]
Posted by "xyuanlu (via GitHub)" <gi...@apache.org>.
xyuanlu merged PR #2714:
URL: https://github.com/apache/helix/pull/2714
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org