You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by xubo245 <gi...@git.apache.org> on 2018/04/16 03:05:58 UTC
[GitHub] carbondata pull request #2173: [WIP][TEST]Carbondata rpc
GitHub user xubo245 opened a pull request:
https://github.com/apache/carbondata/pull/2173
[WIP][TEST]Carbondata rpc
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed?
- [ ] Any backward compatibility impacted?
- [ ] Document update required?
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xubo245/carbondata carbondata-rpc
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2173.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2173
----
commit 5c1b6c08a20a314149928412224f3143b5006b67
Author: Jacky Li <ja...@...>
Date: 2018-04-15T01:06:03Z
support search mode by gRPC
commit 52faa528c14580dc71884bb240ea8c4c1a3edfa7
Author: Jacky Li <ja...@...>
Date: 2018-04-15T15:54:23Z
fix comment
commit 07c3b56e16b6fd1d15e0050076943bf0f6cdd129
Author: xubo245 <60...@...>
Date: 2018-04-16T02:59:18Z
remove unused import
----
---
[GitHub] carbondata issue #2173: [CARBONDATA-2379] Support Search mode run in the clu...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2173
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5318/
---
[GitHub] carbondata issue #2173: [CARBONDATA-2379] Support Search mode run in the clu...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2173
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5339/
---
[GitHub] carbondata issue #2173: [WIP][TEST]Carbondata rpc
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2173
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4052/
---
[GitHub] carbondata pull request #2173: [CARBONDATA-2379] Support SearchModeExample r...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/2173
---
[GitHub] carbondata issue #2173: [CARBONDATA-2379] Support SearchModeExample run in c...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/2173
LGTM
---
[GitHub] carbondata issue #2173: [CARBONDATA-2379] Support Search mode run in the clu...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2173
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4148/
---
[GitHub] carbondata issue #2173: [CARBONDATA-2379] Support SearchModeExample run in c...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2173
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4305/
---
[GitHub] carbondata issue #2173: [CARBONDATA-2379] Support Search mode run in the clu...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2173
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5378/
---
[GitHub] carbondata issue #2173: [CARBONDATA-2379] Support SearchModeExample run in c...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2173
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5489/
---
[GitHub] carbondata issue #2173: [CARBONDATA-2379] Support SearchModeExample run in c...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2173
@jackylk CI pass, please check it again.
---
[GitHub] carbondata issue #2173: [WIP][TEST]Carbondata rpc
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2173
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4091/
---
[GitHub] carbondata issue #2173: [WIP][TEST]Carbondata rpc
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2173
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4097/
---
[GitHub] carbondata issue #2173: [CARBONDATA-2379] Support SearchModeExample run in c...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2173
retest this please
---
[GitHub] carbondata issue #2173: [WIP][TEST]Carbondata rpc
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2173
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5236/
---
[GitHub] carbondata pull request #2173: [CARBONDATA-2379] Support Search mode run in ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2173#discussion_r184365027
--- Diff: store/search/src/main/java/org/apache/carbondata/store/worker/SearchRequestHandler.java ---
@@ -105,8 +105,6 @@ public ShutdownResponse handleShutdown(ShutdownRequest request) {
}
} catch (InterruptedException e) {
throw new IOException(e);
- } finally {
- reader.close();
--- End diff --
I think it is needed, otherwise memory and resources won't be cleaned
---
[GitHub] carbondata issue #2173: [CARBONDATA-2379] Support SearchModeExample run in c...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2173
@jackylk Ok, done
---
[GitHub] carbondata issue #2173: [CARBONDATA-2379] Support SearchModeExample run in c...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2173
retest this please
---
[GitHub] carbondata issue #2173: [CARBONDATA-2379] Support SearchModeExample run in c...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2173
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5450/
---
[GitHub] carbondata issue #2173: [CARBONDATA-2379] Support SearchModeExample run in c...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2173
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4323/
---
[GitHub] carbondata issue #2173: [CARBONDATA-2379] Support Search mode run in the clu...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2173
retest this please
---
[GitHub] carbondata issue #2173: [CARBONDATA-2379] Support Search mode run in the clu...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2173
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4184/
---
[GitHub] carbondata issue #2173: [CARBONDATA-2379] Support Search mode run in the clu...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2173
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4158/
---
[GitHub] carbondata issue #2173: [WIP][TEST]Carbondata rpc
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2173
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5278/
---
[GitHub] carbondata issue #2173: [WIP][TEST]Carbondata rpc
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2173
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5274/
---
[GitHub] carbondata issue #2173: [CARBONDATA-2379] Support SearchModeExample run in c...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2173
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5500/
---
[GitHub] carbondata issue #2173: [CARBONDATA-2379] Support SearchModeExample run in c...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2173
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4280/
---
[GitHub] carbondata issue #2173: [CARBONDATA-2379] Support Search mode run in the clu...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2173
@jackylk Please review it
---
[GitHub] carbondata issue #2173: [WIP][TEST]Carbondata rpc
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2173
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3939/
---
[GitHub] carbondata issue #2173: [CARBONDATA-2379] Support SearchModeExample run in c...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2173
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4294/
---
[GitHub] carbondata issue #2173: [CARBONDATA-2379] Support Search mode run in the clu...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2173
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4201/
---
[GitHub] carbondata issue #2173: [CARBONDATA-2379] Support Search mode run in the clu...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2173
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5371/
---
[GitHub] carbondata issue #2173: [WIP][TEST]Carbondata rpc
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2173
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5032/
---
[GitHub] carbondata pull request #2173: [CARBONDATA-2379] Support Search mode run in ...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2173#discussion_r184361813
--- Diff: store/search/src/main/java/org/apache/carbondata/store/worker/SearchRequestHandler.java ---
@@ -105,8 +105,6 @@ public ShutdownResponse handleShutdown(ShutdownRequest request) {
}
} catch (InterruptedException e) {
throw new IOException(e);
- } finally {
- reader.close();
--- End diff --
@kumarvishal09 @ravipesala I think this close operation is needed. Can you check whether this is ok?
---
[GitHub] carbondata issue #2173: [WIP][TEST]Carbondata rpc
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2173
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4046/
---
[GitHub] carbondata issue #2173: [WIP][TEST]Carbondata rpc
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2173
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3815/
---
[GitHub] carbondata issue #2173: [CARBONDATA-2379] Support Search mode run in the clu...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2173
retest this please
---
[GitHub] carbondata issue #2173: [WIP][TEST]Carbondata rpc
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2173
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3816/
---
[GitHub] carbondata issue #2173: [CARBONDATA-2379] Support Search mode run in the clu...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2173
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4212/
---
[GitHub] carbondata issue #2173: [CARBONDATA-2379] Support Search mode run in the clu...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2173
retest sdv please
---
[GitHub] carbondata issue #2173: [WIP][TEST]Carbondata rpc
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2173
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5272/
---
[GitHub] carbondata issue #2173: [CARBONDATA-2379] Support SearchModeExample run in c...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2173
retest this please
---
[GitHub] carbondata issue #2173: [CARBONDATA-2379] Support Search mode run in the clu...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2173
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4137/
---
[GitHub] carbondata issue #2173: [CARBONDATA-2379] Support Search mode run in the clu...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2173
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4204/
---
[GitHub] carbondata issue #2173: [WIP][TEST]Carbondata rpc
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2173
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5224/
---
[GitHub] carbondata pull request #2173: [CARBONDATA-2379] Support SearchModeExample r...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2173#discussion_r184575309
--- Diff: store/search/src/main/java/org/apache/carbondata/store/worker/SearchRequestHandler.java ---
@@ -105,8 +105,6 @@ public ShutdownResponse handleShutdown(ShutdownRequest request) {
}
} catch (InterruptedException e) {
throw new IOException(e);
- } finally {
- reader.close();
--- End diff --
Ok, keep it.
---
[GitHub] carbondata issue #2173: [CARBONDATA-2379] Support Search mode run in the clu...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/2173
Please change the title to `Support SearchModeExample run in cluster`
---
[GitHub] carbondata issue #2173: [CARBONDATA-2379] Support Search mode run in the clu...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2173
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5325/
---
[GitHub] carbondata issue #2173: [WIP][TEST]Carbondata rpc
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2173
retest this please
---
[GitHub] carbondata issue #2173: [CARBONDATA-2379] Support Search mode run in the clu...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2173
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5313/
---
[GitHub] carbondata issue #2173: [CARBONDATA-2379] Support Search mode run in the clu...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2173
retest this please
---
[GitHub] carbondata issue #2173: [WIP][TEST]Carbondata rpc
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2173
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5030/
---
[GitHub] carbondata issue #2173: [CARBONDATA-2379] Support SearchModeExample run in c...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2173
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5459/
---
[GitHub] carbondata issue #2173: [CARBONDATA-2379] Support Search mode run in the clu...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2173
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5359/
---
[GitHub] carbondata issue #2173: [CARBONDATA-2379] Support SearchModeExample run in c...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2173
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4335/
---
[GitHub] carbondata issue #2173: [CARBONDATA-2379] Support SearchModeExample run in c...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2173
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5472/
---
[GitHub] carbondata issue #2173: [CARBONDATA-2379] Support Search mode run in the clu...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2173
retest this please
---
[GitHub] carbondata issue #2173: [WIP][TEST]Carbondata rpc
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2173
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4035/
---
[GitHub] carbondata issue #2173: [CARBONDATA-2379] Support Search mode run in the clu...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2173
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4503/
---
[GitHub] carbondata issue #2173: [CARBONDATA-2379] Support Search mode run in the clu...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2173
retest this please
---
[GitHub] carbondata issue #2173: [CARBONDATA-2379] Support Search mode run in the clu...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2173
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4133/
---