You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Sriharsha Chintalapani <ha...@hortonworks.com> on 2014/05/24 04:05:13 UTC
Review Request 21883: Patch for KAFKA-1459
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21883/
-----------------------------------------------------------
Review request for kafka.
Bugs: KAFKA-1459
https://issues.apache.org/jira/browse/KAFKA-1459
Repository: kafka
Description
-------
KAFKA-1459. kafka.tools.ConsumerOffsetChecker throws NoNodeException.
Diffs
-----
core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala 88f824fa5afe7964efc569bc0732fd40a55c5c93
Diff: https://reviews.apache.org/r/21883/diff/
Testing
-------
Thanks,
Sriharsha Chintalapani
Re: Review Request 21883: Patch for KAFKA-1459
Posted by Guozhang Wang <gu...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21883/#review44068
-----------------------------------------------------------
core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala
<https://reviews.apache.org/r/21883/#comment78396>
"0" could still be a valid offset since our offsets start at 0. Could you use -1 instead?
- Guozhang Wang
On May 24, 2014, 2:05 a.m., Sriharsha Chintalapani wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21883/
> -----------------------------------------------------------
>
> (Updated May 24, 2014, 2:05 a.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1459
> https://issues.apache.org/jira/browse/KAFKA-1459
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1459. kafka.tools.ConsumerOffsetChecker throws NoNodeException.
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala 88f824fa5afe7964efc569bc0732fd40a55c5c93
>
> Diff: https://reviews.apache.org/r/21883/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sriharsha Chintalapani
>
>
Re: Review Request 21883: Patch for KAFKA-1459
Posted by Neha Narkhede <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21883/#review44014
-----------------------------------------------------------
Ship it!
Ship It!
- Neha Narkhede
On May 24, 2014, 2:05 a.m., Sriharsha Chintalapani wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21883/
> -----------------------------------------------------------
>
> (Updated May 24, 2014, 2:05 a.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1459
> https://issues.apache.org/jira/browse/KAFKA-1459
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1459. kafka.tools.ConsumerOffsetChecker throws NoNodeException.
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala 88f824fa5afe7964efc569bc0732fd40a55c5c93
>
> Diff: https://reviews.apache.org/r/21883/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sriharsha Chintalapani
>
>
Re: Review Request 21883: Patch for KAFKA-1459
Posted by Guozhang Wang <gu...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21883/#review44093
-----------------------------------------------------------
Ship it!
Neha, would you like to check this in as a follow-up?
- Guozhang Wang
On May 28, 2014, 3:19 a.m., Sriharsha Chintalapani wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21883/
> -----------------------------------------------------------
>
> (Updated May 28, 2014, 3:19 a.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1459
> https://issues.apache.org/jira/browse/KAFKA-1459
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1459. kafka.tools.ConsumerOffsetChecker throws NoNodeException.
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala ae83e4d5fa26ae600b51062282c5dd355c9b6618
>
> Diff: https://reviews.apache.org/r/21883/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sriharsha Chintalapani
>
>
Re: Review Request 21883: Patch for KAFKA-1459
Posted by Sriharsha Chintalapani <ha...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21883/
-----------------------------------------------------------
(Updated May 28, 2014, 3:19 a.m.)
Review request for kafka.
Bugs: KAFKA-1459
https://issues.apache.org/jira/browse/KAFKA-1459
Repository: kafka
Description
-------
KAFKA-1459. kafka.tools.ConsumerOffsetChecker throws NoNodeException.
Diffs (updated)
-----
core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala ae83e4d5fa26ae600b51062282c5dd355c9b6618
Diff: https://reviews.apache.org/r/21883/diff/
Testing
-------
Thanks,
Sriharsha Chintalapani