You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by Christoph Goller <go...@detego-software.de> on 2004/10/01 12:07:30 UTC
Re: Lucene 1.4.2?
Christoph Goller wrote:
> Doug Cutting wrote:
>
>> Christoph Goller wrote:
>>
>>> I'd like the changes on FuzzyQuery, PhraseQuery, and PhrasePrefixQuery
>>> included in the branch. Any objections?
>>
>>
>>
>> I'm okay with these, but the primary purpose of 1.4.2 should be to
>> stabilize things, not to add new features. So let's be very selective
>> about what we add, and scrutinize changes carefully so we don't
>> introduce new bugs. Are you confident that these are "safe" changes?
>
>
> Yes, I am.
>
>>
>> If we agree to let a *few* features in, then I vote for my
>> optimization to IndexSearcher. Of all the optimizations I made
>> recently, the single biggest performance improvement was to avoid
>> allocating a new ScoreDoc for every non-zero score in
>> IndexSearcher.search(Query,Filter,int). I think this is safe. Are
>> there any concerns about putting this optimization into 1.4.2?
>
>
> Yes, I am also 100% sure that this optimization is safe. I would never
> have guessed that calling the constructor there could make such a
> difference.
>
> I looked through the list of changes since 1.4.1 and think the following
> items
> should be considered for 1.4.2:
>
> 2, 4, 5, 9, 10, 13, 16, 17
>
> The following items from my list are enhancements, not bug fixes:
>
> 2, 9 (FuzzyQuery, PhraseQuery, and PhrasePrefixQuery)
> 5 (peak disk requirements during indexing)
> 16 (your optimization)
I committed items 2, 9, and 10.
2 and 9 are my (and Daniel's) query extensions. I am 100% sure they
are correct. 10 is about a bug in QueryParser and some minor
QueryParser extensions that I did not want to pick apart from the
bug fix.
Items 4 and 5 don't seem that important to me. As far as I am
concerned we can leave them out. So the only thing missing is your
optimization. Then 1.4.2 should be ready.
Christoph
---------------------------------------------------------------------
To unsubscribe, e-mail: lucene-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: lucene-dev-help@jakarta.apache.org
Re: Lucene 1.4.2?
Posted by Daniel Naber <da...@t-online.de>.
On Saturday 02 October 2004 13:45, Christoph Goller wrote:
> > Too bad I found the first bug already: the CHANGES files describes the
> > new fuzzy syntax (e.g. fuzzy~0.7), but this isn't part of the release
> > (i.e. the QueryParser part of that feature is missing). Any chance to
> > fix this (i.e. change the CHANGES file, not the QueryParser). I guess
> > we should take more time for the next release.
>
> It is part of 1.4.2. I included all the changes on QueryParser.
Sorry for the false alarm, you're right. The bug with my test was on a
different level, the fuzziness got lost somewhere else.
Regards
Daniel
--
http://www.danielnaber.de
---------------------------------------------------------------------
To unsubscribe, e-mail: lucene-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: lucene-dev-help@jakarta.apache.org
Re: Lucene 1.4.2?
Posted by Christoph Goller <go...@detego-software.de>.
Daniel Naber wrote:
> On Friday 01 October 2004 23:57, Doug Cutting wrote:
>
>
>>The new release is up at http://jakarta.apache.org/lucene/.
>
>
> Thanks, I will submit it to freshmeat.net tomorrow. Should I also announce
> it on the mailing lists, as suggested at
> http://nagoya.apache.org/wiki/apachewiki.cgi?ReleaseManager or do you want
> to do that?
>
> Too bad I found the first bug already: the CHANGES files describes the new
> fuzzy syntax (e.g. fuzzy~0.7), but this isn't part of the release (i.e.
> the QueryParser part of that feature is missing). Any chance to fix this
> (i.e. change the CHANGES file, not the QueryParser). I guess we should
> take more time for the next release.
It is part of 1.4.2. I included all the changes on QueryParser.
Christoph
---------------------------------------------------------------------
To unsubscribe, e-mail: lucene-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: lucene-dev-help@jakarta.apache.org
Re: Lucene 1.4.2?
Posted by Daniel Naber <da...@t-online.de>.
On Friday 01 October 2004 23:57, Doug Cutting wrote:
> The new release is up at http://jakarta.apache.org/lucene/.
Thanks, I will submit it to freshmeat.net tomorrow. Should I also announce
it on the mailing lists, as suggested at
http://nagoya.apache.org/wiki/apachewiki.cgi?ReleaseManager or do you want
to do that?
Too bad I found the first bug already: the CHANGES files describes the new
fuzzy syntax (e.g. fuzzy~0.7), but this isn't part of the release (i.e.
the QueryParser part of that feature is missing). Any chance to fix this
(i.e. change the CHANGES file, not the QueryParser). I guess we should
take more time for the next release.
Regards
Daniel
--
http://www.danielnaber.de
---------------------------------------------------------------------
To unsubscribe, e-mail: lucene-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: lucene-dev-help@jakarta.apache.org
Re: Lucene 1.4.2?
Posted by Erik Hatcher <er...@ehatchersolutions.com>.
On Oct 2, 2004, at 2:36 PM, Doug Cutting wrote:
> Daniel Naber wrote:
>> On Friday 01 October 2004 23:57, Doug Cutting wrote:
>>> It is not mirrored yet. Erik's the only one who has ever done that.
>>> Erik, do you have time to mirror 1.4.2? Thanks.
>> BTW, the release on the "official" download pages is still 1.4-final:
>> http://jakarta.apache.org/site/sourceindex.cgi
>> http://jakarta.apache.org/site/binindex.cgi
>
> Right. The official site is the mirrored site. The procedure for
> releasing to the mirror is documented at:
>
> http://jakarta.apache.org/site/convert-to-mirror.html
>
> Would someone else like to do this? Erik's been rather busy. If
> another comitter has the time, it would be great to get this done
> ASAP.
I just replied to Doug directly from a previous e-mail about the
release, and then read on as I'm digging out and caught this. I'm way
too swamped to get the release pushed out in a timely fashion right
now. It really shouldn't be too time consuming but I've not automated
the steps to sign all the files, so it takes me longer than it really
should.
Sorry for my weaker presence, however I have been hyping Lucene. Last
week I did a presentation at OSCOM in Zürich which was nicely attended
and received.
Erik
---------------------------------------------------------------------
To unsubscribe, e-mail: lucene-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: lucene-dev-help@jakarta.apache.org
Re: Lucene 1.4.2?
Posted by Doug Cutting <cu...@apache.org>.
Daniel Naber wrote:
> On Friday 01 October 2004 23:57, Doug Cutting wrote:
>>It is not mirrored yet. Erik's the only one who has ever done that.
>>Erik, do you have time to mirror 1.4.2? Thanks.
>
> BTW, the release on the "official" download pages is still 1.4-final:
> http://jakarta.apache.org/site/sourceindex.cgi
> http://jakarta.apache.org/site/binindex.cgi
Right. The official site is the mirrored site. The procedure for
releasing to the mirror is documented at:
http://jakarta.apache.org/site/convert-to-mirror.html
Would someone else like to do this? Erik's been rather busy. If
another comitter has the time, it would be great to get this done ASAP.
Doug
---------------------------------------------------------------------
To unsubscribe, e-mail: lucene-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: lucene-dev-help@jakarta.apache.org
Re: Lucene 1.4.2?
Posted by Otis Gospodnetic <ot...@yahoo.com>.
One person also sent an email about Lucene JAR files not being in some
directory on one of the ASF servers. This is preventing Maven users
from getting the newest Lucene JARs. I still have the email and I'll
forward it to lucene-dev so that whomever pushes the release to mirrors
can take care of this issue, too.
Otis
--- Daniel Naber <da...@t-online.de> wrote:
> On Friday 01 October 2004 23:57, Doug Cutting wrote:
>
> > It is not mirrored yet. Erik's the only one who has ever done
> that.
> > Erik, do you have time to mirror 1.4.2? Thanks.
>
> BTW, the release on the "official" download pages is still 1.4-final:
> http://jakarta.apache.org/site/sourceindex.cgi
> http://jakarta.apache.org/site/binindex.cgi
>
> Regards
> Daniel
>
> --
> http://www.danielnaber.de
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: lucene-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: lucene-dev-help@jakarta.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: lucene-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: lucene-dev-help@jakarta.apache.org
Re: Lucene 1.4.2?
Posted by Daniel Naber <da...@t-online.de>.
On Friday 01 October 2004 23:57, Doug Cutting wrote:
> It is not mirrored yet. Erik's the only one who has ever done that.
> Erik, do you have time to mirror 1.4.2? Thanks.
BTW, the release on the "official" download pages is still 1.4-final:
http://jakarta.apache.org/site/sourceindex.cgi
http://jakarta.apache.org/site/binindex.cgi
Regards
Daniel
--
http://www.danielnaber.de
---------------------------------------------------------------------
To unsubscribe, e-mail: lucene-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: lucene-dev-help@jakarta.apache.org
Re: Lucene 1.4.2?
Posted by Doug Cutting <cu...@apache.org>.
The new release is up at http://jakarta.apache.org/lucene/.
It is not mirrored yet. Erik's the only one who has ever done that.
Erik, do you have time to mirror 1.4.2? Thanks.
Doug
---------------------------------------------------------------------
To unsubscribe, e-mail: lucene-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: lucene-dev-help@jakarta.apache.org
Re: Lucene 1.4.2?
Posted by Christoph Goller <go...@detego-software.de>.
Doug Cutting wrote:
> Christoph Goller wrote:
>
>> Items 4 and 5 don't seem that important to me. As far as I am
>> concerned we can leave them out.
>
>
> When did 4 happen? Was it a rare or common problem?
Actually, nobody ever complained about it, so probably nobody ever
noticed it. I noticed it when Bernhard complained about disk space
requirements during indexing, what eventually lead to my patches
4 and 5.
>
> I agree that we don't need to put 5 in 1.4.2.
>
>> So the only thing missing is your
>> optimization. Then 1.4.2 should be ready.
>
>
> I just committed this. I can make a 1.4.2 release later today or Monday.
>
> Doug
---------------------------------------------------------------------
To unsubscribe, e-mail: lucene-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: lucene-dev-help@jakarta.apache.org
Re: Lucene 1.4.2?
Posted by Doug Cutting <cu...@apache.org>.
Christoph Goller wrote:
> Items 4 and 5 don't seem that important to me. As far as I am
> concerned we can leave them out.
When did 4 happen? Was it a rare or common problem?
I agree that we don't need to put 5 in 1.4.2.
> So the only thing missing is your
> optimization. Then 1.4.2 should be ready.
I just committed this. I can make a 1.4.2 release later today or Monday.
Doug
---------------------------------------------------------------------
To unsubscribe, e-mail: lucene-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: lucene-dev-help@jakarta.apache.org