You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/01/27 20:28:17 UTC
[GitHub] [iceberg-docs] samredai commented on a change in pull request #18: Adding Lottie and integrating lottie file reference into content front-matter
samredai commented on a change in pull request #18:
URL: https://github.com/apache/iceberg-docs/pull/18#discussion_r793973419
##########
File path: landing-page/content/services/data-compaction.html
##########
@@ -1,7 +1,8 @@
---
-Title: Time Travel
-AsciinemaCast: time_travel.cast
-Category: Post
+Title: Data Compaction
+Description: Data compaction is supported out-of-the-box and you can choose from different rewrite strategies such as bin-packing, sorting, or z-ordering to optimize file layout and size.
Review comment:
Ah ok, removed in [b033a57](https://github.com/apache/iceberg-docs/pull/18/commits/b033a571fdb082c317a5987ed1ec5705d3bdce6c)
##########
File path: landing-page/content/services/data-compaction.html
##########
@@ -1,7 +1,8 @@
---
-Title: Time Travel
-AsciinemaCast: time_travel.cast
-Category: Post
+Title: Data Compaction
+Description: Data compaction is supported out-of-the-box and you can choose from different rewrite strategies such as bin-packing, sorting, or z-ordering to optimize file layout and size.
+LottieFile: data-compaction-animation.json
Review comment:
Updated this to show:
```scala
CALL system.rewrite_data_files("nyc.taxis");
```
relevant commit: [b033a57](https://github.com/apache/iceberg-docs/pull/18/commits/b033a571fdb082c317a5987ed1ec5705d3bdce6c)
##########
File path: landing-page/content/services/row-level-deletes.html
##########
@@ -1,9 +1,11 @@
---
-Title: Schema Evolution
-AsciinemaCast: schema_evolution.cast
+Title: Row-level Deletes
+Description: Iceberg supports the copy-on-write and merge-on-read approaches to handle row-level delete operations.
+LottieFile: row-level-deletes-animation.json
Review comment:
Renamed this to "Expressive SQL" and used the code example below:
```
MERGE INTO prod.nyc.taxis pt
USING (SELECT * FROM staging.nyc.taxis) st
ON pt.id = st.id
WHEN NOT MATCHED THEN INSERT *;
```
relevant commit: [b92aebb](https://github.com/apache/iceberg-docs/pull/18/commits/b92aebb3e4550189467840c9c052e13295afc727)
##########
File path: landing-page/content/services/row-level-deletes.html
##########
@@ -1,9 +1,11 @@
---
-Title: Schema Evolution
-AsciinemaCast: schema_evolution.cast
+Title: Row-level Deletes
+Description: Iceberg supports the copy-on-write and merge-on-read approaches to handle row-level delete operations.
Review comment:
I like it, updated!
##########
File path: landing-page/content/services/hidden-partitioning.html
##########
@@ -1,6 +1,8 @@
---
Title: Hidden Partitioning
-Img: partition-spec-evolution.png
+Description: Iceberg handles the tedious and error-prone task of producing partition values for rows in a table and avoids reading unnecessary partitions automatically. Consumers don’t need to know how the table is partitioned or add extra filters to their queries and the partition layouts can evolve as needed.
Review comment:
Fixed! Relevant commit [fea5ec9](https://github.com/apache/iceberg-docs/pull/18/commits/fea5ec9862883a725a7b7d0e5385281d975b8c15)
##########
File path: landing-page/content/services/schema-evolution.html
##########
@@ -0,0 +1,38 @@
+---
+Title: Full Schema Evolution
+Description: Iceberg avoids unpleasant surprises. Schema evolution just works with no "zombie" columns and no un-deleted data when adding columns with previously existing names.
+LearnMore: /docs/latest/evolution/
+Category: Services
+Draft: false
+weight: 100
+---
+<!--
+ - Licensed to the Apache Software Foundation (ASF) under one or more
+ - contributor license agreements. See the NOTICE file distributed with
+ - this work for additional information regarding copyright ownership.
+ - The ASF licenses this file to You under the Apache License, Version 2.0
+ - (the "License"); you may not use this file except in compliance with
+ - the License. You may obtain a copy of the License at
+ -
+ - http://www.apache.org/licenses/LICENSE-2.0
+ -
+ - Unless required by applicable law or agreed to in writing, software
+ - distributed under the License is distributed on an "AS IS" BASIS,
+ - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ - See the License for the specific language governing permissions and
+ - limitations under the License.
+ -->
+<div id="termynal" data-termynal data-ty-startDelay="600" data-ty-typeDelay="20" data-ty-lineDelay="500">
+ <span data-ty="input" data-ty-cursor="▋" data-ty-prompt="spark-sql>">ALTER TABLE taxis</span>
+ <span data-ty="input" data-ty-cursor="▋" data-ty-prompt="">ALTER COLUMN trip_distance</span>
+ <span data-ty="input" data-ty-cursor="▋" data-ty-prompt="" data-ty-delay="2500">TYPE double;</span>
+ <span data-ty>Time taken: 2.594 seconds</span>
+ <span data-ty="input" data-ty-cursor="▋" data-ty-prompt="spark-sql>">ALTER TABLE taxis</span>
+ <span data-ty="input" data-ty-cursor="▋" data-ty-prompt="">ALTER COLUMN trip_distance</span>
+ <span data-ty="input" data-ty-cursor="▋" data-ty-prompt="">COMMENT ‘The elapsed trip distance in miles reported by the taximeter.’;</span>
+ <span data-ty>Time taken: 0.464 seconds</span>
Review comment:
You're right, the column reorder should definitely be shown here. I updated the second query to be:
```
ALTER TABLE taxis
ALTER COLUMN trip_distance
AFTER fare;
```
relevant commit: [046de22](https://github.com/apache/iceberg-docs/pull/18/commits/046de2214974045f999b2d7f55527fe9c5aa1bfd)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org