[GitHub] [kyuubi] bowenliang123 commented on a diff in pull request #4166: Eliminate unhelpful warning messages in Javac output of building and testing

[GitBox <gi...@apache.org>]

bowenliang123 commented on code in PR #4166:
URL: https://github.com/apache/kyuubi/pull/4166#discussion_r1070788425


##########
kyuubi-hive-jdbc/src/main/java/org/apache/kyuubi/jdbc/hive/KyuubiArrowBasedResultSet.java:
##########
@@ -34,6 +34,7 @@
 import org.apache.kyuubi.jdbc.hive.arrow.ArrowUtils;
 
 /** Data independent base class which implements the common part of all Kyuubi result sets. */
+@SuppressWarnings("deprecation")
 public abstract class KyuubiArrowBasedResultSet implements SQLResultSet {

Review Comment:
   As `KyuubiArrowBasedResultSet` implements the deprecated method `getBigDecimal(int columnIndex, int scale` of `ResultSet` interface,
   ```
       @Deprecated
       BigDecimal getBigDecimal(int columnIndex, int scale) throws SQLException;
   ```
   
   And we are getting warning when compiling `KyuubiArrowBasedResultSet`
   ```
   Warning:  /home/runner/work/kyuubi/kyuubi/kyuubi-hive-jdbc/src/main/java/org/apache/kyuubi/jdbc/hive/KyuubiArrowBasedResultSet.java:[106,20] [deprecation] getBigDecimal(String,int) in ResultSet has been deprecated
   ```
   
   Similar reasons for adding `@SuppressWarnings("deprecation")` on classes in this PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org