[GitHub] [spark] beliefer commented on a diff in pull request #37458: [SPARK-40028][SQL] Add binary examples for string expressions

[GitBox <gi...@apache.org>]

beliefer commented on code in PR #37458:
URL: https://github.com/apache/spark/pull/37458#discussion_r942071177


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala:
##########
@@ -1855,16 +1885,28 @@ case class StringSpace(child: Expression)
     Examples:
       > SELECT _FUNC_('Spark SQL', 5);
        k SQL
+      > SELECT _FUNC_(encode('Spark SQL', 'utf-8'), 5);

Review Comment:
   This PR follows up other string expressions with binary examples.
   Of course, I have no objection to keeping only one or two examples for binary.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org