You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@sling.apache.org by fm...@apache.org on 2008/01/29 14:39:34 UTC

svn commit: r616309 - /incubator/sling/trunk/jcr/resource/src/main/java/org/apache/sling/jcr/resource/internal/helper/ResourcePathIterator.java

Author: fmeschbe
Date: Tue Jan 29 05:39:33 2008
New Revision: 616309

URL: http://svn.apache.org/viewvc?rev=616309&view=rev
Log:
No need to keep the httpMethod in a field and use defined constant
for GET and HEAD method names.

Modified:
    incubator/sling/trunk/jcr/resource/src/main/java/org/apache/sling/jcr/resource/internal/helper/ResourcePathIterator.java

Modified: incubator/sling/trunk/jcr/resource/src/main/java/org/apache/sling/jcr/resource/internal/helper/ResourcePathIterator.java
URL: http://svn.apache.org/viewvc/incubator/sling/trunk/jcr/resource/src/main/java/org/apache/sling/jcr/resource/internal/helper/ResourcePathIterator.java?rev=616309&r1=616308&r2=616309&view=diff
==============================================================================
--- incubator/sling/trunk/jcr/resource/src/main/java/org/apache/sling/jcr/resource/internal/helper/ResourcePathIterator.java (original)
+++ incubator/sling/trunk/jcr/resource/src/main/java/org/apache/sling/jcr/resource/internal/helper/ResourcePathIterator.java Tue Jan 29 05:39:33 2008
@@ -19,6 +19,8 @@
 import java.util.Iterator;
 import java.util.NoSuchElementException;
 
+import org.apache.sling.api.servlets.HttpConstants;
+
 /**
  * Iterate over the the HTTP request path by creating shorter segments of that
  * path using "." and "/" as separators.
@@ -42,15 +44,14 @@
 public class ResourcePathIterator implements Iterator<String> {
 
     private String nextPath;
-    private final String httpMethod;
     private final int smallestBreakPos;
 
     public ResourcePathIterator(String path, String httpMethod) {
-        this.httpMethod = httpMethod;
 
         // For GET or HEAD requests, path can only be split after
         // the last slash (SLING-179)
-        final boolean getOrHead = "GET".equals(httpMethod) || "HEAD".equals(httpMethod);
+        final boolean getOrHead = HttpConstants.METHOD_GET.equals(httpMethod)
+            || HttpConstants.METHOD_HEAD.equals(httpMethod);
         smallestBreakPos = getOrHead ? path.lastIndexOf('/') : 0; 
             
         if (path != null) {