[GitHub] [pinot] kishoreg commented on pull request #7442: ban prefix increment

[GitBox <gi...@apache.org>]

kishoreg commented on pull request #7442:
URL: https://github.com/apache/pinot/pull/7442#issuecomment-934909659


   @amrishlal While we can continue to discuss further on if this rule is good or bad, I don't think its worth our time or your time.
   
   @richardstartin did not introduce this rule. We already have this as part of the coding convention in Pinot. What he is trying to do is codify that in check style so that the build catches it instead of relying on the reviewer to catch it. 
   
   If you really want to change the convention that is used since the start of the project, I encourage you to create another issue or discussion thread.
   
   Let's move on. We have so many other things to fix/improve in Pinot.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org