You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Saksham Srivastava <sa...@citrix.com> on 2013/05/09 10:36:51 UTC
Fix for CLOUDSTACK-2277
Hi Mice ,
I just saw your commit for
https://issues.apache.org/jira/browse/CLOUDSTACK-2277
So I recently picked this bug, marked it as "in progress" as I was
working on it and was about to submit the patch for the same, but then I
saw that you already fixed it :)
A quick comment :
The fix makes sure that if vm-tools are not running on the vm,
add/remove nic fails.
What I have observed is that if vm-tools are not running, a reboot of
the vm will actually show up the added NIC. IMO we should allow the api
to pass, but provide a log message that reboot of vm will be required
for added NIC to show up, rather than completely failing the api.
Your thoughts ?
Thanks,
Saksham
Re: Fix for CLOUDSTACK-2277
Posted by Mice Xia <we...@gmail.com>.
I agree with you, provide message to user for adding case
Regards
Mice
On Thu, May 9, 2013 at 6:41 PM, Saksham Srivastava <
saksham.srivastava@citrix.com> wrote:
> Mice, no need to revert. I also had similar issues that the NIC was
> present even after reboot.
> May be we need to look into the difference in behavior.
> But for now, I guess at-least the add api must be allowed to pass.
> Your thoughts?
>
> Thanks,
> Saksham
>
> On Thursday 09 May 2013 02:37 PM, Mice Xia wrote:
> > Saksham,
> >
> > Really sorry I didn’t notice it's in progress until I pushed the
> commit.. I can revert it if necessary.
> >
> > Yes, without vmtool, a reboot of the VM can bring up the added NIC, but
> removing NIC fails in my environment, the nic is still there even after a
> reboot, can you confirm it in your env?
> >
> > Regards
> > Mice
> >
> > -----Original Message-----
> > From: Saksham Srivastava [mailto:saksham.srivastava@citrix.com]
> > Sent: Thursday, May 09, 2013 4:37 PM
> > To: Mice Xia; dev@cloudstack.apache.org
> > Subject: Fix for CLOUDSTACK-2277
> >
> > Hi Mice ,
> >
> > I just saw your commit for
> > https://issues.apache.org/jira/browse/CLOUDSTACK-2277
> > So I recently picked this bug, marked it as "in progress" as I was
> working on it and was about to submit the patch for the same, but then I
> saw that you already fixed it :)
> >
> > A quick comment :
> > The fix makes sure that if vm-tools are not running on the vm,
> add/remove nic fails.
> > What I have observed is that if vm-tools are not running, a reboot of
> the vm will actually show up the added NIC. IMO we should allow the api to
> pass, but provide a log message that reboot of vm will be required for
> added NIC to show up, rather than completely failing the api.
> >
> > Your thoughts ?
> >
> > Thanks,
> > Saksham
>
Re: Fix for CLOUDSTACK-2277
Posted by Saksham Srivastava <sa...@citrix.com>.
Mice, no need to revert. I also had similar issues that the NIC was
present even after reboot.
May be we need to look into the difference in behavior.
But for now, I guess at-least the add api must be allowed to pass.
Your thoughts?
Thanks,
Saksham
On Thursday 09 May 2013 02:37 PM, Mice Xia wrote:
> Saksham,
>
> Really sorry I didn’t notice it's in progress until I pushed the commit.. I can revert it if necessary.
>
> Yes, without vmtool, a reboot of the VM can bring up the added NIC, but removing NIC fails in my environment, the nic is still there even after a reboot, can you confirm it in your env?
>
> Regards
> Mice
>
> -----Original Message-----
> From: Saksham Srivastava [mailto:saksham.srivastava@citrix.com]
> Sent: Thursday, May 09, 2013 4:37 PM
> To: Mice Xia; dev@cloudstack.apache.org
> Subject: Fix for CLOUDSTACK-2277
>
> Hi Mice ,
>
> I just saw your commit for
> https://issues.apache.org/jira/browse/CLOUDSTACK-2277
> So I recently picked this bug, marked it as "in progress" as I was working on it and was about to submit the patch for the same, but then I saw that you already fixed it :)
>
> A quick comment :
> The fix makes sure that if vm-tools are not running on the vm, add/remove nic fails.
> What I have observed is that if vm-tools are not running, a reboot of the vm will actually show up the added NIC. IMO we should allow the api to pass, but provide a log message that reboot of vm will be required for added NIC to show up, rather than completely failing the api.
>
> Your thoughts ?
>
> Thanks,
> Saksham
RE: Fix for CLOUDSTACK-2277
Posted by Mice Xia <mi...@tcloudcomputing.com>.
Saksham,
Really sorry I didn’t notice it's in progress until I pushed the commit.. I can revert it if necessary.
Yes, without vmtool, a reboot of the VM can bring up the added NIC, but removing NIC fails in my environment, the nic is still there even after a reboot, can you confirm it in your env?
Regards
Mice
-----Original Message-----
From: Saksham Srivastava [mailto:saksham.srivastava@citrix.com]
Sent: Thursday, May 09, 2013 4:37 PM
To: Mice Xia; dev@cloudstack.apache.org
Subject: Fix for CLOUDSTACK-2277
Hi Mice ,
I just saw your commit for
https://issues.apache.org/jira/browse/CLOUDSTACK-2277
So I recently picked this bug, marked it as "in progress" as I was working on it and was about to submit the patch for the same, but then I saw that you already fixed it :)
A quick comment :
The fix makes sure that if vm-tools are not running on the vm, add/remove nic fails.
What I have observed is that if vm-tools are not running, a reboot of the vm will actually show up the added NIC. IMO we should allow the api to pass, but provide a log message that reboot of vm will be required for added NIC to show up, rather than completely failing the api.
Your thoughts ?
Thanks,
Saksham