You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Dmitriy Matveev (JIRA)" <ji...@apache.org> on 2007/09/07 16:49:30 UTC

[jira] Created: (HARMONY-4761) [classlib][awt] InputEvent.getModifiers() doesn't return modifiers for mouse release event

[classlib][awt] InputEvent.getModifiers() doesn't return modifiers for mouse release event
------------------------------------------------------------------------------------------

                 Key: HARMONY-4761
                 URL: https://issues.apache.org/jira/browse/HARMONY-4761
             Project: Harmony
          Issue Type: Bug
          Components: Classlib
         Environment: Windows
            Reporter: Dmitriy Matveev


Reproducer:

import java.awt.Frame;
import java.awt.Graphics;
import java.awt.Graphics2D;
import java.awt.event.MouseEvent;
import java.awt.event.MouseListener;
import java.awt.event.WindowAdapter;
import java.awt.event.WindowEvent;

public class MouseReleaseTest {

    public static void main(String[] args) {
        Frame f = new Frame();
        f.setBounds(0, 0, 800, 600);
        f.setVisible(true);

        f.addWindowListener(new WindowAdapter() {

            public void windowClosing(WindowEvent ev) {
                System.exit(0);
            }
        });
        
        f.addMouseListener(new MouseListener(){
            public void mouseReleased(MouseEvent e){
                System.out.println(e);
            }

            public void mouseClicked(MouseEvent e) { }

            public void mouseEntered(MouseEvent e) { }

            public void mouseExited(MouseEvent e) { }

            public void mousePressed(MouseEvent e) { }
        });
    }

}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-4761) [classlib][awt] InputEvent.getModifiers() doesn't return modifiers for mouse release event

Posted by "Andrey Pavlenko (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-4761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12529030 ] 

Andrey Pavlenko commented on HARMONY-4761:
------------------------------------------

Alexey, I tried this patch on my laptop with WinXP, remote Win2003 server and remote SLES 9 - it doesn't fail...

> [classlib][awt] InputEvent.getModifiers() doesn't return modifiers for mouse release event
> ------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-4761
>                 URL: https://issues.apache.org/jira/browse/HARMONY-4761
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>         Environment: Windows
>            Reporter: Dmitriy Matveev
>            Assignee: Alexey Petrenko
>         Attachments: HARMONY-4761-MouseEventTest.patch, HARMONY-4761-MouseEventTest.patch, HARMONY-4761-WinEvent.patch
>
>
> Reproducer:
> import java.awt.Frame;
> import java.awt.Graphics;
> import java.awt.Graphics2D;
> import java.awt.event.MouseEvent;
> import java.awt.event.MouseListener;
> import java.awt.event.WindowAdapter;
> import java.awt.event.WindowEvent;
> public class MouseReleaseTest {
>     public static void main(String[] args) {
>         Frame f = new Frame();
>         f.setBounds(0, 0, 800, 600);
>         f.setVisible(true);
>         f.addWindowListener(new WindowAdapter() {
>             public void windowClosing(WindowEvent ev) {
>                 System.exit(0);
>             }
>         });
>         
>         f.addMouseListener(new MouseListener(){
>             public void mouseReleased(MouseEvent e){
>                 System.out.println(e);
>             }
>             public void mouseClicked(MouseEvent e) { }
>             public void mouseEntered(MouseEvent e) { }
>             public void mouseExited(MouseEvent e) { }
>             public void mousePressed(MouseEvent e) { }
>         });
>     }
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-4761) [classlib][awt] InputEvent.getModifiers() doesn't return modifiers for mouse release event

Posted by "Andrey Pavlenko (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-4761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrey Pavlenko updated HARMONY-4761:
-------------------------------------

    Attachment:     (was: HARMONY-4761-WinEvent.patch)

> [classlib][awt] InputEvent.getModifiers() doesn't return modifiers for mouse release event
> ------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-4761
>                 URL: https://issues.apache.org/jira/browse/HARMONY-4761
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>         Environment: Windows
>            Reporter: Dmitriy Matveev
>            Assignee: Alexey Petrenko
>         Attachments: HARMONY-4761-ModifiersProcessing.patch, HARMONY-4761-ModifiersProcessingTest.patch, HARMONY-4761-MouseEventTest.patch
>
>
> Reproducer:
> import java.awt.Frame;
> import java.awt.Graphics;
> import java.awt.Graphics2D;
> import java.awt.event.MouseEvent;
> import java.awt.event.MouseListener;
> import java.awt.event.WindowAdapter;
> import java.awt.event.WindowEvent;
> public class MouseReleaseTest {
>     public static void main(String[] args) {
>         Frame f = new Frame();
>         f.setBounds(0, 0, 800, 600);
>         f.setVisible(true);
>         f.addWindowListener(new WindowAdapter() {
>             public void windowClosing(WindowEvent ev) {
>                 System.exit(0);
>             }
>         });
>         
>         f.addMouseListener(new MouseListener(){
>             public void mouseReleased(MouseEvent e){
>                 System.out.println(e);
>             }
>             public void mouseClicked(MouseEvent e) { }
>             public void mouseEntered(MouseEvent e) { }
>             public void mouseExited(MouseEvent e) { }
>             public void mousePressed(MouseEvent e) { }
>         });
>     }
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-4761) [classlib][awt] InputEvent.getModifiers() doesn't return modifiers for mouse release event

Posted by "Andrey Pavlenko (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-4761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrey Pavlenko updated HARMONY-4761:
-------------------------------------

    Attachment: HARMONY-4761-MouseEventTest.patch

> [classlib][awt] InputEvent.getModifiers() doesn't return modifiers for mouse release event
> ------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-4761
>                 URL: https://issues.apache.org/jira/browse/HARMONY-4761
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>         Environment: Windows
>            Reporter: Dmitriy Matveev
>            Assignee: Alexey Petrenko
>         Attachments: HARMONY-4761-MouseEventTest.patch, HARMONY-4761-WinEvent.patch
>
>
> Reproducer:
> import java.awt.Frame;
> import java.awt.Graphics;
> import java.awt.Graphics2D;
> import java.awt.event.MouseEvent;
> import java.awt.event.MouseListener;
> import java.awt.event.WindowAdapter;
> import java.awt.event.WindowEvent;
> public class MouseReleaseTest {
>     public static void main(String[] args) {
>         Frame f = new Frame();
>         f.setBounds(0, 0, 800, 600);
>         f.setVisible(true);
>         f.addWindowListener(new WindowAdapter() {
>             public void windowClosing(WindowEvent ev) {
>                 System.exit(0);
>             }
>         });
>         
>         f.addMouseListener(new MouseListener(){
>             public void mouseReleased(MouseEvent e){
>                 System.out.println(e);
>             }
>             public void mouseClicked(MouseEvent e) { }
>             public void mouseEntered(MouseEvent e) { }
>             public void mouseExited(MouseEvent e) { }
>             public void mousePressed(MouseEvent e) { }
>         });
>     }
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (HARMONY-4761) [classlib][awt] InputEvent.getModifiers() doesn't return modifiers for mouse release event

Posted by "Alexey Petrenko (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-4761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexey Petrenko reassigned HARMONY-4761:
----------------------------------------

    Assignee: Alexey Petrenko

> [classlib][awt] InputEvent.getModifiers() doesn't return modifiers for mouse release event
> ------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-4761
>                 URL: https://issues.apache.org/jira/browse/HARMONY-4761
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>         Environment: Windows
>            Reporter: Dmitriy Matveev
>            Assignee: Alexey Petrenko
>         Attachments: HARMONY-4761-WinEvent.patch
>
>
> Reproducer:
> import java.awt.Frame;
> import java.awt.Graphics;
> import java.awt.Graphics2D;
> import java.awt.event.MouseEvent;
> import java.awt.event.MouseListener;
> import java.awt.event.WindowAdapter;
> import java.awt.event.WindowEvent;
> public class MouseReleaseTest {
>     public static void main(String[] args) {
>         Frame f = new Frame();
>         f.setBounds(0, 0, 800, 600);
>         f.setVisible(true);
>         f.addWindowListener(new WindowAdapter() {
>             public void windowClosing(WindowEvent ev) {
>                 System.exit(0);
>             }
>         });
>         
>         f.addMouseListener(new MouseListener(){
>             public void mouseReleased(MouseEvent e){
>                 System.out.println(e);
>             }
>             public void mouseClicked(MouseEvent e) { }
>             public void mouseEntered(MouseEvent e) { }
>             public void mouseExited(MouseEvent e) { }
>             public void mousePressed(MouseEvent e) { }
>         });
>     }
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-4761) [classlib][awt] InputEvent.getModifiers() doesn't return modifiers for mouse release event

Posted by "Andrey Pavlenko (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-4761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrey Pavlenko updated HARMONY-4761:
-------------------------------------

    Attachment: HARMONY-4761-WinEvent.patch

It looks like the issue is in the method WinEvent.translateMouseModifiers(). According to MSDN wParam does not contain information about released butons, so we have modifiers == 0. Please try this patch, it seems  fixes the issue.

> [classlib][awt] InputEvent.getModifiers() doesn't return modifiers for mouse release event
> ------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-4761
>                 URL: https://issues.apache.org/jira/browse/HARMONY-4761
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>         Environment: Windows
>            Reporter: Dmitriy Matveev
>         Attachments: HARMONY-4761-WinEvent.patch
>
>
> Reproducer:
> import java.awt.Frame;
> import java.awt.Graphics;
> import java.awt.Graphics2D;
> import java.awt.event.MouseEvent;
> import java.awt.event.MouseListener;
> import java.awt.event.WindowAdapter;
> import java.awt.event.WindowEvent;
> public class MouseReleaseTest {
>     public static void main(String[] args) {
>         Frame f = new Frame();
>         f.setBounds(0, 0, 800, 600);
>         f.setVisible(true);
>         f.addWindowListener(new WindowAdapter() {
>             public void windowClosing(WindowEvent ev) {
>                 System.exit(0);
>             }
>         });
>         
>         f.addMouseListener(new MouseListener(){
>             public void mouseReleased(MouseEvent e){
>                 System.out.println(e);
>             }
>             public void mouseClicked(MouseEvent e) { }
>             public void mouseEntered(MouseEvent e) { }
>             public void mouseExited(MouseEvent e) { }
>             public void mousePressed(MouseEvent e) { }
>         });
>     }
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-4761) [classlib][awt] InputEvent.getModifiers() doesn't return modifiers for mouse release event

Posted by "Andrey Pavlenko (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-4761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12535837 ] 

Andrey Pavlenko commented on HARMONY-4761:
------------------------------------------

It looks like the applied fix is incomplete. Please see HARMONY-4945 for more details. Also it might cause a degradation. I think the applied patch should be reverted. I'll create a new fix covering both HARMONY-4761 and HARMONY-4945.

> [classlib][awt] InputEvent.getModifiers() doesn't return modifiers for mouse release event
> ------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-4761
>                 URL: https://issues.apache.org/jira/browse/HARMONY-4761
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>         Environment: Windows
>            Reporter: Dmitriy Matveev
>            Assignee: Alexey Petrenko
>         Attachments: HARMONY-4761-MouseEventTest.patch, HARMONY-4761-MouseEventTest.patch, HARMONY-4761-WinEvent.patch
>
>
> Reproducer:
> import java.awt.Frame;
> import java.awt.Graphics;
> import java.awt.Graphics2D;
> import java.awt.event.MouseEvent;
> import java.awt.event.MouseListener;
> import java.awt.event.WindowAdapter;
> import java.awt.event.WindowEvent;
> public class MouseReleaseTest {
>     public static void main(String[] args) {
>         Frame f = new Frame();
>         f.setBounds(0, 0, 800, 600);
>         f.setVisible(true);
>         f.addWindowListener(new WindowAdapter() {
>             public void windowClosing(WindowEvent ev) {
>                 System.exit(0);
>             }
>         });
>         
>         f.addMouseListener(new MouseListener(){
>             public void mouseReleased(MouseEvent e){
>                 System.out.println(e);
>             }
>             public void mouseClicked(MouseEvent e) { }
>             public void mouseEntered(MouseEvent e) { }
>             public void mouseExited(MouseEvent e) { }
>             public void mousePressed(MouseEvent e) { }
>         });
>     }
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-4761) [classlib][awt] InputEvent.getModifiers() doesn't return modifiers for mouse release event

Posted by "Andrey Pavlenko (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-4761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrey Pavlenko updated HARMONY-4761:
-------------------------------------

    Attachment:     (was: HARMONY-4761-MouseEventTest.patch)

> [classlib][awt] InputEvent.getModifiers() doesn't return modifiers for mouse release event
> ------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-4761
>                 URL: https://issues.apache.org/jira/browse/HARMONY-4761
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>         Environment: Windows
>            Reporter: Dmitriy Matveev
>            Assignee: Alexey Petrenko
>         Attachments: HARMONY-4761-ModifiersProcessing.patch, HARMONY-4761-ModifiersProcessingTest.patch, HARMONY-4761-MouseEventTest.patch
>
>
> Reproducer:
> import java.awt.Frame;
> import java.awt.Graphics;
> import java.awt.Graphics2D;
> import java.awt.event.MouseEvent;
> import java.awt.event.MouseListener;
> import java.awt.event.WindowAdapter;
> import java.awt.event.WindowEvent;
> public class MouseReleaseTest {
>     public static void main(String[] args) {
>         Frame f = new Frame();
>         f.setBounds(0, 0, 800, 600);
>         f.setVisible(true);
>         f.addWindowListener(new WindowAdapter() {
>             public void windowClosing(WindowEvent ev) {
>                 System.exit(0);
>             }
>         });
>         
>         f.addMouseListener(new MouseListener(){
>             public void mouseReleased(MouseEvent e){
>                 System.out.println(e);
>             }
>             public void mouseClicked(MouseEvent e) { }
>             public void mouseEntered(MouseEvent e) { }
>             public void mouseExited(MouseEvent e) { }
>             public void mousePressed(MouseEvent e) { }
>         });
>     }
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-4761) [classlib][awt] InputEvent.getModifiers() doesn't return modifiers for mouse release event

Posted by "Andrey Pavlenko (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-4761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrey Pavlenko updated HARMONY-4761:
-------------------------------------

    Attachment: HARMONY-4761-MouseEventTest.patch

It works fine for me... I think the test could fail because delay in 500ms is not enough. Please try this patch with increased delay to 1000ms. 

> [classlib][awt] InputEvent.getModifiers() doesn't return modifiers for mouse release event
> ------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-4761
>                 URL: https://issues.apache.org/jira/browse/HARMONY-4761
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>         Environment: Windows
>            Reporter: Dmitriy Matveev
>            Assignee: Alexey Petrenko
>         Attachments: HARMONY-4761-MouseEventTest.patch, HARMONY-4761-MouseEventTest.patch, HARMONY-4761-WinEvent.patch
>
>
> Reproducer:
> import java.awt.Frame;
> import java.awt.Graphics;
> import java.awt.Graphics2D;
> import java.awt.event.MouseEvent;
> import java.awt.event.MouseListener;
> import java.awt.event.WindowAdapter;
> import java.awt.event.WindowEvent;
> public class MouseReleaseTest {
>     public static void main(String[] args) {
>         Frame f = new Frame();
>         f.setBounds(0, 0, 800, 600);
>         f.setVisible(true);
>         f.addWindowListener(new WindowAdapter() {
>             public void windowClosing(WindowEvent ev) {
>                 System.exit(0);
>             }
>         });
>         
>         f.addMouseListener(new MouseListener(){
>             public void mouseReleased(MouseEvent e){
>                 System.out.println(e);
>             }
>             public void mouseClicked(MouseEvent e) { }
>             public void mouseEntered(MouseEvent e) { }
>             public void mouseExited(MouseEvent e) { }
>             public void mousePressed(MouseEvent e) { }
>         });
>     }
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-4761) [classlib][awt] InputEvent.getModifiers() doesn't return modifiers for mouse release event

Posted by "Andrey Pavlenko (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-4761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrey Pavlenko updated HARMONY-4761:
-------------------------------------

    Attachment: HARMONY-4761-ModifiersProcessingTest.patch
                HARMONY-4761-ModifiersProcessing.patch

I've played with RI and found many differences with Harmony in key/mouse modifiers processing. I've reimplemented event processing in  3 classes - InputEvent, MouseEvent and KeyEvent. Now I don't see differences with RI in modifiers processing, but there is no guarantee that Harmony's behavior is  the same as RI's because it's not well documented. Also I modified some tests and added additional tests to MouseEventTest.
If no one objects I'll apply these patches. 

> [classlib][awt] InputEvent.getModifiers() doesn't return modifiers for mouse release event
> ------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-4761
>                 URL: https://issues.apache.org/jira/browse/HARMONY-4761
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>         Environment: Windows
>            Reporter: Dmitriy Matveev
>            Assignee: Alexey Petrenko
>         Attachments: HARMONY-4761-ModifiersProcessing.patch, HARMONY-4761-ModifiersProcessingTest.patch, HARMONY-4761-MouseEventTest.patch
>
>
> Reproducer:
> import java.awt.Frame;
> import java.awt.Graphics;
> import java.awt.Graphics2D;
> import java.awt.event.MouseEvent;
> import java.awt.event.MouseListener;
> import java.awt.event.WindowAdapter;
> import java.awt.event.WindowEvent;
> public class MouseReleaseTest {
>     public static void main(String[] args) {
>         Frame f = new Frame();
>         f.setBounds(0, 0, 800, 600);
>         f.setVisible(true);
>         f.addWindowListener(new WindowAdapter() {
>             public void windowClosing(WindowEvent ev) {
>                 System.exit(0);
>             }
>         });
>         
>         f.addMouseListener(new MouseListener(){
>             public void mouseReleased(MouseEvent e){
>                 System.out.println(e);
>             }
>             public void mouseClicked(MouseEvent e) { }
>             public void mouseEntered(MouseEvent e) { }
>             public void mouseExited(MouseEvent e) { }
>             public void mousePressed(MouseEvent e) { }
>         });
>     }
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-4761) [classlib][awt] InputEvent.getModifiers() doesn't return modifiers for mouse release event

Posted by "Alexey Petrenko (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-4761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12529040 ] 

Alexey Petrenko commented on HARMONY-4761:
------------------------------------------

Yes, it works ok on my notebook with original delay...

> [classlib][awt] InputEvent.getModifiers() doesn't return modifiers for mouse release event
> ------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-4761
>                 URL: https://issues.apache.org/jira/browse/HARMONY-4761
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>         Environment: Windows
>            Reporter: Dmitriy Matveev
>            Assignee: Alexey Petrenko
>         Attachments: HARMONY-4761-MouseEventTest.patch, HARMONY-4761-MouseEventTest.patch, HARMONY-4761-WinEvent.patch
>
>
> Reproducer:
> import java.awt.Frame;
> import java.awt.Graphics;
> import java.awt.Graphics2D;
> import java.awt.event.MouseEvent;
> import java.awt.event.MouseListener;
> import java.awt.event.WindowAdapter;
> import java.awt.event.WindowEvent;
> public class MouseReleaseTest {
>     public static void main(String[] args) {
>         Frame f = new Frame();
>         f.setBounds(0, 0, 800, 600);
>         f.setVisible(true);
>         f.addWindowListener(new WindowAdapter() {
>             public void windowClosing(WindowEvent ev) {
>                 System.exit(0);
>             }
>         });
>         
>         f.addMouseListener(new MouseListener(){
>             public void mouseReleased(MouseEvent e){
>                 System.out.println(e);
>             }
>             public void mouseClicked(MouseEvent e) { }
>             public void mouseEntered(MouseEvent e) { }
>             public void mouseExited(MouseEvent e) { }
>             public void mousePressed(MouseEvent e) { }
>         });
>     }
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-4761) [classlib][awt] InputEvent.getModifiers() doesn't return modifiers for mouse release event

Posted by "Alexey Petrenko (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-4761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12528806 ] 

Alexey Petrenko commented on HARMONY-4761:
------------------------------------------

Andrey,

the updated test fails for me with the patch and without me.

> [classlib][awt] InputEvent.getModifiers() doesn't return modifiers for mouse release event
> ------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-4761
>                 URL: https://issues.apache.org/jira/browse/HARMONY-4761
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>         Environment: Windows
>            Reporter: Dmitriy Matveev
>            Assignee: Alexey Petrenko
>         Attachments: HARMONY-4761-MouseEventTest.patch, HARMONY-4761-WinEvent.patch
>
>
> Reproducer:
> import java.awt.Frame;
> import java.awt.Graphics;
> import java.awt.Graphics2D;
> import java.awt.event.MouseEvent;
> import java.awt.event.MouseListener;
> import java.awt.event.WindowAdapter;
> import java.awt.event.WindowEvent;
> public class MouseReleaseTest {
>     public static void main(String[] args) {
>         Frame f = new Frame();
>         f.setBounds(0, 0, 800, 600);
>         f.setVisible(true);
>         f.addWindowListener(new WindowAdapter() {
>             public void windowClosing(WindowEvent ev) {
>                 System.exit(0);
>             }
>         });
>         
>         f.addMouseListener(new MouseListener(){
>             public void mouseReleased(MouseEvent e){
>                 System.out.println(e);
>             }
>             public void mouseClicked(MouseEvent e) { }
>             public void mouseEntered(MouseEvent e) { }
>             public void mouseExited(MouseEvent e) { }
>             public void mousePressed(MouseEvent e) { }
>         });
>     }
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-4761) [classlib][awt] InputEvent.getModifiers() doesn't return modifiers for mouse release event

Posted by "Alexey Petrenko (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-4761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexey Petrenko updated HARMONY-4761:
-------------------------------------

    Patch Info: [Patch Available]

> [classlib][awt] InputEvent.getModifiers() doesn't return modifiers for mouse release event
> ------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-4761
>                 URL: https://issues.apache.org/jira/browse/HARMONY-4761
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>         Environment: Windows
>            Reporter: Dmitriy Matveev
>            Assignee: Alexey Petrenko
>         Attachments: HARMONY-4761-MouseEventTest.patch, HARMONY-4761-WinEvent.patch
>
>
> Reproducer:
> import java.awt.Frame;
> import java.awt.Graphics;
> import java.awt.Graphics2D;
> import java.awt.event.MouseEvent;
> import java.awt.event.MouseListener;
> import java.awt.event.WindowAdapter;
> import java.awt.event.WindowEvent;
> public class MouseReleaseTest {
>     public static void main(String[] args) {
>         Frame f = new Frame();
>         f.setBounds(0, 0, 800, 600);
>         f.setVisible(true);
>         f.addWindowListener(new WindowAdapter() {
>             public void windowClosing(WindowEvent ev) {
>                 System.exit(0);
>             }
>         });
>         
>         f.addMouseListener(new MouseListener(){
>             public void mouseReleased(MouseEvent e){
>                 System.out.println(e);
>             }
>             public void mouseClicked(MouseEvent e) { }
>             public void mouseEntered(MouseEvent e) { }
>             public void mouseExited(MouseEvent e) { }
>             public void mousePressed(MouseEvent e) { }
>         });
>     }
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-4761) [classlib][awt] InputEvent.getModifiers() doesn't return modifiers for mouse release event

Posted by "Alexey Petrenko (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-4761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12529027 ] 

Alexey Petrenko commented on HARMONY-4761:
------------------------------------------

I've changed value to 1500 and it does not help.
I'm testing it on remote W2003 server. I'll try on my notebook. But even if it will work on notebook the test does not looks stable enough to include it to repository.

> [classlib][awt] InputEvent.getModifiers() doesn't return modifiers for mouse release event
> ------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-4761
>                 URL: https://issues.apache.org/jira/browse/HARMONY-4761
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>         Environment: Windows
>            Reporter: Dmitriy Matveev
>            Assignee: Alexey Petrenko
>         Attachments: HARMONY-4761-MouseEventTest.patch, HARMONY-4761-MouseEventTest.patch, HARMONY-4761-WinEvent.patch
>
>
> Reproducer:
> import java.awt.Frame;
> import java.awt.Graphics;
> import java.awt.Graphics2D;
> import java.awt.event.MouseEvent;
> import java.awt.event.MouseListener;
> import java.awt.event.WindowAdapter;
> import java.awt.event.WindowEvent;
> public class MouseReleaseTest {
>     public static void main(String[] args) {
>         Frame f = new Frame();
>         f.setBounds(0, 0, 800, 600);
>         f.setVisible(true);
>         f.addWindowListener(new WindowAdapter() {
>             public void windowClosing(WindowEvent ev) {
>                 System.exit(0);
>             }
>         });
>         
>         f.addMouseListener(new MouseListener(){
>             public void mouseReleased(MouseEvent e){
>                 System.out.println(e);
>             }
>             public void mouseClicked(MouseEvent e) { }
>             public void mouseEntered(MouseEvent e) { }
>             public void mouseExited(MouseEvent e) { }
>             public void mousePressed(MouseEvent e) { }
>         });
>     }
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (HARMONY-4761) [classlib][awt] InputEvent.getModifiers() doesn't return modifiers for mouse release event

Posted by "Alexey Petrenko (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-4761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexey Petrenko closed HARMONY-4761.
------------------------------------


> [classlib][awt] InputEvent.getModifiers() doesn't return modifiers for mouse release event
> ------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-4761
>                 URL: https://issues.apache.org/jira/browse/HARMONY-4761
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>         Environment: Windows
>            Reporter: Dmitriy Matveev
>            Assignee: Alexey Petrenko
>         Attachments: HARMONY-4761-ModifiersProcessing.patch, HARMONY-4761-ModifiersProcessingTest.patch, HARMONY-4761-MouseEventTest.patch
>
>
> Reproducer:
> import java.awt.Frame;
> import java.awt.Graphics;
> import java.awt.Graphics2D;
> import java.awt.event.MouseEvent;
> import java.awt.event.MouseListener;
> import java.awt.event.WindowAdapter;
> import java.awt.event.WindowEvent;
> public class MouseReleaseTest {
>     public static void main(String[] args) {
>         Frame f = new Frame();
>         f.setBounds(0, 0, 800, 600);
>         f.setVisible(true);
>         f.addWindowListener(new WindowAdapter() {
>             public void windowClosing(WindowEvent ev) {
>                 System.exit(0);
>             }
>         });
>         
>         f.addMouseListener(new MouseListener(){
>             public void mouseReleased(MouseEvent e){
>                 System.out.println(e);
>             }
>             public void mouseClicked(MouseEvent e) { }
>             public void mouseEntered(MouseEvent e) { }
>             public void mouseExited(MouseEvent e) { }
>             public void mousePressed(MouseEvent e) { }
>         });
>     }
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-4761) [classlib][awt] InputEvent.getModifiers() doesn't return modifiers for mouse release event

Posted by "Andrey Pavlenko (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-4761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12537078 ] 

Andrey Pavlenko commented on HARMONY-4761:
------------------------------------------

Everything is seems to be Ok. Thanks.

> [classlib][awt] InputEvent.getModifiers() doesn't return modifiers for mouse release event
> ------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-4761
>                 URL: https://issues.apache.org/jira/browse/HARMONY-4761
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>         Environment: Windows
>            Reporter: Dmitriy Matveev
>            Assignee: Alexey Petrenko
>         Attachments: HARMONY-4761-ModifiersProcessing.patch, HARMONY-4761-ModifiersProcessingTest.patch, HARMONY-4761-MouseEventTest.patch
>
>
> Reproducer:
> import java.awt.Frame;
> import java.awt.Graphics;
> import java.awt.Graphics2D;
> import java.awt.event.MouseEvent;
> import java.awt.event.MouseListener;
> import java.awt.event.WindowAdapter;
> import java.awt.event.WindowEvent;
> public class MouseReleaseTest {
>     public static void main(String[] args) {
>         Frame f = new Frame();
>         f.setBounds(0, 0, 800, 600);
>         f.setVisible(true);
>         f.addWindowListener(new WindowAdapter() {
>             public void windowClosing(WindowEvent ev) {
>                 System.exit(0);
>             }
>         });
>         
>         f.addMouseListener(new MouseListener(){
>             public void mouseReleased(MouseEvent e){
>                 System.out.println(e);
>             }
>             public void mouseClicked(MouseEvent e) { }
>             public void mouseEntered(MouseEvent e) { }
>             public void mouseExited(MouseEvent e) { }
>             public void mousePressed(MouseEvent e) { }
>         });
>     }
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (HARMONY-4761) [classlib][awt] InputEvent.getModifiers() doesn't return modifiers for mouse release event

Posted by "Alexey Petrenko (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-4761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexey Petrenko resolved HARMONY-4761.
--------------------------------------

    Resolution: Fixed

The patch has been applied.
Please, verify.

> [classlib][awt] InputEvent.getModifiers() doesn't return modifiers for mouse release event
> ------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-4761
>                 URL: https://issues.apache.org/jira/browse/HARMONY-4761
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>         Environment: Windows
>            Reporter: Dmitriy Matveev
>            Assignee: Alexey Petrenko
>         Attachments: HARMONY-4761-ModifiersProcessing.patch, HARMONY-4761-ModifiersProcessingTest.patch, HARMONY-4761-MouseEventTest.patch
>
>
> Reproducer:
> import java.awt.Frame;
> import java.awt.Graphics;
> import java.awt.Graphics2D;
> import java.awt.event.MouseEvent;
> import java.awt.event.MouseListener;
> import java.awt.event.WindowAdapter;
> import java.awt.event.WindowEvent;
> public class MouseReleaseTest {
>     public static void main(String[] args) {
>         Frame f = new Frame();
>         f.setBounds(0, 0, 800, 600);
>         f.setVisible(true);
>         f.addWindowListener(new WindowAdapter() {
>             public void windowClosing(WindowEvent ev) {
>                 System.exit(0);
>             }
>         });
>         
>         f.addMouseListener(new MouseListener(){
>             public void mouseReleased(MouseEvent e){
>                 System.out.println(e);
>             }
>             public void mouseClicked(MouseEvent e) { }
>             public void mouseEntered(MouseEvent e) { }
>             public void mouseExited(MouseEvent e) { }
>             public void mousePressed(MouseEvent e) { }
>         });
>     }
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.