You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "qingwen220 (via GitHub)" <gi...@apache.org> on 2023/11/15 11:23:41 UTC
[PR] feat(service/hdfs): enable rename in hdfs service [incubator-opendal]
qingwen220 opened a new pull request, #3592:
URL: https://github.com/apache/incubator-opendal/pull/3592
enable rename capacity
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(service/hdfs): enable rename in hdfs service [incubator-opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #3592:
URL: https://github.com/apache/incubator-opendal/pull/3592#issuecomment-1812637180
You can run `cargo clippy --features services-hdfs` locally to check the code of hdfs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(service/hdfs): enable rename in hdfs service [incubator-opendal]
Posted by "qingwen220 (via GitHub)" <gi...@apache.org>.
qingwen220 commented on PR #3592:
URL: https://github.com/apache/incubator-opendal/pull/3592#issuecomment-1813766194
> You can run `cargo clippy --features services-hdfs` locally to check the code of hdfs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(service/hdfs): enable rename in hdfs service [incubator-opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #3592:
URL: https://github.com/apache/incubator-opendal/pull/3592#discussion_r1395128483
##########
core/src/services/hdfs/backend.rs:
##########
@@ -155,6 +155,34 @@ pub struct HdfsBackend {
unsafe impl Send for HdfsBackend {}
unsafe impl Sync for HdfsBackend {}
+impl HdfsBackend {
+ fn create_parent_if_need(&self, path: &str) -> Result<()> {
Review Comment:
> Do you mean the method name?
I feel like we don't need this new function. How using `self.client.create_dir` instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(service/hdfs): enable rename in hdfs service [incubator-opendal]
Posted by "qingwen220 (via GitHub)" <gi...@apache.org>.
qingwen220 commented on code in PR #3592:
URL: https://github.com/apache/incubator-opendal/pull/3592#discussion_r1395130032
##########
core/src/services/hdfs/backend.rs:
##########
@@ -155,6 +155,34 @@ pub struct HdfsBackend {
unsafe impl Send for HdfsBackend {}
unsafe impl Sync for HdfsBackend {}
+impl HdfsBackend {
+ fn create_parent_if_need(&self, path: &str) -> Result<()> {
Review Comment:
removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(service/hdfs): enable rename in hdfs service [incubator-opendal]
Posted by "qingwen220 (via GitHub)" <gi...@apache.org>.
qingwen220 closed pull request #3592: feat(service/hdfs): enable rename in hdfs service
URL: https://github.com/apache/incubator-opendal/pull/3592
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(service/hdfs): enable rename in hdfs service [incubator-opendal]
Posted by "qingwen220 (via GitHub)" <gi...@apache.org>.
qingwen220 commented on code in PR #3592:
URL: https://github.com/apache/incubator-opendal/pull/3592#discussion_r1395126907
##########
core/src/services/hdfs/backend.rs:
##########
@@ -155,6 +155,34 @@ pub struct HdfsBackend {
unsafe impl Send for HdfsBackend {}
unsafe impl Sync for HdfsBackend {}
+impl HdfsBackend {
+ fn create_parent_if_need(&self, path: &str) -> Result<()> {
Review Comment:
Do you mean the method name?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(service/hdfs): enable rename in hdfs service [incubator-opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo merged PR #3592:
URL: https://github.com/apache/incubator-opendal/pull/3592
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(service/hdfs): enable rename in hdfs service [incubator-opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #3592:
URL: https://github.com/apache/incubator-opendal/pull/3592#discussion_r1394281409
##########
core/src/services/hdfs/backend.rs:
##########
@@ -155,6 +155,34 @@ pub struct HdfsBackend {
unsafe impl Send for HdfsBackend {}
unsafe impl Sync for HdfsBackend {}
+impl HdfsBackend {
+ fn create_parent_if_need(&self, path: &str) -> Result<()> {
Review Comment:
Please use
```rust
self.client
.create_dir(&parent.to_string_lossy())
.map_err(new_std_io_error)?;
```
like what we do in other methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org