You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/10/13 18:29:36 UTC
[GitHub] [tvm] janetsc opened a new pull request, #13066: [Hexagon] [runtime] VTCM bugfix, runtime buffer clarification
janetsc opened a new pull request, #13066:
URL: https://github.com/apache/tvm/pull/13066
Quick bugfix and clarification for runtime buffers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] adstraw commented on a diff in pull request #13066: [Hexagon] [runtime] VTCM bugfix, runtime buffer clarification
Posted by GitBox <gi...@apache.org>.
adstraw commented on code in PR #13066:
URL: https://github.com/apache/tvm/pull/13066#discussion_r997357268
##########
src/runtime/hexagon/hexagon_vtcm_pool.cc:
##########
@@ -69,12 +69,16 @@ void* HexagonVtcmPool::Allocate(size_t nbytes) {
// If this is not aligned on a 2k block, allocate from the end to avoid fragmentation
if (nbytes & size_t(0x7FF)) {
DLOG(INFO) << "VTCM nbytes requested: " << nbytes << " allocate from the end";
- auto last_free_entry = free_.rbegin();
+ auto last_free_entry = free_.end();
+ last_free_entry--;
Review Comment:
I think this would be more clear, but it's a NIT:
```
std::vector<std::pair<char*, size_t>>::iterator last_free_entry = free_.back();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] adstraw commented on a diff in pull request #13066: [Hexagon] [runtime] VTCM bugfix, runtime buffer clarification
Posted by GitBox <gi...@apache.org>.
adstraw commented on code in PR #13066:
URL: https://github.com/apache/tvm/pull/13066#discussion_r997357268
##########
src/runtime/hexagon/hexagon_vtcm_pool.cc:
##########
@@ -69,12 +69,16 @@ void* HexagonVtcmPool::Allocate(size_t nbytes) {
// If this is not aligned on a 2k block, allocate from the end to avoid fragmentation
if (nbytes & size_t(0x7FF)) {
DLOG(INFO) << "VTCM nbytes requested: " << nbytes << " allocate from the end";
- auto last_free_entry = free_.rbegin();
+ auto last_free_entry = free_.end();
+ last_free_entry--;
Review Comment:
I think this would be more clear, but it's a NIT:
```
std::vector<std::pair<char*, size_t>>::iterator last_free_entry = free_.back();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tvm-bot commented on pull request #13066: [Hexagon] [runtime] VTCM bugfix, runtime buffer clarification
Posted by GitBox <gi...@apache.org>.
tvm-bot commented on PR #13066:
URL: https://github.com/apache/tvm/pull/13066#issuecomment-1278018920
<!---bot-comment-->
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
<sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] AndrewZhaoLuo merged pull request #13066: [Hexagon] [runtime] VTCM bugfix, runtime buffer clarification
Posted by GitBox <gi...@apache.org>.
AndrewZhaoLuo merged PR #13066:
URL: https://github.com/apache/tvm/pull/13066
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] adstraw commented on a diff in pull request #13066: [Hexagon] [runtime] VTCM bugfix, runtime buffer clarification
Posted by GitBox <gi...@apache.org>.
adstraw commented on code in PR #13066:
URL: https://github.com/apache/tvm/pull/13066#discussion_r997365205
##########
src/runtime/hexagon/hexagon_vtcm_pool.cc:
##########
@@ -69,12 +69,16 @@ void* HexagonVtcmPool::Allocate(size_t nbytes) {
// If this is not aligned on a 2k block, allocate from the end to avoid fragmentation
if (nbytes & size_t(0x7FF)) {
DLOG(INFO) << "VTCM nbytes requested: " << nbytes << " allocate from the end";
- auto last_free_entry = free_.rbegin();
+ auto last_free_entry = free_.end();
+ last_free_entry--;
Review Comment:
Never mind, this doesn't work. Resolving. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org