[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #11172: deprecated(since) is not supported in jdk 8

["Jackie-Jiang (via GitHub)" <gi...@apache.org>]

Jackie-Jiang commented on code in PR #11172:
URL: https://github.com/apache/pinot/pull/11172#discussion_r1273967682


##########
pinot-plugins/pinot-stream-ingestion/pinot-pulsar/src/main/java/org/apache/pinot/plugin/stream/pulsar/PulsarConfig.java:
##########
@@ -52,7 +52,9 @@ public class PulsarConfig {
   private final SubscriptionInitialPosition _subscriptionInitialPosition;
   private final String _authenticationToken;
   private final String _tlsTrustCertsFilePath;
-  @Deprecated(since = "v0.13.* since pulsar supports record key extraction")
+
+  //"v0.13.* since pulsar supports record key extraction
+  @Deprecated

Review Comment:
   ```suggestion
     // Deprecated since pulsar supports record key extraction
     @Deprecated
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org