DO NOT REPLY [Bug 28044] New: - Patch, Avalon Logging to Commons Logging Conversion.

[bu...@apache.org]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=28044>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=28044

Patch, Avalon Logging to Commons Logging Conversion.

           Summary: Patch, Avalon Logging to Commons Logging Conversion.
           Product: Fop
           Version: 1.0dev
          Platform: Other
        OS/Version: Other
            Status: NEW
          Severity: Normal
          Priority: Other
         Component: general
        AssignedTo: fop-dev@xml.apache.org
        ReportedBy: glenmazza@yahoo.com


Team, 

Attaching the patch that will convert FOP to using Commons Logging [1].  

I've tested several sample files with it, it appears to run fine throughout, 
but as the changes are extensive, I suspect there will be a few places where a 
logger was not properly set, etc.  Let me know what you see, but I suspect many 
small bugs we can fix after the patch is applied.

Only issue found was in setting a logger for an Avalon "ContainerUtil", which 
currently won't work with Commons Logging and needs its own Avalon logger.  I 
just commented out the line (in two places) where that ContainerUtil logging 
would otherwise have been enabled (I don't think we're currently using this 
functionality anyway.)  In the future, we can look at other options here--such 
as just feeding it an Avalon console logger, to providing a file conversion 
between the two logging choices, to just not logging here, to using an 
alternative to ContainerUtil.

I'll hold off on this for three days to allow for team comments.  (Please 
minimize your changes to the HEAD code base in the interim, as updating this 
patch would be very complex.)

Thanks,
Glen

[1] http://marc.theaimsgroup.com/?l=fop-dev&m=108009551327746&w=2