You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@kvrocks.apache.org by "PragmaTwice (via GitHub)" <gi...@apache.org> on 2024/10/19 05:58:41 UTC

[PR] feat(conn): move time-consuming ops out of ExecuteCommand for context [kvrocks]

PragmaTwice opened a new pull request, #2611:
URL: https://github.com/apache/kvrocks/pull/2611

   The scope (position of destruction) is important for Context, so we should move time-consuming ops like `FeedMonitorConns` out of `ExecuteCommand` so that the context can be destructed before these ops. (especially after we move key locking into ExecuteCommands)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(conn): move time-consuming ops out of ExecuteCommand for context [kvrocks]

Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.

PragmaTwice commented on PR #2611:
URL: https://github.com/apache/kvrocks/pull/2611#issuecomment-2423660228

   cc @PokIsemaine 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(conn): move time-consuming ops out of ExecuteCommand for context [kvrocks]

Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.

PragmaTwice merged PR #2611:
URL: https://github.com/apache/kvrocks/pull/2611


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(conn): move time-consuming ops out of ExecuteCommand for context [kvrocks]

Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.

sonarcloud[bot] commented on PR #2611:
URL: https://github.com/apache/kvrocks/pull/2611#issuecomment-2423659224

   ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://sonarcloud.io/dashboard?id=apache_kvrocks&pullRequest=2611) **Quality Gate failed**  
   Failed conditions  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/failed-16px.png '') [E Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_kvrocks&pullRequest=2611) (required ≥ A)  
     
   [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_kvrocks&pullRequest=2611)
   
   ##   
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/light_bulb-16px.png '') Catch issues before they fail your Quality Gate with our IDE extension ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/sonarlint-16px.png '') [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org