You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by Seungun Choe <wh...@gmail.com> on 2014/05/13 04:23:06 UTC
Review Request 21355: TAJO-637: Enhance to_char() function
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21355/
-----------------------------------------------------------
Review request for Tajo.
Bugs: TAJO-637
https://issues.apache.org/jira/browse/TAJO-637
Repository: tajo
Description
-------
Currently, Tajo only supports to_char(timestamp, text) function.
However, PostgreSQL supports to_char() for timestamp, interval, int, double, and numeric types
Tajo needs to support more data types in to_char() as shown in
http://www.postgresql.org/docs/9.3/static/functions-formatting.html
Diffs
-----
tajo-core/src/main/java/org/apache/tajo/engine/function/dataformat/ToCharDataFormat.java PRE-CREATION
tajo-core/src/main/java/org/apache/tajo/engine/function/dataformat/ToCharJavaDataFormat.java PRE-CREATION
tajo-core/src/test/java/org/apache/tajo/engine/function/TestDataFormatFunctions.java PRE-CREATION
Diff: https://reviews.apache.org/r/21355/diff/
Testing
-------
mvn clean install is OK.
Thanks,
Seungun Choe
Re: Review Request 21355: TAJO-637: Enhance to_char() function
Posted by Seungun Choe <wh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21355/
-----------------------------------------------------------
(Updated May 21, 2014, 11:43 p.m.)
Review request for Tajo.
Changes
-------
I've certainly improved on last diff version.
'mvn clean install' is OK.
Bugs: TAJO-637
https://issues.apache.org/jira/browse/TAJO-637
Repository: tajo
Description
-------
Currently, Tajo only supports to_char(timestamp, text) function.
However, PostgreSQL supports to_char() for timestamp, interval, int, double, and numeric types
Tajo needs to support more data types in to_char() as shown in
http://www.postgresql.org/docs/9.3/static/functions-formatting.html
Diffs (updated)
-----
tajo-core/src/main/java/org/apache/tajo/engine/function/dataformat/ToCharDataFormat.java PRE-CREATION
tajo-core/src/main/java/org/apache/tajo/engine/function/dataformat/ToCharJavaDataFormat.java PRE-CREATION
tajo-core/src/test/java/org/apache/tajo/engine/function/TestDataFormatFunctions.java PRE-CREATION
Diff: https://reviews.apache.org/r/21355/diff/
Testing
-------
mvn clean install is OK.
Thanks,
Seungun Choe