You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by namanmishra91 <gi...@git.apache.org> on 2017/02/02 12:59:07 UTC
[GitHub] zeppelin pull request #1968: [ZEPPELIN-1551] Remove the "default" text again...
GitHub user namanmishra91 opened a pull request:
https://github.com/apache/zeppelin/pull/1968
[ZEPPELIN-1551] Remove the "default" text against interpreters on interpreters screen as it is providing incorrect semantics
### What is this PR for?
This PR addresses the incorrect semantics and confusion caused by the "default" text against an interpreter group on interpreters page.
The intent of of this tag seems to be informing the user which of the interpreters among a particular group will be used by default if the user doesn't specify any %<interpreter> tag. However, the "default" tag is always tied to the first interpreter of the first interpreter group on the page and isn't displayed for any other interpreter groups; therefore not serving any purpose. It also leads to confusion with the default interpreter bound to a notebook on bindings page.
It would be better to remove this default tag from interpreters in order to avoid the confusion.
### What type of PR is it?
Bug Fix
### Todos
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1551
### How should this be tested?
Run Zeppelin server. Open Interpreters menu. "default" shouldn't be visible against any interpreter group.
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
### Screenshots (if appropriate)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/namanmishra91/zeppelin ZEPPELIN-1551
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1968.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1968
----
commit f9ded1d27b314aec618158710c86b1e172206e26
Author: Naman Mishra <na...@qubole.com>
Date: 2017-02-02T10:58:50Z
Remove the "default" text against interpreters on interpreter settings screen as it is providing incorrect semantics.
"Default" is always tied to the first interpreter of the first interpreter group on the page; therefore not serving any purpose. It also leads to confusion with the default bound interpreter on bindings page.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1968: [ZEPPELIN-1551] Remove the "default" text against inte...
Posted by namanmishra91 <gi...@git.apache.org>.
Github user namanmishra91 commented on the issue:
https://github.com/apache/zeppelin/pull/1968
The test failures don't seem to be related to my change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1968: [ZEPPELIN-1551] Remove the "default" text again...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1968
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1968: [ZEPPELIN-1551] Remove the "default" text against inte...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1968
LGTM. merging if there's no more discussion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---