You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by "hussein-awala (via GitHub)" <gi...@apache.org> on 2023/08/19 21:19:29 UTC

[GitHub] [airflow] hussein-awala opened a new pull request, #33540: Fix BigQueryCreateExternalTableOperator when using a foramt different to CSV

hussein-awala opened a new pull request, #33540:
URL: https://github.com/apache/airflow/pull/33540

<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->

<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.

Feel free to ping committers for the review!

In case of an existing issue, reference it using one of the following:

closes: #ISSUE
related: #ISSUE

How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
closes: #32712

According to GCP doc, BigQuery API supports different configurations set in `ExternalDataConfiguration` like `CsvOptions`, `BigtableOptions`, `GoogleSheetsOptions`, ... but they could be provided with a specific source format; if the source format is different, the query will fail. There are other configurations not supported by some source formats, but there is no problem with providing them where the API ignore them without raising an exception (ex: `maxBadRecords`).

This PR adds `CsvOptions` only when the source format is CSV.

Source: https://cloud.google.com/bigquery/docs/reference/rest/v2/tables#Table

---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] uranusjr commented on a diff in pull request #33540: Fix BigQueryCreateExternalTableOperator when using a foramt different to CSV

Posted by "uranusjr (via GitHub)" <gi...@apache.org>.

uranusjr commented on code in PR #33540:
URL: https://github.com/apache/airflow/pull/33540#discussion_r1299288761


##########
airflow/providers/google/cloud/operators/bigquery.py:
##########
@@ -1797,6 +1797,22 @@ def execute(self, context: Context) -> None:
             default_project_id=bq_hook.project_id or "",
         )
 
+        externalDataConfiguration = {

Review Comment:
   ```suggestion
           external_data_configuration = {
   ```
   
   And adjust references accordingly



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk merged pull request #33540: Fix BigQueryCreateExternalTableOperator when using a foramt different to CSV

Posted by "potiuk (via GitHub)" <gi...@apache.org>.

potiuk merged PR #33540:
URL: https://github.com/apache/airflow/pull/33540


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org