[GitHub] [superset] betodealmeida commented on a diff in pull request #23716: feat: create dtype option for csv upload

["betodealmeida (via GitHub)" <gi...@apache.org>]

betodealmeida commented on code in PR #23716:
URL: https://github.com/apache/superset/pull/23716#discussion_r1171858199


##########
superset/views/database/forms.py:
##########
@@ -140,6 +140,14 @@ class CsvToDatabaseForm(UploadToDatabaseForm):
         get_pk=lambda a: a.id,
         get_label=lambda a: a.database_name,
     )
+    dtype = StringField(
+        _("Column Data Types"),
+        description=_(
+            "A dictionary with column names and their data types if you need to change the defaults. Example: {“Column”:“data type”}"

Review Comment:
   I would use a concrete example here, something like:
   
   ```suggestion
               "A dictionary with column names and their data types if you need to change the defaults. Example: {“user_id”:“integer”}"
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org