You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/02/03 20:23:14 UTC
[GitHub] [netbeans] entlicher opened a new pull request #2725: Vscodeext codelens output fixes
entlicher opened a new pull request #2725:
URL: https://github.com/apache/netbeans/pull/2725
Correction of output from Run/Debug code lens actions.
- In case of Debug, the TerminatedEvent was sent too soon. Now, similar to Run, the TerminatedEvent is sent when the application terminates.
- Run now runs in the same was as "Run Without Debug" - through startDebugger with noDebug = true. This is necessary for consistency and proper output display.
- A NPE associated with a missing source path in case of Run is addressed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic merged pull request #2725: [NETBEANS-5326] LSP codelens output fixes
Posted by GitBox <gi...@apache.org>.
sdedic merged pull request #2725:
URL: https://github.com/apache/netbeans/pull/2725
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on a change in pull request #2725: [NETBEANS-5326] LSP codelens output fixes
Posted by GitBox <gi...@apache.org>.
sdedic commented on a change in pull request #2725:
URL: https://github.com/apache/netbeans/pull/2725#discussion_r573864892
##########
File path: java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/debugging/launch/NbLaunchRequestHandler.java
##########
@@ -161,7 +176,7 @@ private static OutputEventArguments convertToOutputEventArguments(String message
protected void handleTerminatedEvent(DebugAdapterContext context) {
CompletableFuture.runAsync(() -> {
try {
- waitForDebuggeeConsole.get(5, TimeUnit.SECONDS);
+ waitForDebuggeeConsole.get(1, TimeUnit.SECONDS);
Review comment:
Hi, incidentally I attempted to solve this delay by removing it :) completely in apache/netbeans#2754 . See the discussion in that PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] entlicher commented on pull request #2725: LSP codelens output fixes
Posted by GitBox <gi...@apache.org>.
entlicher commented on pull request #2725:
URL: https://github.com/apache/netbeans/pull/2725#issuecomment-773349368
@neilcsmith-net I've updated the description and created NETBEANS-5326 based on our internal report. That should allow to asses the importance for 12.3. I consider the fix to be of a very low risk, especially comparing to the currently broken behavior.
The modifications are in the area of the LSP server implementation only.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] entlicher commented on pull request #2725: LSP codelens output fixes
Posted by GitBox <gi...@apache.org>.
entlicher commented on pull request #2725:
URL: https://github.com/apache/netbeans/pull/2725#issuecomment-773349368
@neilcsmith-net I've updated the description and created NETBEANS-5326 based on our internal report. That should allow to asses the importance for 12.3. I consider the fix to be of a very low risk, especially comparing to the currently broken behavior.
The modifications are in the area of the LSP server implementation only.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #2725: [NETBEANS-5326] LSP codelens output fixes
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #2725:
URL: https://github.com/apache/netbeans/pull/2725#issuecomment-773361589
@entlicher thanks. It's more about criticals and blockers generally requiring another beta for testing. Quite happy for major (or minors) to come in then where available, particularly when they're low risk! @geertjanw and I put forward an optimistic schedule with only two betas initially due to late start on the release (no RM in place). At least one more beta is looking likely now anyway.
I've updated the title - hopefully Apache infra will link the two.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #2725: LSP codelens output fixes
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #2725:
URL: https://github.com/apache/netbeans/pull/2725#issuecomment-773174902
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on pull request #2725: [NETBEANS-5326] LSP codelens output fixes
Posted by GitBox <gi...@apache.org>.
sdedic commented on pull request #2725:
URL: https://github.com/apache/netbeans/pull/2725#issuecomment-777452373
Merged per Neil's advice in #2754
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #2725: LSP codelens output fixes
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #2725:
URL: https://github.com/apache/netbeans/pull/2725#issuecomment-773174902
At the moment, we don't have another beta scheduled, although discussions elsewhere might lead to one. If not, I don't feel in a position to assess this one against the [bug priority guidelines](https://cwiki.apache.org/confluence/display/NETBEANS/Bug+Priority+Guidelines). Can we get assessment of the necessity to get this in to 12.3? Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists