You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@grails.apache.org by "jamesfredley (via GitHub)" <gi...@apache.org> on 2026/06/26 22:30:09 UTC
[PR] Guard child datastore entity registration [grails-core]
jamesfredley opened a new pull request, #15776:
URL: https://github.com/apache/grails-core/pull/15776
## Summary
- Guard Hibernate 5 and Hibernate 7 mapping-context listeners when a child datastore has no GORM enhancer.
- Add late entity registration regressions for both Hibernate lines.
- Verify public `withNewSession` routing still uses the mapped `books` datasource.
## Verification
- `./gradlew --no-daemon --max-workers=1 :grails-data-hibernate5-core:test --tests "org.grails.orm.hibernate.connections.MultipleDataSourceConnectionsSpec" :grails-data-hibernate7-core:test --tests "org.grails.orm.hibernate.connections.MultipleDataSourceConnectionsSpec" -PmaxTestParallel=1`
- `./gradlew --no-daemon --max-workers=1 :grails-data-hibernate5-core:test --tests "org.grails.orm.hibernate.connections.MultipleDataSourceConnectionsSpec.late registered entity is enhanced without child datastore listener failure" :grails-data-hibernate7-core:test --tests "org.grails.orm.hibernate.connections.MultipleDataSourceConnectionsSpec.late registered entity is enhanced without child datastore listener failure" -PmaxTestParallel=1`
- `./gradlew --no-daemon --max-workers=1 :grails-data-hibernate7-core:test --tests "org.grails.orm.hibernate.ChildHibernateDatastoreUnitSpec" -PmaxTestParallel=1`
- `git diff --check`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Guard child datastore entity registration [grails-core]
Posted by "jamesfredley (via GitHub)" <gi...@apache.org>.
jamesfredley commented on PR #15776:
URL: https://github.com/apache/grails-core/pull/15776#issuecomment-4819305835
This was found during https://github.com/apache/grails-core/pull/15678 and now carved off into dedicated PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Guard child datastore entity registration [grails-core]
Posted by "borinquenkid (via GitHub)" <gi...@apache.org>.
borinquenkid commented on PR #15776:
URL: https://github.com/apache/grails-core/pull/15776#issuecomment-4814669338
8.0.x is already broken — H5, H7, and MongoDB all fail to compile even without our scaling commit. So these are pre-existing compilation failures on the base branch, not introduced by our work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Guard child datastore entity registration against a null GORM enhancer (late registration NPE) [grails-core]
Posted by "testlens-app[bot] (via GitHub)" <gi...@apache.org>.
testlens-app[bot] commented on PR #15776:
URL: https://github.com/apache/grails-core/pull/15776#issuecomment-4835592661
## ✅ All tests passed ✅
🏷️ Commit: c4bd064918d1cb76171acb14b7fa179c944bbf1b
▶️ Tests: 22801 executed
⚪️ Checks: 44/44 completed
---
_Learn more about TestLens at [testlens.app](https://testlens.app)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Guard child datastore entity registration against a null GORM enhancer (late registration NPE) [grails-core]
Posted by "jamesfredley (via GitHub)" <gi...@apache.org>.
jamesfredley commented on PR #15776:
URL: https://github.com/apache/grails-core/pull/15776#issuecomment-4844743348
@borinquenkid FYI This fix for child datastore has been merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Guard child datastore entity registration [grails-core]
Posted by "testlens-app[bot] (via GitHub)" <gi...@apache.org>.
testlens-app[bot] commented on PR #15776:
URL: https://github.com/apache/grails-core/pull/15776#issuecomment-4814001227
## 🚨 TestLens detected 1 failed test 🚨
Here is what you can do:
1) Inspect the test failures carefully.
2) If you are convinced that some of the tests are flaky, you can mute them below.
3) Finally, trigger a rerun by checking the rerun checkbox.
### Test Summary
#### [CI / Functional Tests \(Java 21, indy\=true\)](https://github.com/apache/grails-core/actions/runs/28268876976/job/83761850025?pr=15776) > :grails-test-examples-scaffolding:integrationTest
| Test | Runs |
|---|---|
| UserControllerSpec > User list | ❌ |
🏷️ Commit: c22c4a63d0c5450cb9d3bf024c028e14d5ab5ac0
▶️ Tests: 36921 executed
🟡 Checks: 31/40 completed
### Test Failures
<details>
<summary><strong>UserControllerSpec > User list</strong> (:grails-test-examples-scaffolding:integrationTest in <a href="https://github.com/apache/grails-core/actions/runs/28268876976/job/83761850025?pr=15776">CI / Functional Tests (Java 21, indy=true)</a>)</summary>
```
geb.waiting.WaitTimeoutException: condition did not pass in 10 seconds (failed with exception)
at geb.waiting.Wait.waitFor(Wait.groovy:128)
at geb.waiting.PotentiallyWaitingExecutor.execute(PotentiallyWaitingExecutor.groovy:31)
at geb.Page.verifyThisPageAtOnly(Page.groovy:424)
at geb.Page.getAtVerificationResult(Page.groovy:217)
at geb.Page.verifyAt(Page.groovy:188)
at geb.Browser.doAt(Browser.groovy:1208)
at geb.Browser.at(Browser.groovy:410)
at geb.Browser.to(Browser.groovy:566)
at geb.Browser.to(Browser.groovy:543)
at geb.Browser.to(Browser.groovy:532)
at grails.plugin.geb.support.delegate.BrowserDelegate$Trait$Helper.to(BrowserDelegate.groovy:160)
at com.example.UserControllerSpec.User list(UserControllerSpec.groovy:46)
Caused by: Assertion failed:
title == pageTitle
| | |
| | 'User List'
| false
'Please sign in'
at com.example.pages.UserListPage._clinit__closure1(UserListPage.groovy:28)
at com.example.pages.UserListPage._clinit__closure1(UserListPage.groovy)
at geb.waiting.Wait.waitFor(Wait.groovy:117)
... 11 more
```
</details>
### Muted Tests
> [!NOTE]
> Checks are currently running using the configuration below.
Select tests to mute in this pull request:
🔲 UserControllerSpec > User list <!-- uniqueId=[engine:spock]/[spec:com.example.UserControllerSpec]/[feature:$spock_feature_1_0] -->
Reuse successful test results:
🔲 ♻️ Only rerun the tests that failed or were muted before
Click the checkbox to trigger a rerun:
🔲 **Rerun jobs**
---
_Learn more about TestLens at [testlens.app](https://testlens.app)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Guard child datastore entity registration against a null GORM enhancer (late registration NPE) [grails-core]
Posted by "jamesfredley (via GitHub)" <gi...@apache.org>.
jamesfredley merged PR #15776:
URL: https://github.com/apache/grails-core/pull/15776
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org