[GitHub] [pulsar] poorbarcode opened a new pull request, #18009: [improve] [broker] make consumer read compacted still works even if ledger lost

[GitBox <gi...@apache.org>]

poorbarcode opened a new pull request, #18009:
URL: https://github.com/apache/pulsar/pull/18009

   Fixes:
   - #17222
   
   Master Issue: #17222
   
   ### Motivation
   
   In the current implementation, if the `compaction ledger` is lost, `consumer receive` will fail. Because `CompactedTopicImpl` can not read data from the `compaction ledger.` But in fact, consumers can read data directly by `cursor` at this time, no data lost and no need to enable `autoSkipNonRecoverableData`
   
   ### Modifications
   - Directly read entries by `cursor` when `compaction ledger` is lost.
   - Add test "testTopicLedgerLost"
   - Add test "testCursorLedgerLost"， see: #17220. In the current implementation, `ManagedCursor` will skip the invalid data during `recover`, even if the feature `autoSkipNonRecoverableData` is disabled
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc` <!-- Your PR contains doc changes. Please attach the local preview screenshots (run `sh start.sh` at `pulsar/site2/website`) to your PR description, or else your PR might not get merged. -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
   - [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->
   
   ### Matching PR in forked repository
   
   PR in forked repository: 
   - https://github.com/poorbarcode/pulsar/pull/21
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] github-actions[bot] commented on pull request #18009: [improve] [broker] make consumer read compacted still works even if compaction ledger lost

[GitBox <gi...@apache.org>]

github-actions[bot] commented on PR #18009:
URL: https://github.com/apache/pulsar/pull/18009#issuecomment-1312319123

   The pr had no activity for 30 days, mark with Stale label.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org