[GitHub] [spark] cloud-fan commented on a change in pull request #26557: [SPARK-29873][SQL][Test][FOLLOWUP] set operations should not escape when regen golde file with --SET --import both specified

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #26557: [SPARK-29873][SQL][Test][FOLLOWUP] set operations should not escape when regen golde file with --SET --import both specified
URL: https://github.com/apache/spark/pull/26557#discussion_r347228176
 
 

 ##########
 File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala
 ##########
 @@ -285,7 +285,7 @@ class SQLQueryTestSuite extends QueryTest with SharedSparkSession {
 
     // When we are regenerating the golden files, we don't need to set any config as they
     // all need to return the same result
-    if (regenerateGoldenFiles || !isTestWithConfigSets) {
+    if ((regenerateGoldenFiles && importedTestCaseName.isEmpty) || !isTestWithConfigSets) {
 
 Review comment:
   ah seems we have 2 different kinds of settings now:
   1. settings that shouldn't change result. We want to generate the golden files without the settings and run tests with settings.
   2. setting that can change result.
   
   Shall we have different directives for them? @maropu 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org