You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "sbernauer (via GitHub)" <gi...@apache.org> on 2026/01/29 11:08:24 UTC
[PR] NIFI-15062 Support configuring S3 endpoint/path style acces in Iceberg [nifi]
sbernauer opened a new pull request, #10825:
URL: https://github.com/apache/nifi/pull/10825
<!-- Licensed to the Apache Software Foundation (ASF) under one or more -->
<!-- contributor license agreements. See the NOTICE file distributed with -->
<!-- this work for additional information regarding copyright ownership. -->
<!-- The ASF licenses this file to You under the Apache License, Version 2.0 -->
<!-- (the "License"); you may not use this file except in compliance with -->
<!-- the License. You may obtain a copy of the License at -->
<!-- http://www.apache.org/licenses/LICENSE-2.0 -->
<!-- Unless required by applicable law or agreed to in writing, software -->
<!-- distributed under the License is distributed on an "AS IS" BASIS, -->
<!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -->
<!-- See the License for the specific language governing permissions and -->
<!-- limitations under the License. -->
# Summary
[NIFI-15524](https://issues.apache.org/jira/browse/NIFI-15524)
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
### Pull Request Tracking
- [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
- [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
- [ ] Pull request contains [commits signed](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits) with a registered key indicating `Verified` status
### Pull Request Formatting
- [ ] Pull Request based on current revision of the `main` branch
- [ ] Pull Request refers to a feature branch with one commit containing changes
# Verification
Please indicate the verification steps performed prior to pull request creation.
### Build
- [ ] Build completed using `./mvnw clean install -P contrib-check`
- [ ] JDK 21
- [ ] JDK 25
### Licensing
- [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
- [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
### Documentation
- [ ] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-15524 Support configuring S3 endpoint/path style acces in Iceberg [nifi]
Posted by "exceptionfactory (via GitHub)" <gi...@apache.org>.
exceptionfactory commented on code in PR #10825:
URL: https://github.com/apache/nifi/pull/10825#discussion_r2742227457
##########
nifi-extension-bundles/nifi-iceberg-bundle/nifi-iceberg-aws/src/main/java/org/apache/nifi/services/iceberg/aws/S3IcebergFileIOProvider.java:
##########
@@ -102,12 +102,32 @@ public class S3IcebergFileIOProvider extends AbstractControllerService implement
)
.build();
+ static final PropertyDescriptor ENDPOINT_OVERRIDE = new PropertyDescriptor.Builder()
+ .name("Endpoint Override URL")
+ .description("Endpoint URL to use instead of the AWS default including scheme, host, port, and path. " +
+ "The AWS libraries select an endpoint URL based on the AWS region, but this property overrides " +
+ "the selected endpoint URL, allowing use with other S3-compatible endpoints.")
+ .expressionLanguageSupported(ExpressionLanguageScope.ENVIRONMENT)
Review Comment:
I recommend avoiding the use of the `ENVIRONMENT` scope for now, it could be added later if needed.
##########
nifi-extension-bundles/nifi-iceberg-bundle/nifi-iceberg-aws/src/main/java/org/apache/nifi/services/iceberg/aws/S3IcebergFileIOProvider.java:
##########
@@ -102,12 +102,32 @@ public class S3IcebergFileIOProvider extends AbstractControllerService implement
)
.build();
+ static final PropertyDescriptor ENDPOINT_OVERRIDE = new PropertyDescriptor.Builder()
+ .name("Endpoint Override URL")
+ .description("Endpoint URL to use instead of the AWS default including scheme, host, port, and path. " +
+ "The AWS libraries select an endpoint URL based on the AWS region, but this property overrides " +
+ "the selected endpoint URL, allowing use with other S3-compatible endpoints.")
Review Comment:
Please reformat using a multiline string.
##########
nifi-extension-bundles/nifi-iceberg-bundle/nifi-iceberg-aws/src/main/java/org/apache/nifi/services/iceberg/aws/S3IcebergFileIOProvider.java:
##########
@@ -102,12 +102,32 @@ public class S3IcebergFileIOProvider extends AbstractControllerService implement
)
.build();
+ static final PropertyDescriptor ENDPOINT_OVERRIDE = new PropertyDescriptor.Builder()
+ .name("Endpoint Override URL")
+ .description("Endpoint URL to use instead of the AWS default including scheme, host, port, and path. " +
+ "The AWS libraries select an endpoint URL based on the AWS region, but this property overrides " +
+ "the selected endpoint URL, allowing use with other S3-compatible endpoints.")
+ .expressionLanguageSupported(ExpressionLanguageScope.ENVIRONMENT)
+ .required(false)
+ .addValidator(StandardValidators.URL_VALIDATOR)
+ .build();
+
+ static final PropertyDescriptor USE_PATH_STYLE_ACCESS = new PropertyDescriptor.Builder()
+ .name("Use Path Style Access")
+ .description("Path-style access can be enforced by setting this property to true. Set it to true if your endpoint does not support " +
+ "virtual-hosted-style requests, only path-style requests.")
+ .allowableValues("true", "false")
+ .defaultValue(String.valueOf(S3FileIOProperties.PATH_STYLE_ACCESS_DEFAULT))
+ .build();
Review Comment:
A Boolean validator should be added
##########
nifi-extension-bundles/nifi-iceberg-bundle/nifi-iceberg-aws/src/main/java/org/apache/nifi/services/iceberg/aws/S3IcebergFileIOProvider.java:
##########
@@ -102,12 +102,32 @@ public class S3IcebergFileIOProvider extends AbstractControllerService implement
)
.build();
+ static final PropertyDescriptor ENDPOINT_OVERRIDE = new PropertyDescriptor.Builder()
+ .name("Endpoint Override URL")
Review Comment:
I recommend naming this `Endpoint URL` to align more closely with the underlying Iceberg property.
```suggestion
static final PropertyDescriptor ENDPOINT_URL = new PropertyDescriptor.Builder()
.name("Endpoint URL")
```
##########
nifi-extension-bundles/nifi-iceberg-bundle/nifi-iceberg-aws/src/main/java/org/apache/nifi/services/iceberg/aws/S3IcebergFileIOProvider.java:
##########
@@ -102,12 +102,32 @@ public class S3IcebergFileIOProvider extends AbstractControllerService implement
)
.build();
+ static final PropertyDescriptor ENDPOINT_OVERRIDE = new PropertyDescriptor.Builder()
+ .name("Endpoint Override URL")
+ .description("Endpoint URL to use instead of the AWS default including scheme, host, port, and path. " +
+ "The AWS libraries select an endpoint URL based on the AWS region, but this property overrides " +
+ "the selected endpoint URL, allowing use with other S3-compatible endpoints.")
+ .expressionLanguageSupported(ExpressionLanguageScope.ENVIRONMENT)
+ .required(false)
+ .addValidator(StandardValidators.URL_VALIDATOR)
+ .build();
+
+ static final PropertyDescriptor USE_PATH_STYLE_ACCESS = new PropertyDescriptor.Builder()
+ .name("Use Path Style Access")
Review Comment:
I recommend renaming this to `Path Style Access` to align more closely to the Iceberg property name.
```suggestion
static final PropertyDescriptor PATH_STYLE_ACCESS = new PropertyDescriptor.Builder()
.name("Path Style Access")
```
##########
nifi-extension-bundles/nifi-iceberg-bundle/nifi-iceberg-aws/src/main/java/org/apache/nifi/services/iceberg/aws/S3IcebergFileIOProvider.java:
##########
@@ -102,12 +102,32 @@ public class S3IcebergFileIOProvider extends AbstractControllerService implement
)
.build();
+ static final PropertyDescriptor ENDPOINT_OVERRIDE = new PropertyDescriptor.Builder()
+ .name("Endpoint Override URL")
+ .description("Endpoint URL to use instead of the AWS default including scheme, host, port, and path. " +
+ "The AWS libraries select an endpoint URL based on the AWS region, but this property overrides " +
+ "the selected endpoint URL, allowing use with other S3-compatible endpoints.")
+ .expressionLanguageSupported(ExpressionLanguageScope.ENVIRONMENT)
+ .required(false)
+ .addValidator(StandardValidators.URL_VALIDATOR)
+ .build();
+
+ static final PropertyDescriptor USE_PATH_STYLE_ACCESS = new PropertyDescriptor.Builder()
+ .name("Use Path Style Access")
+ .description("Path-style access can be enforced by setting this property to true. Set it to true if your endpoint does not support " +
+ "virtual-hosted-style requests, only path-style requests.")
+ .allowableValues("true", "false")
+ .defaultValue(String.valueOf(S3FileIOProperties.PATH_STYLE_ACCESS_DEFAULT))
Review Comment:
This can be marked as `required(true)` since a default value is provided.
##########
nifi-extension-bundles/nifi-iceberg-bundle/nifi-iceberg-aws/src/main/java/org/apache/nifi/services/iceberg/aws/S3IcebergFileIOProvider.java:
##########
@@ -102,12 +102,32 @@ public class S3IcebergFileIOProvider extends AbstractControllerService implement
)
.build();
+ static final PropertyDescriptor ENDPOINT_OVERRIDE = new PropertyDescriptor.Builder()
+ .name("Endpoint Override URL")
+ .description("Endpoint URL to use instead of the AWS default including scheme, host, port, and path. " +
+ "The AWS libraries select an endpoint URL based on the AWS region, but this property overrides " +
+ "the selected endpoint URL, allowing use with other S3-compatible endpoints.")
+ .expressionLanguageSupported(ExpressionLanguageScope.ENVIRONMENT)
+ .required(false)
+ .addValidator(StandardValidators.URL_VALIDATOR)
+ .build();
+
+ static final PropertyDescriptor USE_PATH_STYLE_ACCESS = new PropertyDescriptor.Builder()
+ .name("Use Path Style Access")
+ .description("Path-style access can be enforced by setting this property to true. Set it to true if your endpoint does not support " +
+ "virtual-hosted-style requests, only path-style requests.")
Review Comment:
```suggestion
.description("Path-style access can be enforced by setting this property to true. Set it to true if the configured endpoint does not support " +
"virtual-hosted-style requests, only path-style requests.")
```
##########
nifi-extension-bundles/nifi-iceberg-bundle/nifi-iceberg-aws/src/main/java/org/apache/nifi/services/iceberg/aws/S3IcebergFileIOProvider.java:
##########
@@ -102,12 +102,32 @@ public class S3IcebergFileIOProvider extends AbstractControllerService implement
)
.build();
+ static final PropertyDescriptor ENDPOINT_OVERRIDE = new PropertyDescriptor.Builder()
+ .name("Endpoint Override URL")
+ .description("Endpoint URL to use instead of the AWS default including scheme, host, port, and path. " +
+ "The AWS libraries select an endpoint URL based on the AWS region, but this property overrides " +
+ "the selected endpoint URL, allowing use with other S3-compatible endpoints.")
+ .expressionLanguageSupported(ExpressionLanguageScope.ENVIRONMENT)
+ .required(false)
+ .addValidator(StandardValidators.URL_VALIDATOR)
+ .build();
+
+ static final PropertyDescriptor USE_PATH_STYLE_ACCESS = new PropertyDescriptor.Builder()
+ .name("Use Path Style Access")
+ .description("Path-style access can be enforced by setting this property to true. Set it to true if your endpoint does not support " +
+ "virtual-hosted-style requests, only path-style requests.")
+ .allowableValues("true", "false")
Review Comment:
Recommend using `Boolean.TRUE.toString()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-15524 Support configuring S3 endpoint/path style access in Iceberg [nifi]
Posted by "exceptionfactory (via GitHub)" <gi...@apache.org>.
exceptionfactory merged PR #10825:
URL: https://github.com/apache/nifi/pull/10825
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-15524 Support configuring S3 endpoint/path style access in Iceberg [nifi]
Posted by "sbernauer (via GitHub)" <gi...@apache.org>.
sbernauer commented on PR #10825:
URL: https://github.com/apache/nifi/pull/10825#issuecomment-3823429323
Thanks for your quick review!
I addressed the requested changes. One downside is that the property names/descriptions are not consistent between the S3 processors and the Iceberg service.
But changing them in the S3 processors would be a breaking change I guess.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org