[GitHub] [airflow] kaxil commented on a change in pull request #5757: [AIRFLOW-5100] Use safe_mode configuration setting by default

[GitBox <gi...@apache.org>]

kaxil commented on a change in pull request #5757: [AIRFLOW-5100] Use safe_mode configuration setting by default
URL: https://github.com/apache/airflow/pull/5757#discussion_r312420059
 
 

 ##########
 File path: airflow/utils/dag_processing.py
 ##########
 @@ -288,18 +288,21 @@ def correct_maybe_zipped(fileloc):
 COMMENT_PATTERN = re.compile(r"\s*#.*")
 
 
-def list_py_file_paths(directory, safe_mode=True,
+def list_py_file_paths(directory, safe_mode=None,
 
 Review comment:
   ```suggestion
   def list_py_file_paths(directory, safe_mode=conf.getboolean('core', 'a', fallback=False)
   ```
   
   This one-liner should work.
   
   Can you also add some tests so that we can discover this kind of issue in future.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services