You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by jiangxb1987 <gi...@git.apache.org> on 2018/09/21 02:41:45 UTC
[GitHub] spark pull request #22458: [SPARK-25459] Add viewOriginalText back to Catalo...
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22458#discussion_r219370221
--- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala ---
@@ -467,9 +467,9 @@ private[hive] class HiveClientImpl(
properties = filteredProperties,
stats = readHiveStats(properties),
comment = comment,
- // In older versions of Spark(before 2.2.0), we expand the view original text and store
- // that into `viewExpandedText`, and that should be used in view resolution. So we get
- // `viewExpandedText` instead of `viewOriginalText` for viewText here.
--- End diff --
This comment is for `viewText`, please rephrase and keep it, thanks!
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org