[GitHub] [james-project] chibenwa edited a comment on pull request #309: Do not copy messages in memory before saving them to the blob store

[GitBox <gi...@apache.org>]

chibenwa edited a comment on pull request #309:
URL: https://github.com/apache/james-project/pull/309#issuecomment-786358253


   1st commit is :green_apple:  on the CI
   
   I run performance tests for this PR...
   
   ## Before
   
   ![Capture d’écran de 2021-02-26 08-58-01](https://user-images.githubusercontent.com/6928740/109244439-4ad23780-7811-11eb-8263-f938bad621b6.png)
   
   ![Capture d’écran de 2021-02-26 08-57-58](https://user-images.githubusercontent.com/6928740/109244444-4c036480-7811-11eb-89fa-998614febc7d.png)
   
   
   ## After
   
   ![Capture d’écran de 2021-02-26 08-58-07](https://user-images.githubusercontent.com/6928740/109244454-5291dc00-7811-11eb-84fc-e970c5a12199.png)
   
   ![Capture d’écran de 2021-02-26 08-58-04](https://user-images.githubusercontent.com/6928740/109244459-53c30900-7811-11eb-920c-24834714bc55.png)
   
   ## Conclusion
   
   Little performance enhancement. Great p99 diminition. More importantly we can notice that no "stop the world GC was triggered" during long period of time, as in the first run.
   
   I will continue looking for places where to avoid memory copies, will fix compilation of the last commit, and continue benches ;-)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org