You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "elharo (via GitHub)" <gi...@apache.org> on 2023/12/28 12:01:51 UTC
[PR] [IO-829] don't decode and reencode characters in a potentially different charset [commons-io]
elharo opened a new pull request, #541:
URL: https://github.com/apache/commons-io/pull/541
This fixes getReader but I think getInputStream and getByteArray are still issues. @garydgregory
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [IO-829] don't decode and reencode characters in a potentially different charset [commons-io]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #541:
URL: https://github.com/apache/commons-io/pull/541#issuecomment-1871106375
## [Codecov](https://app.codecov.io/gh/apache/commons-io/pull/541?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Comparison is base [(`4114db4`)](https://app.codecov.io/gh/apache/commons-io/commit/4114db4a2ef8b214f3d4b794307c0c72c075b1e9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 85.95% compared to head [(`3874d08`)](https://app.codecov.io/gh/apache/commons-io/pull/541?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 85.95%.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #541 +/- ##
=========================================
Coverage 85.95% 85.95%
Complexity 3477 3477
=========================================
Files 230 230
Lines 8222 8222
Branches 960 960
=========================================
Hits 7067 7067
Misses 865 865
Partials 290 290
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/commons-io/pull/541?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [IO-829] Don't decode and reencode characters in a potentially different charset in AbstractOrigin.CharSequenceOrigin.getReader(Charset) [commons-io]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #541:
URL: https://github.com/apache/commons-io/pull/541#issuecomment-1871173169
https://issues.apache.org/jira/browse/IO-829
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [IO-829] don't decode and reencode characters in a potentially different charset [commons-io]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory merged PR #541:
URL: https://github.com/apache/commons-io/pull/541
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [IO-829] don't decode and reencode characters in a potentially different charset [commons-io]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #541:
URL: https://github.com/apache/commons-io/pull/541#issuecomment-1871110656
Is it possible to create a unit test here to show the issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org